Handle AttributeError for jedi completions (missing CompiledObject attribute) (#706)

Author: dalthviz

pyls/plugins/jedi_completion.py

@@ -45,7 +45,16 @@
 
 @hookimpl
 def pyls_completions(config, document, position):
-    definitions = document.jedi_script(position).completions()
+    try:
+        definitions = document.jedi_script(position).completions()
+    except AttributeError as e:
+        if 'CompiledObject' in str(e):
+            # Needed to handle missing CompiledObject attribute
+            # 'sub_modules_dict'
+            definitions = None
+        else:
+            raise e
+
     if not definitions:
         return None
 

setup.py

@@ -67,7 +67,8 @@
         'rope': ['rope>0.10.5'],
         'yapf': ['yapf'],
         'test': ['versioneer', 'pylint', 'pytest', 'mock', 'pytest-cov',
-                 'coverage', 'numpy', 'pandas', 'matplotlib'],
+                 'coverage', 'numpy', 'pandas', 'matplotlib',
+                 'pyqt5;python_version>="3"'],
     },
 
     # To provide executable scripts, use entry points in preference to the

test/plugins/test_completion.py

@@ -124,6 +124,18 @@ def test_jedi_method_completion(config):
     assert everyone_method['insertText'] == 'everyone'
 
 
+@pytest.mark.skipif(PY2 or LooseVersion(jedi.__version__) >= LooseVersion('0.16.0'),
+                    reason='Test only with Jedi <0.16 in Python 3. Check for a fix in future Jedi versions')
+def test_pyqt_completion(config):
+    # Over 'QA' in 'from PyQt5.QtWidgets import QApplication'
+    doc_pyqt = "from PyQt5.QtWidgets import QA"
+    com_position = {'line': 0, 'character': len(doc_pyqt)}
+    doc = Document(DOC_URI, doc_pyqt)
+
+    # Test we don't throw importing elements from PyQt5
+    assert pyls_jedi_completions(config, doc, com_position) is None
+
+
 @pytest.mark.skipif(LooseVersion('0.15.0') <= LooseVersion(jedi.__version__) < LooseVersion('0.16.0'),
                     reason='This test fails with Jedi 0.15')
 def test_numpy_completions(config):