Skip to content

Commit ff7198f

Browse files
committed
Remove some comparisons in our tests that are no longer needed
1 parent 5fa5cd6 commit ff7198f

3 files changed

Lines changed: 0 additions & 14 deletions

File tree

test/plugins/test_completion.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ def test_rope_import_completion(config, workspace):
4545
assert items is None
4646

4747

48-
@pytest.mark.skipif(LooseVersion(jedi.__version__) < LooseVersion('0.14.0'),
49-
reason='This test fails with previous versions of Jedi')
5048
def test_jedi_completion(config):
5149
# Over 'i' in os.path.isabs(...)
5250
com_position = {'line': 1, 'character': 15}

test/plugins/test_definitions.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
11
# Copyright 2017 Palantir Technologies, Inc.
2-
from distutils.version import LooseVersion
3-
import jedi
4-
import pytest
5-
62
from pyls import uris
73
from pyls.plugins.definition import pyls_definitions
84
from pyls.workspace import Document
@@ -38,8 +34,6 @@ def test_definitions(config):
3834
assert [{'uri': DOC_URI, 'range': def_range}] == pyls_definitions(config, doc, cursor_pos)
3935

4036

41-
@pytest.mark.skipif(LooseVersion(jedi.__version__) < LooseVersion('0.14.0'),
42-
reason='This test fails with previous versions of jedi')
4337
def test_builtin_definition(config):
4438
# Over 'i' in dict
4539
cursor_pos = {'line': 8, 'character': 24}

test/plugins/test_symbols.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
11
# Copyright 2017 Palantir Technologies, Inc.
2-
from distutils.version import LooseVersion
3-
import jedi
4-
import pytest
5-
62
from pyls import uris
73
from pyls.plugins.symbols import pyls_document_symbols
84
from pyls.lsp import SymbolKind
@@ -25,8 +21,6 @@ def main(x):
2521
"""
2622

2723

28-
@pytest.mark.skipif(LooseVersion(jedi.__version__) < LooseVersion('0.14.0'),
29-
reason='This test fails with previous versions of jedi')
3024
def test_symbols(config):
3125
doc = Document(DOC_URI, DOC)
3226
config.update({'plugins': {'jedi_symbols': {'all_scopes': False}}})

0 commit comments

Comments
 (0)