on mono on Rosetta environment, crashes with SIGSEGV

[anatawa12]

IMPORTANT: Do NOT use this form to send support questions. If you send things like "How do I do X" or "It does not patch Y" your submission will be closed and you will be forwarded to the official Harmony Discord channel anyway.

OFFICIAL DISCORD: https://discord.gg/xXgghXR

If you think you found a bug in Harmony please use the following to format:

---

Describe the bug
on mono on Rosetta environment, crashes with SIGSEGV

To Reproduce
Steps to reproduce the behavior:

Any trial to patch any method with Harmony for mono on Rosetta will cause SIGSEGV.
This happens in constrcutor of DetourRuntimeMonoPlatform.

error message

=================================================================
        Native Crash Reporting
=================================================================
Got a segv while executing native code. This usually indicates
a fatal error in the mono runtime or one of the native libraries 
used by your application.
=================================================================

=================================================================
        Native stacktrace:
=================================================================
        0x102a4c639 - /Library/Frameworks/Mono.framework/Versions/6.12.0/bin/mono-sgen64 : mono_dump_native_crash_info
        0x1029e43ee - /Library/Frameworks/Mono.framework/Versions/6.12.0/bin/mono-sgen64 : mono_handle_native_crash
        0x102a467b6 - /Library/Frameworks/Mono.framework/Versions/6.12.0/bin/mono-sgen64 : altstack_handle_and_restore
        0x102c2b996 - /Library/Frameworks/Mono.framework/Versions/6.12.0/bin/mono-sgen64 : mono_thread_info_is_current

=================================================================
        Telemetry Dumper:
=================================================================
Pkilling 0x13048594432x from 0x8640361152x
Entering thread summarizer pause from 0x8640361152x
Finished thread summarizer pause from 0x8640361152x.
* Assertion: should not be reached at mini-exceptions.c:452

Expected behavior
No SIGSEGV

Screenshots / Code

using HarmonyLib;
public class test {
    public static void Main(string[] args) {
        var method = typeof(test).GetMethod("Test");

        Memory.GetMethodStart(method, out var exception);

        if (exception != null) throw exception;
    }

    public static void Test() {
    }
}

Runtime environment (please complete the following information):

• OS: macOS 13.0 (22A380)
• .NET version test code: Mono JIT compiler version 6.12.0.182, found: Unity 2019.4.31f1
• Harmony version 2.2.2.2
• Name of game or host application test code: nothing, found: UnityEditor

Additional context
I've reported & created pull request of this problem on MonoMod.Common module.

• on mono on Rosetta environment, falsely detected as ARM and causes crash MonoMod/MonoMod.Common#36
• fix: Rosetta environment is falsely detected as ARM architecture MonoMod/MonoMod.Common#37

The following code will work as workaround. https://github.com/anatawa12/edit-unity-editor-native-method-test/blob/88a5f66adfd7deba4e3ee2768d1fe98d093c1d4a/Test.cs#L96-L171

[pardeike]

Since Harmony 2.3 uses a completely different backend, I would like you to replicate this issue with master (which will be released soon as v2.3). Thank you

[anatawa12]

At 4ff5696 with Debug build, same SIGSEGV happens.

=================================================================
	Native Crash Reporting
=================================================================
Got a segv while executing native code. This usually indicates
a fatal error in the mono runtime or one of the native libraries
used by your application.
=================================================================

=================================================================
	Native stacktrace:
=================================================================
	0x100900639 - /Library/Frameworks/Mono.framework/Versions/6.12.0/bin/mono-sgen64 : mono_dump_native_crash_info
	0x1008983ee - /Library/Frameworks/Mono.framework/Versions/6.12.0/bin/mono-sgen64 : mono_handle_native_crash
	0x1008fa7b6 - /Library/Frameworks/Mono.framework/Versions/6.12.0/bin/mono-sgen64 : altstack_handle_and_restore
	0x100adf996 - /Library/Frameworks/Mono.framework/Versions/6.12.0/bin/mono-sgen64 : mono_thread_info_is_current

=================================================================
	Telemetry Dumper:
=================================================================
Pkilling 0x12978761728x from 0x8605426304x
Entering thread summarizer pause from 0x8605426304x
Finished thread summarizer pause from 0x8605426304x.

[pardeike]

My bad, sorry. You should try with this branch instead: https://github.com/pardeike/Harmony/commits/feature/monomod-core

[anatawa12]

First, a documented public class, public static class Memory is removed so the test code is not working. This is another issue that is a breaking api changes.

Instead, I write the following test code and it looks working.

using HarmonyLib;
using System;

public class test
{
	public static void Main(string[] args) {
		var harmony = new Harmony("test");
		harmony.Patch(
			typeof(test).GetMethod("ToBePatched"),
			prefix: typeof(test).GetMethod("Prefix"));

		ToBePatched();
	}

	public static void ToBePatched()
	{
		Console.WriteLine("ToBePatched");
	}

	public static void Prefix()
	{
		Console.WriteLine("Prefix");
	}
}

[anatawa12]

Also, with that branch, on arm64, the test code is not working. This is another breaking change because it works in v2.2.2.2.

Unhandled Exception:
System.NotImplementedException: The method or operation is not implemented.
  at HarmonyLib.PatchFunctions.UpdateWrapper (System.Reflection.MethodBase original, HarmonyLib.PatchInfo patchInfo) [0x000a0] in <b049aa6c6ea84cdf8b7e35b83781c08d>:0
  at HarmonyLib.PatchProcessor.Patch () [0x00114] in <b049aa6c6ea84cdf8b7e35b83781c08d>:0
  at HarmonyLib.Harmony.Patch (System.Reflection.MethodBase original, HarmonyLib.HarmonyMethod prefix, HarmonyLib.HarmonyMethod postfix, HarmonyLib.HarmonyMethod transpiler, HarmonyLib.HarmonyMethod finalizer) [0x0002b] in <b049aa6c6ea84cdf8b7e35b83781c08d>:0
  at test.Main (System.String[] args) [0x00039] in <4523e5fd51f0406aa4e82be1e7478568>:0
[ERROR] FATAL UNHANDLED EXCEPTION: System.NotImplementedException: The method or operation is not implemented.
  at HarmonyLib.PatchFunctions.UpdateWrapper (System.Reflection.MethodBase original, HarmonyLib.PatchInfo patchInfo) [0x000a0] in <b049aa6c6ea84cdf8b7e35b83781c08d>:0
  at HarmonyLib.PatchProcessor.Patch () [0x00114] in <b049aa6c6ea84cdf8b7e35b83781c08d>:0
  at HarmonyLib.Harmony.Patch (System.Reflection.MethodBase original, HarmonyLib.HarmonyMethod prefix, HarmonyLib.HarmonyMethod postfix, HarmonyLib.HarmonyMethod transpiler, HarmonyLib.HarmonyMethod finalizer) [0x0002b] in <b049aa6c6ea84cdf8b7e35b83781c08d>:0
  at test.Main (System.String[] args) [0x00039] in <4523e5fd51f0406aa4e82be1e7478568>:0

[pardeike]

The important thing is that you need to supply MonoMod.Core 1.0.0-prerelease.1 as it is no longer merged with 0Harmony.dll due to many complaining that this collides with their own version of Cecil (a sub dependency).

[pardeike]

Closed due to lack of feedback

[anatawa12]

Where's lack of feedback? I couldn't find anything I have to tell you in your comment. Sorry for lack of understanding.

The important thing is that you need to supply MonoMod.Core 1.0.0-prerelease.1 as it is no longer merged with 0Harmony.dll due to many complaining that this collides with their own version of Cecil (a sub dependency).