Add explicit types and throw exception if number of required args > 1

Author: patel-vansh

system/Cache/CacheInterface.php

@@ -44,9 +44,9 @@ public function save(string $key, mixed $value, int $ttl = 60): bool;
      * Attempts to get an item from the cache, or executes the callback
      * and stores the result on cache miss.
      *
-     * @param string                                          $key      Cache item name
-     * @param callable(): int|callable(mixed $value): int|int $ttl      Time To Live, in seconds
-     * @param Closure(): mixed                                $callback Callback executed on cache miss
+     * @param string                                   $key      Cache item name
+     * @param callable(): int|callable(mixed): int|int $ttl      Time To Live, in seconds
+     * @param Closure(): mixed                         $callback Callback executed on cache miss
      */
     public function remember(string $key, callable|int $ttl, Closure $callback): mixed;
 

system/Cache/Handlers/BaseHandler.php

@@ -76,9 +76,22 @@ public function remember(string $key, callable|int $ttl, Closure $callback): mix
         $value = $callback();
 
         if (is_callable($ttl)) {
-            $ttl = (new ReflectionFunction(Closure::fromCallable($ttl)))->getNumberOfParameters() > 0
-                ? $ttl($value)
-                : $ttl();
+            $ttlClosure = Closure::fromCallable($ttl);
+            $rf         = new ReflectionFunction($ttlClosure);
+            $params     = $rf->getNumberOfRequiredParameters();
+
+            if ($params === 0) {
+                /** @var Closure(): int $ttlClosure */
+                $ttl = $ttlClosure();
+            } elseif ($params === 1) {
+                /** @var Closure(mixed): int $ttlClosure */
+                $ttl = $ttlClosure($value);
+            } else {
+                throw new InvalidArgumentException(sprintf(
+                    'Argument #2 ($ttl) must accept 0 or 1 parameter, %d given.',
+                    $params,
+                ));
+            }
         }
 
         $this->save($key, $value, $ttl);