Skip to content

Commit 95e4622

Browse files
apply suggestion
Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>
1 parent 8b254bf commit 95e4622

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

tests/system/Database/Live/SQLSRV/IncrementTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,10 @@ public function testIncrementWhenCastTextToIntFalse(): void
4343
{
4444
$this->hasInDatabase('job', ['name' => 'incremental', 'created_at' => 6]);
4545

46-
$this->assertInstanceOf(Builder::class, $this->db->table('job'));
47-
4846
$builder = $this->db->table('job');
4947

48+
$this->assertInstanceOf(Builder::class, $builder);
49+
5050
$builder->castTextToInt = false;
5151

5252
$builder->where('name', 'incremental')
@@ -59,10 +59,10 @@ public function testDecrementWhenCastTextToIntFalse(): void
5959
{
6060
$this->hasInDatabase('job', ['name' => 'decremental', 'created_at' => 6]);
6161

62-
$this->assertInstanceOf(Builder::class, $this->db->table('job'));
63-
6462
$builder = $this->db->table('job');
6563

64+
$this->assertInstanceOf(Builder::class, $builder);
65+
6666
$builder->castTextToInt = false;
6767

6868
$builder->where('name', 'decremental')

user_guide_src/source/changelogs/v4.7.3.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ Bugs Fixed
4040
- **CLI:** Fixed a bug where ``CLI::generateDimensions()`` leaked ``stty`` error output (e.g., ``stty: 'standard input': Inappropriate ioctl for device``) to stderr when stdin was not a TTY.
4141
- **Commands:** Fixed a bug in the ``env`` command where passing options only would cause the command to throw a ``TypeError`` instead of showing the current environment.
4242
- **Common:** Fixed a bug where the ``command()`` helper function did not properly clean up output buffers, which could lead to risky tests when exceptions were thrown.
43+
- **Database:** Fixed a bug where the SQLSRV driver's decrement method was adding instead of subtracting the decrement value when ``$castTextToInt`` was false.
4344
- **Validation:** Fixed a bug where ``Validation::getValidated()`` dropped fields whose validated value was explicitly ``null``.
44-
- **SQLSRV Database Driver:** Fixed a bug where the SQLSRV driver's decrement method was adding instead of subtracting the decrement value when ``$castTextToInt`` was false.
4545

4646
See the repo's
4747
`CHANGELOG.md <https://github.com/codeigniter4/CodeIgniter4/blob/develop/CHANGELOG.md>`_

0 commit comments

Comments
 (0)