v1.1.0

Author: benpoulson

.github/workflows/ci.yml

@@ -14,23 +14,14 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  php-tests:
-    name: PHP 8.2 / CodeIgniter 4.3
+  floor:
+    name: PHP 8.2 / CodeIgniter 4.3.8
     runs-on: ubuntu-latest
 
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
 
-      - name: Checkout local Perfbase PHP SDK
-        uses: actions/checkout@v4
-        with:
-          repository: perfbaseorg/php-sdk
-          path: lib-php-sdk-src
-
-      - name: Link sibling SDK checkout
-        run: ln -s "$GITHUB_WORKSPACE/lib-php-sdk-src" "$GITHUB_WORKSPACE/../lib-php-sdk"
-
       - name: Set up PHP
         uses: shivammathur/setup-php@v2
         with:
@@ -50,3 +41,31 @@ jobs:
 
       - name: Run PHPUnit
         run: composer run test -- --coverage-text
+
+  upper-bound:
+    name: PHP 8.4 / CodeIgniter 4.7.2
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: '8.4'
+          coverage: none
+          tools: composer
+          extensions: pcntl
+
+      - name: Pin CodeIgniter 4.7.2
+        run: composer require --no-update codeigniter4/framework:4.7.2
+
+      - name: Install dependencies
+        run: composer update --prefer-dist --no-progress --no-interaction
+
+      - name: Run PHPStan
+        run: composer run phpstan
+
+      - name: Run PHPUnit
+        run: composer run test -- --no-coverage --do-not-fail-on-risky

.github/workflows/compatibility.yml

@@ -38,15 +38,6 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v4
 
-      - name: Checkout local Perfbase PHP SDK
-        uses: actions/checkout@v4
-        with:
-          repository: perfbaseorg/php-sdk
-          path: lib-php-sdk-src
-
-      - name: Link sibling SDK checkout
-        run: ln -s "$GITHUB_WORKSPACE/lib-php-sdk-src" "$GITHUB_WORKSPACE/../lib-php-sdk"
-
       - name: Set up PHP
         uses: shivammathur/setup-php@v2
         with:

README.md

@@ -41,7 +41,7 @@ Not supported in v1:
 - PHP `>=8.2 <8.5`
 - CodeIgniter `^4.3.8`
 - Perfbase PHP extension
-- `perfbase/php-sdk` `1.0.0`
+- `perfbase/php-sdk` `^1.0`
 
 Optional:
 
@@ -57,7 +57,7 @@ Install the package:
 composer require perfbase/codeigniter4
 ```
 
-For monorepo development, this package is already configured to use the local sibling SDK checkout via the path repository in `composer.json`.
+This package resolves `perfbase/php-sdk` from Packagist by default. If you need to test against an unpublished SDK branch in a monorepo, add a temporary Composer repository override locally instead of assuming a built-in path repository.
 
 ## Quick Start
 
@@ -188,9 +188,16 @@ The doctor checks:
 
 If worker mode is detected, the doctor also prints a reminder to restart workers after config or deployment changes.
 
-## Compatibility Testing
+## Verification and Compatibility Testing
 
-Normal package CI stays on the declared support floor. Older CodeIgniter 4 minors should be tested explicitly.
+Required PR CI stays intentionally small:
+
+- PHP `8.2` / CodeIgniter `4.3.8`
+- PHP `8.4` / CodeIgniter `4.7.2`
+
+Manual compatibility probes cover the wider declared CodeIgniter 4 range and are used when validating the support floor or widening support claims.
+
+If you run local `composer install` on PHP `8.4`, Composer may resolve a newer compatible CodeIgniter release than the declared floor. Use `bin/test-compat` or the manual compatibility workflow when you need to verify the floor explicitly.
 
 ### Local Docker Compatibility Probes
 
@@ -204,7 +211,7 @@ bin/test-compat --php 8.2 --framework 4.6.5
 
 Notes:
 
-- The script mounts the parent `projects/` directory so the local sibling `lib-php-sdk` path repository continues to work inside the container.
+- The script uses Packagist dependency resolution, matching the published package behavior.
 - `--ignore-php-platform` is intended for floor exploration when the package's current declared PHP floor is higher than the probe target.
 - The script runs `composer update`, `composer run phpstan`, and `composer run test` inside the selected container image.
 

bin/test-compat

@@ -7,7 +7,7 @@ REPO_ROOT="$(cd "${SCRIPT_DIR}/.." && pwd)"
 WORKSPACE_ROOT="$(cd "${REPO_ROOT}/.." && pwd)"
 
 PHP_VERSION="${PHP_VERSION:-8.2}"
-FRAMEWORK_VERSION="${FRAMEWORK_VERSION:-4.6.5}"
+FRAMEWORK_VERSION="${FRAMEWORK_VERSION:-4.3.8}"
 RUN_PHPSTAN=1
 RUN_TESTS=1
 REBUILD_IMAGE=1
@@ -19,7 +19,7 @@ Usage: bin/test-compat [options]
 
 Options:
   --php <version>              PHP version for the container image. Default: 8.2
-  --framework <version>        CodeIgniter framework version to install. Default: 4.6.5
+  --framework <version>        CodeIgniter framework version to install. Default: 4.3.8
   --skip-phpstan               Skip PHPStan.
   --skip-tests                 Skip PHPUnit.
   --ignore-php-platform        Run Composer with --ignore-platform-req=php.
@@ -74,12 +74,21 @@ IMAGE_TAG="perfbase-codeigniter4-compat:php-${PHP_VERSION//./-}"
 CONFIGURE_COMMAND="composer config audit.block-insecure false"
 REQUIRE_COMMAND="composer require --no-interaction --no-progress --no-update codeigniter4/framework:${FRAMEWORK_VERSION}"
 UPDATE_COMMAND="composer update --with-all-dependencies --prefer-dist --no-progress --no-interaction"
+TMP_WORKDIR="/tmp/lib-codeigniter4-compat-${PHP_VERSION//./-}-${FRAMEWORK_VERSION//./-}-$RANDOM"
 
 if [[ "${IGNORE_PHP_PLATFORM}" -eq 1 ]]; then
     UPDATE_COMMAND="${UPDATE_COMMAND} --ignore-platform-req=php"
 fi
 
-COMMANDS=("${CONFIGURE_COMMAND}" "${REQUIRE_COMMAND}" "${UPDATE_COMMAND} codeigniter4/framework")
+COMMANDS=(
+    "rm -rf ${TMP_WORKDIR}"
+    "cp -R /workspace/lib-codeigniter4 ${TMP_WORKDIR}"
+    "cd ${TMP_WORKDIR}"
+    "rm -rf vendor composer.lock .phpunit.cache"
+    "${CONFIGURE_COMMAND}"
+    "${REQUIRE_COMMAND}"
+    "${UPDATE_COMMAND}"
+)
 
 if [[ "${RUN_PHPSTAN}" -eq 1 ]]; then
     COMMANDS+=("composer run phpstan")

src/Runtime/PerfbaseCommands.php

@@ -10,12 +10,18 @@
 class PerfbaseCommands extends Commands
 {
     /**
+     * Mirrors CodeIgniter's Commands::run() behavior as closely as possible
+     * while adding Perfbase-specific lifecycle events. If the supported
+     * framework floor changes, compare this method against the upstream
+     * implementation again before modifying it.
+     *
      * @param array<int|string, string|null> $params
+     * @return int|void
      */
     public function run(string $command, array $params)
     {
         if (!$this->verifyCommand($command, $this->commands)) {
-            return EXIT_ERROR;
+            return;
         }
 
         $className = $this->commands[$command]['class'];

tests/Unit/Runtime/PerfbaseCommandsTest.php

@@ -12,11 +12,44 @@
 
 final class PerfbaseCommandsTest extends TestCase
 {
-    public function testRunReturnsErrorForUnknownCommand(): void
+    public function testRunMatchesNativeBehaviorForUnknownCommand(): void
     {
-        $commands = new PerfbaseCommands(service('logger'));
+        $commands = new class (service('logger')) extends PerfbaseCommands {
+            public bool $verifyCalled = false;
+
+            public function verifyCommand(string $command, array $commands): bool
+            {
+                $this->verifyCalled = true;
+
+                return false;
+            }
+        };
+        $nativePreCalled = false;
+        $nativePostCalled = false;
+        $perfbasePreCalled = false;
+        $perfbasePostCalled = false;
 
-        self::assertSame(EXIT_ERROR, $commands->run('missing:command', []));
+        Events::on('pre_command', static function () use (&$nativePreCalled): void {
+            $nativePreCalled = true;
+        });
+        Events::on('post_command', static function () use (&$nativePostCalled): void {
+            $nativePostCalled = true;
+        });
+        Events::on('perfbase_pre_command', static function () use (&$perfbasePreCalled): void {
+            $perfbasePreCalled = true;
+        });
+        Events::on('perfbase_post_command', static function () use (&$perfbasePostCalled): void {
+            $perfbasePostCalled = true;
+        });
+
+        $result = $commands->run('missing:command', []);
+
+        self::assertTrue($commands->verifyCalled);
+        self::assertTrue($result === null);
+        self::assertFalse($nativePreCalled);
+        self::assertFalse($nativePostCalled);
+        self::assertFalse($perfbasePreCalled);
+        self::assertFalse($perfbasePostCalled);
     }
 
     public function testRunPreservesNativeEventsAndAddsPerfbaseEventsForSuccess(): void
@@ -71,9 +104,13 @@ public function testRunDoesNotTriggerNativePostCommandOnFailure(): void
             ],
         ]);
 
+        $nativePreCalled = false;
         $nativePostCalled = false;
         $perfbasePostArgs = null;
 
+        Events::on('pre_command', static function () use (&$nativePreCalled): void {
+            $nativePreCalled = true;
+        });
         Events::on('post_command', static function () use (&$nativePostCalled): void {
             $nativePostCalled = true;
         });
@@ -86,6 +123,7 @@ public function testRunDoesNotTriggerNativePostCommandOnFailure(): void
         try {
             $commands->run('test:fail', []);
         } finally {
+            self::assertTrue($nativePreCalled);
             self::assertFalse($nativePostCalled);
             self::assertIsArray($perfbasePostArgs);
             self::assertSame('test:fail', $perfbasePostArgs[0]);