refactor: deprecate old log_error method

Author: jaredhendrickson13

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Core/BaseTraits.inc

@@ -66,13 +66,4 @@ trait BaseTraits {
         syslog(priority: $level, message: $message);
         closelog();
     }
-
-    /**
-     * Logs an error to the syslog.
-     * @param string $message The error message to write to the syslog
-     */
-    public static function log_error(string $message): void {
-        # Call the pfSense `log_error` function
-        log_error($message);
-    }
 }

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/CertificateAuthorityRenew.inc

@@ -120,7 +120,7 @@ class CertificateAuthorityRenew extends Model {
         # Otherwise, continue with the renewal
         $this->newserial->value = cert_get_serial($ca_config['item']['crt']);
         $msg = "Renewed CA {$ca_config['item']['descr']} ({$ca_config['item']['refid']}) - Serial {$this->oldserial->value} -> {$this->newserial->value}";
-        $this->log_error($msg);
+        $this->log(level: LOG_ERR, message: $msg, logfile: "system");
         $this->write_config($msg);
     }
 

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/CertificateRenew.inc

@@ -120,7 +120,7 @@ class CertificateRenew extends Model {
         # Otherwise, continue with the renewal
         $this->newserial->value = cert_get_serial($cert_config['item']['crt']);
         $msg = "Renewed certificate {$cert_config['item']['descr']} ({$cert_config['item']['refid']}) - Serial {$this->oldserial->value} -> {$this->newserial->value}";
-        $this->log_error($msg);
+        $this->log(level: LOG_ERR, message: $msg, logfile: "system");
         $this->write_config($msg);
     }
 

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/RESTAPIAccessListEntry.inc

@@ -137,7 +137,8 @@ class RESTAPIAccessListEntry extends Model {
 
         # If the assigned schedule no longer exists, log the event and deny access
         if (!$this->sched->get_related_model()) {
-            $this->log_error(
+            $this->log(
+                level: LOG_ERR,
                 message: "The schedule '{$this->sched->value}' assigned to REST API access list entry " .
                     "'$this->id' no longer exists.",
             );

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/RESTAPISettingsSync.inc

@@ -122,13 +122,13 @@ class RESTAPISettingsSync extends Model {
             # Log an error if the HTTP failed
             if (!$response) {
                 cprint(message: 'failed.' . PHP_EOL, condition: $print_status);
-                self::log_error("Failed to sync REST API settings to $ha_sync_host: no response received.");
+                self::log(level: LOG_ERR, message: "Failed to sync REST API settings to $ha_sync_host: no response received.");
             } elseif (!$response_json) {
                 cprint(message: 'failed.' . PHP_EOL, condition: $print_status);
-                self::log_error("Failed to sync REST API settings to $ha_sync_host: received unexpected response.");
+                self::log(level: LOG_ERR, message: "Failed to sync REST API settings to $ha_sync_host: received unexpected response.");
             } elseif ($response_json['code'] !== 200) {
                 cprint(message: 'failed.' . PHP_EOL, condition: $print_status);
-                self::log_error("Failed to sync REST API settings to $ha_sync_host: {$response_json['message']}");
+                self::log(level: LOG_ERR, message: "Failed to sync REST API settings to $ha_sync_host: {$response_json['message']}");
             } else {
                 cprint(message: 'done.' . PHP_EOL, condition: $print_status);
             }

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/RESTAPIVersion.inc

@@ -236,8 +236,8 @@ class RESTAPIVersion extends Model {
 
             # If an error occurred either deleting or adding the package, return false
             if ($delete->result_code !== 0 or $add->result_code !== 0) {
-                $this->log_error($delete->output);
-                $this->log_error($add->output);
+                $this->log(level: LOG_ERR, message: $delete->output);
+                $this->log(level: LOG_ERR, message: $add->output);
                 return false;
             }
 

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Models/SSH.inc

@@ -56,11 +56,11 @@ class SSH extends Model {
     public function apply() {
         # Stop the sshd service
         killbyname('sshd');
-        $this->log_error('secure shell configuration has changed. Stopping sshd.');
+        $this->log(level: LOG_ERR, message: 'secure shell configuration has changed. Stopping sshd.', logfile: "system");
 
         # If sshd is still enabled, restart the sshd service using the new config
         if (config_path_enabled('system/ssh', 'enable')) {
-            $this->log_error('secure shell configuration has changed. Restarting sshd.');
+            $this->log(level: LOG_ERR, message: 'secure shell configuration has changed. Restarting sshd.', logfile: "system");
             send_event('service restart sshd');
         }
     }