Fixed small bug preventing port forward rules from being sorted

Jared Hendrickson · Jared Hendrickson · commit e3065f874c7b · 2020-11-18T15:01:13.000-07:00
diff --git a/pfSense-pkg-API/files/etc/inc/api/framework/APITools.inc b/pfSense-pkg-API/files/etc/inc/api/framework/APITools.inc
@@ -301,7 +301,7 @@ function sort_nat_rules($top=false, $data=null) {
             $sort_arr[] = $fre;
         }
     }
-    if (!empty($config["nat"]["rule"])) {
+    if (!empty($sort_arr)) {
         $config["nat"]["rule"] = $sort_arr;
     } else {
         unset($config["nat"]["rule"]);

Original file line number	Diff line number	Diff line change
`@@ -301,7 +301,7 @@ function sort_nat_rules($top=false, $data=null) {`
`301`	`301`	`$sort_arr[] = $fre;`
`302`	`302`	`}`
`303`	`303`	`}`
`304`		`- if (!empty($config["nat"]["rule"])) {`
	`304`	`+ if (!empty($sort_arr)) {`
`305`	`305`	`$config["nat"]["rule"] = $sort_arr;`
`306`	`306`	`} else {`
`307`	`307`	`unset($config["nat"]["rule"]);`