Fixed issue in APITools.inc that prevented the full privilege list from being parsed

Author: jaredhendrickson13

pfSense-pkg-API/files/etc/inc/api/framework/APIResponse.inc

@@ -1934,7 +1934,7 @@ function get($id, $data=[], $all=false) {
 
 
     ];
-    $response = $responses[(!array_key_exists($id, $responses)) ? $id : 1];
+    $response = $responses[(array_key_exists($id, $responses)) ? $id : 1];
     $response["data"] = $data;
     if ($all === true) {
         $response = $responses;

pfSense-pkg-API/files/etc/inc/api/framework/APITools.inc

@@ -23,6 +23,7 @@ require_once("util.inc");
 require_once("interfaces.inc");
 require_once("interfaces_fast.inc");
 require_once("priv.defs.inc");
+require_once("priv.inc");
 require_once("service-utils.inc");
 require_once("filter.inc");
 require_once("shaper.inc");

pfSense-pkg-API/files/etc/inc/api/models/APIUserCreate.inc

@@ -45,7 +45,7 @@ class APIUserCreate extends APIModel {
                     # Ensure username is not reserved by the system
                     if (!$this->is_username_reserved($this->initial_data["username"])) {
                         # Ensure username is not longer that 32 characters
-                        if (strlen($this->initial_data["username"]) > 32) {
+                        if (strlen($this->initial_data["username"]) <= 32) {
                             $this->validated_data["name"] = $this->initial_data['username'];
                         } else {
                             $this->errors[] = APIResponse\get(5038);