Update eslint dependencies (Comcast#3877)

* Sort rules

* Migrate to `@eslint-react/eslint-plugin`

* Use prettier to format everything

* Disable formatting

Author: amanmahajan7

.prettierignore

@@ -1,4 +1,2 @@
-*.js
-*.json
-*.css
+package.json
 /website/routeTree.gen.ts

biome.json

@@ -1,5 +1,6 @@
 {
   "$schema": "./node_modules/@biomejs/biome/configuration_schema.json",
+  "assist": { "actions": { "source": { "organizeImports": "off" } } },
   "files": {
     "includes": [
       "**",
@@ -16,33 +17,19 @@
     ]
   },
   "formatter": {
-    "includes": ["**", "!**/*.ts", "!**/*.tsx", "!package.json"],
-    "indentStyle": "space",
-    "lineWidth": 100
+    "enabled": false
   },
   "json": {
     "parser": {
       "allowComments": true,
       "allowTrailingCommas": true
     }
   },
-  "javascript": {
-    "formatter": {
-      "quoteStyle": "single",
-      "trailingCommas": "none"
-    }
-  },
-  "css": {
-    "formatter": {
-      "quoteStyle": "single"
-    }
-  },
   "linter": {
     "domains": {
       "project": "recommended"
     },
     "rules": {
-      "recommended": false,
       "a11y": {
         "noAccessKey": "warn",
         "noAriaHiddenOnFocusable": "warn",
@@ -193,8 +180,8 @@
         "useSingleJsDocAsterisk": "warn",
         "useUniqueElementIds": "off",
         "useValidForDirection": "warn",
-        "useYield": "warn",
-        "useValidTypeof": "warn"
+        "useValidTypeof": "warn",
+        "useYield": "warn"
       },
       "performance": {
         "noAccumulatingSpread": "warn",
@@ -206,6 +193,7 @@
         "noReExportAll": "off",
         "useTopLevelRegex": "warn"
       },
+      "recommended": false,
       "security": {
         "noBlankTarget": "warn",
         "noDangerouslySetInnerHtml": "warn",
@@ -215,15 +203,16 @@
       "style": {
         "noDefaultExport": "off",
         "noDoneCallback": "warn",
-        "noExportedImports": "off",
         "noEnum": "off",
+        "noExportedImports": "off",
         "noImplicitBoolean": "off",
         "noInferrableTypes": "warn",
         "noNamespace": "warn",
         "noNegationElse": "warn",
         "noNonNullAssertion": "off",
         "noParameterAssign": "off",
         "noParameterProperties": "warn",
+        "noRestrictedGlobals": "warn",
         "noRestrictedImports": {
           "level": "warn",
           "options": {
@@ -239,7 +228,6 @@
             }
           }
         },
-        "noRestrictedGlobals": "warn",
         "noShoutyConstants": "warn",
         "noSubstr": "off",
         "noUnusedTemplateLiteral": "warn",
@@ -250,8 +238,8 @@
         "useAtIndex": "off",
         "useBlockStatements": "off",
         "useCollapsedElseIf": "warn",
-        "useComponentExportOnlyModules": "off",
         "useCollapsedIf": "warn",
+        "useComponentExportOnlyModules": "off",
         "useConsistentArrayType": "warn",
         "useConsistentBuiltinInstantiation": "warn",
         "useConsistentObjectDefinitions": "warn",
@@ -361,7 +349,6 @@
       }
     }
   },
-  "assist": { "actions": { "source": { "organizeImports": "off" } } },
   "overrides": [
     {
       "includes": ["**/*.test.*"],
@@ -385,6 +372,14 @@
           }
         }
       }
+    },
+    {
+      "assist": {
+        "actions": {
+          "source": { "useSortedKeys": "on" }
+        }
+      },
+      "includes": ["./biome.json"]
     }
   ]
 }

eslint.config.js

@@ -1,15 +1,15 @@
+import reactX from '@eslint-react/eslint-plugin';
+import markdown from '@eslint/markdown';
 import typescriptEslint from '@typescript-eslint/eslint-plugin';
 import tsParser from '@typescript-eslint/parser';
 import vitest from '@vitest/eslint-plugin';
-import { defineConfig, globalIgnores } from 'eslint/config';
 import jestDom from 'eslint-plugin-jest-dom';
 import react from 'eslint-plugin-react';
 import reactCompiler from 'eslint-plugin-react-compiler';
 import reactHooks from 'eslint-plugin-react-hooks';
-import reactHooksExtra from 'eslint-plugin-react-hooks-extra';
 import sonarjs from 'eslint-plugin-sonarjs';
 import testingLibrary from 'eslint-plugin-testing-library';
-import markdown from '@eslint/markdown';
+import { defineConfig, globalIgnores } from 'eslint/config';
 
 export default defineConfig([
   globalIgnores(['.cache', '.nitro', '.output', '.tanstack', 'coverage', 'dist', 'lib']),
@@ -28,7 +28,7 @@ export default defineConfig([
       react,
       'react-compiler': reactCompiler,
       'react-hooks': reactHooks,
-      'react-hooks-extra': reactHooksExtra,
+      'react-x': reactX,
       sonarjs,
       '@typescript-eslint': typescriptEslint
     },
@@ -249,6 +249,7 @@ export default defineConfig([
       'prefer-rest-params': 1,
       'prefer-spread': 1,
       'prefer-template': 1,
+      'preserve-caught-error': 1,
       radix: 1,
       'require-await': 0, // replaced by @typescript-eslint/require-await
       'require-unicode-regexp': 0,
@@ -393,10 +394,10 @@ export default defineConfig([
 
       // React Hooks Extra
       // https://eslint-react.xyz/
-      'react-hooks-extra/no-unnecessary-use-callback': 1,
-      'react-hooks-extra/no-unnecessary-use-memo': 1,
-      'react-hooks-extra/no-unnecessary-use-prefix': 1,
-      'react-hooks-extra/prefer-use-state-lazy-initialization': 1,
+      'react-x/no-unnecessary-use-callback': 1,
+      'react-x/no-unnecessary-use-memo': 1,
+      'react-x/no-unnecessary-use-prefix': 1,
+      'react-x/prefer-use-state-lazy-initialization': 1,
 
       // SonarJS rules
       // https://github.com/SonarSource/eslint-plugin-sonarjs#rules
@@ -606,6 +607,7 @@ export default defineConfig([
       'vitest/consistent-test-filename': 0,
       'vitest/consistent-test-it': 1,
       'vitest/expect-expect': 0,
+      'vitest/hoisted-apis-on-top': 1,
       'vitest/max-expects': 0,
       'vitest/max-nested-describe': 0,
       'vitest/no-alias-methods': 1,
@@ -755,7 +757,10 @@ export default defineConfig([
       'markdown/no-missing-atx-heading-space': 1,
       'markdown/no-missing-label-refs': 1,
       'markdown/no-missing-link-fragments': 1,
+      'markdown/no-multiple-h1': 1,
+      'markdown/no-reference-like-urls': 1,
       'markdown/no-reversed-media-syntax': 1,
+      'markdown/no-space-in-emphasis': 1,
       'markdown/no-unused-definitions': 1,
       'markdown/require-alt-text': 1,
       'markdown/table-column-count': 1

package.json

@@ -54,7 +54,8 @@
   "devDependencies": {
     "@babel/preset-typescript": "^7.27.1",
     "@biomejs/biome": "2.2.4",
-    "@eslint/markdown": "^7.1.0",
+    "@eslint-react/eslint-plugin": "^2.0.2",
+    "@eslint/markdown": "^7.3.0",
     "@faker-js/faker": "^10.0.0",
     "@ianvs/prettier-plugin-sort-imports": "^4.6.2",
     "@linaria/core": "^6.3.0",
@@ -71,14 +72,13 @@
     "@vitest/eslint-plugin": "^1.3.4",
     "@wyw-in-js/rollup": "^0.7.0",
     "@wyw-in-js/vite": "^0.7.0",
-    "eslint": "^9.34.0",
+    "eslint": "^9.36.0",
     "eslint-plugin-jest-dom": "^5.5.0",
-    "eslint-plugin-react": "^7.37.4",
+    "eslint-plugin-react": "^7.37.5",
     "eslint-plugin-react-compiler": "^19.1.0-rc.2",
     "eslint-plugin-react-hooks": "^5.2.0",
-    "eslint-plugin-react-hooks-extra": "^1.52.6",
     "eslint-plugin-sonarjs": "^3.0.5",
-    "eslint-plugin-testing-library": "^7.6.6",
+    "eslint-plugin-testing-library": "^7.10.0",
     "jspdf": "^3.0.1",
     "jspdf-autotable": "^5.0.2",
     "playwright": "^1.54.2",