fix: scss and less language sercvice was using css langauage service

Author: abose

src/css-ls.js

@@ -1,6 +1,8 @@
 import * as cssLangService from 'vscode-css-languageservice';
 
-const service = cssLangService.getCSSLanguageService();
+const cssService = cssLangService.getCSSLanguageService();
+const lessService = cssLangService.getLESSLanguageService();
+const scssService = cssLangService.getSCSSLanguageService();
 export const CSS_MODES = {
     CSS: "css",
     LESS: "less",
@@ -14,6 +16,17 @@ export const DiagnosticSeverity = {
     hint: 4
 };
 
+function _getLanguageServiceToUse(cssMode) {
+    switch (cssMode) {
+    case "less": return lessService;
+    case "scss": return scssService;
+    case "css": return cssService;
+    default:
+        console.error("Unknown language mode: ", cssMode, "passed to css language service");
+        return cssService;
+    }
+}
+
 function getTextDocument(text, languageID, filePath = "file://placeholder.css") {
     return cssLangService.TextDocument.create(filePath, languageID, 1, text);
 }
@@ -27,6 +40,7 @@ function getTextDocument(text, languageID, filePath = "file://placeholder.css")
  */
 export function getAllSymbols(text, cssMode, filePath) {
     const textDocument = getTextDocument(text, cssMode, filePath);
+    const service = _getLanguageServiceToUse(cssMode);
     const stylesheet = service.parseStylesheet(textDocument);
     const output = [];
     for(let symbol of service.findDocumentSymbols(textDocument, stylesheet)) {
@@ -81,6 +95,7 @@ export function getAllSymbols(text, cssMode, filePath) {
  */
 export function validateCSS(text, cssMode, filePath, lintSettings) {
     const textDocument = getTextDocument(text, cssMode, filePath);
+    const service = _getLanguageServiceToUse(cssMode);
     const stylesheet = service.parseStylesheet(textDocument);
     return  service.doValidation(textDocument, stylesheet, {
         validate: true,

test/test-css.worker.js

@@ -71,7 +71,7 @@ describe(`web worker CSS Language tests`, async function () {
         worker.postMessage({command: `getAllSymbols`, text, cssMode: "SCSS", filePath: "file:///c.scss"});
         let output = await waitForWorkerMessage(`getAllSymbols`, 1000);
         const symbols = output.symbols;
-        expect(symbols).to.deep.equal(['.info', '.alert', '#success']);
+        expect(symbols).to.deep.equal(["theme", '.info', '.alert', '#success']);
     });
 
     /**
@@ -369,4 +369,24 @@ describe(`web worker CSS Language tests`, async function () {
         const symbols = output.diag;
         expect(symbols).to.deep.equal(cssValidationData["emptyRules"]);
     });
+
+    it("should validate less emptyRules by default", async function () {
+        const cssValidationData = await (await fetch("test-files/cssValidationData.json")).json();
+        messageFromWorker = null;
+        const text = `// less supports comments\n.box {}`;
+        worker.postMessage({command: `validateCSS`, text, cssMode: "LESS", filePath: "file:///c.less"});
+        let output = await waitForWorkerMessage(`validateCSS`, 1000);
+        const symbols = output.diag;
+        expect(symbols).to.deep.equal(cssValidationData["emptyRulesLESS"]);
+    });
+
+    it("should validate scss emptyRules by default", async function () {
+        const cssValidationData = await (await fetch("test-files/cssValidationData.json")).json();
+        messageFromWorker = null;
+        const text = `// less supports comments\n.box {}`;
+        worker.postMessage({command: `validateCSS`, text, cssMode: "SCSS", filePath: "file:///c.scss"});
+        let output = await waitForWorkerMessage(`validateCSS`, 1000);
+        const symbols = output.diag;
+        expect(symbols).to.deep.equal(cssValidationData["emptyRulesSCSS"]);
+    });
 });

test/test-files/css-tests/b.less

@@ -1,3 +1,4 @@
+// this is a test
 #header {
   color: black;
   .navigation {

test/test-files/cssValidationData.json

@@ -62,6 +62,38 @@
       }
     }
   }],
+  "emptyRulesLESS" : [{
+    "code": "emptyRules",
+    "source": "less",
+    "message": "Do not use empty rulesets",
+    "severity": 2,
+    "range": {
+      "start": {
+        "line": 1,
+        "character": 0
+      },
+      "end": {
+        "line": 1,
+        "character": 4
+      }
+    }
+  }],
+  "emptyRulesSCSS": [{
+    "code": "emptyRules",
+    "source": "scss",
+    "message": "Do not use empty rulesets",
+    "severity": 2,
+    "range": {
+      "start": {
+        "line": 1,
+        "character": 0
+      },
+      "end": {
+        "line": 1,
+        "character": 4
+      }
+    }
+  }],
   "zeroUnits": [{
     "code": "zeroUnits",
     "source": "css",