fix: release dist failing to launch lp edit

Author: abose

gulpfile.js/index.js

@@ -91,30 +91,19 @@ function _cleanPhoenixProGitFolder() {
 
 function _deletePhoenixProSourceFolder() {
     return new Promise((resolve) => {
-        // 1. Delete everything in dist folder
-        const distFolder = 'dist/extensionsIntegrated/phoenix-pro';
-        if (fs.existsSync(distFolder)) {
-            fs.rmSync(distFolder, { recursive: true, force: true });
-            console.log(`Deleted phoenix-pro source folder: ${distFolder}`);
-        }
-
-        // 2. Selectively delete in dist-test folder, keeping test files
-        const distTestFolder = 'dist-test/src/extensionsIntegrated/phoenix-pro';
-        if (fs.existsSync(distTestFolder)) {
-            const items = fs.readdirSync(distTestFolder);
-            const keepItems = ['unittests.js', 'unit-tests'];
-
-            for (const item of items) {
-                if (keepItems.includes(item)) {
-                    console.log(`Retained for testing: ${distTestFolder}/${item}`);
-                } else {
-                    const itemPath = path.join(distTestFolder, item);
-                    fs.rmSync(itemPath, { recursive: true, force: true });
-                    console.log(`Deleted: ${itemPath}`);
-                }
-            }
-        }
-
+        // todo we cant do this yet lots of issues happening due to missing files in dist test mainly
+        //  which i also suspect are actual issues
+        // const phoenixProFolders = [
+        //     'dist/extensionsIntegrated/phoenix-pro',
+        //     'dist-test/src/extensionsIntegrated/phoenix-pro'
+        // ];
+        //
+        // for (const folder of phoenixProFolders) {
+        //     if (fs.existsSync(folder)) {
+        //         fs.rmSync(folder, { recursive: true, force: true });
+        //         console.log(`Deleted phoenix-pro source folder: ${folder}`);
+        //     }
+        // }
         resolve();
     });
 }

src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

@@ -5943,10 +5943,7 @@ function RemoteFunctions(config = {}) {
     }
 
     let customReturns = {};
-    // the below code comment is replaced by added scripts for extensibility
-    // DONT_STRIP_MINIFY:REPLACE_WITH_ADDED_REMOTE_SCRIPTS
-
-    return {
+    customReturns = { // we have to do this else the minifier will strip the customReturns variable
         ...customReturns,
         "DOMEditHandler"        : DOMEditHandler,
         "hideHighlight"         : hideHighlight,
@@ -5963,4 +5960,9 @@ function RemoteFunctions(config = {}) {
         "showToastMessage" : showToastMessage,
         "cancelSVGDragIfActive" : cancelSVGDragIfActive
     };
+
+    // the below code comment is replaced by added scripts for extensibility
+    // DONT_STRIP_MINIFY:REPLACE_WITH_ADDED_REMOTE_SCRIPTS
+
+    return customReturns;
 }

src/extensionsIntegrated/Phoenix-live-preview/main.js

@@ -174,13 +174,6 @@ define(function (require, exports, module) {
             isProEditUser = false;
         }
     }
-    if(!Phoenix.isSpecRunnerWindow){
-        _entitlementsChanged();
-        KernalModeTrust.EntitlementsManager.on(
-            KernalModeTrust.EntitlementsManager.EVENT_ENTITLEMENTS_CHANGED,
-            _entitlementsChanged
-        );
-    }
 
     StaticServer.on(EVENT_EMBEDDED_IFRAME_WHO_AM_I, function () {
         if($iframe && $iframe[0]) {
@@ -1312,6 +1305,13 @@ define(function (require, exports, module) {
             }
         }, 1000);
         _projectOpened();
+        if(!Phoenix.isSpecRunnerWindow){
+            _entitlementsChanged();
+            KernalModeTrust.EntitlementsManager.on(
+                KernalModeTrust.EntitlementsManager.EVENT_ENTITLEMENTS_CHANGED,
+                _entitlementsChanged
+            );
+        }
     });
 
     // private API to be used inside phoenix codebase only