test: code inspection integ tests

Author: abose

src/language/CodeInspection.js

@@ -921,6 +921,9 @@ define(function (require, exports, module) {
 
     let lastRunTime;
     $(window.document).on("mousemove", ()=>{
+        if(Phoenix.isTestWindow){
+            return;
+        }
         const editor = EditorManager.getCurrentFullEditor();
         if(!editor || editor.document.lastChangeTimestamp === lastDocumentScanTimeStamp) {
             return;
@@ -1011,7 +1014,7 @@ define(function (require, exports, module) {
         const editor = EditorManager.getCurrentFullEditor();
         const maxOffset = editor.document.getText().length;
         if(fixDetails.rangeOffset.start < 0 || fixDetails.rangeOffset.end < 0 ||
-            fixDetails.rangeOffset.start > maxOffset || fixDetails.rangeOffset.end < maxOffset ){
+            fixDetails.rangeOffset.start > maxOffset || fixDetails.rangeOffset.end > maxOffset ){
             Dialogs.showErrorDialog(Strings.CANNOT_FIX_TITLE,
                 StringUtils.format(Strings.CANNOT_FIX_INVALID_MESSAGE, fixDetails.providerName));
         } else if(!editor || !fixDetails || editor.document.lastChangeTimestamp !== lastDocumentScanTimeStamp) {

test/spec/CodeInspection-fix-integ-test.js

@@ -73,7 +73,7 @@ define(function (require, exports, module) {
                     if (line.includes('this line a fixable error')) {
                         const wordPosition = findWordPosition(line, 'fixable');
                         error.fix = {
-                            replaceText: "",
+                            replaceText: "no",
                             rangeOffset: {
                                 start: currentEditor.indexFromPos({line: lineNumber, ch: wordPosition.start}),
                                 end: currentEditor.indexFromPos({line: lineNumber, ch: wordPosition.end})
@@ -180,7 +180,68 @@ define(function (require, exports, module) {
             CodeInspection.scrollToProblem(40);
         });
 
-        // todo fix one, fix all, fix one undo, fix all undo, quick view error click, quick view fix click
+        it("should show quick view over problem", async function () {
+            await _openProjectFile("testFix.vbs");
+
+            expect($("#problems-panel").is(":visible")).toBeTrue();
+
+            const $popup = await SpecRunnerUtils.showQuickViewAtPos(2, 3);
+            expect($popup.is(":visible")).toBeTrue();
+            expect($popup.text().includes("this line an error")).toBeTrue();
+            SpecRunnerUtils.dismissQuickView($popup);
+        });
+
+        async function _validateScroll(lineNumber) {
+            CodeInspection.scrollToProblem(lineNumber);
+            const expectedScrollTop = $(".table-container").scrollTop();
+            $(".table-container").scrollTop(0);
+
+            const $popup = await SpecRunnerUtils.showQuickViewAtPos(lineNumber, 3);
+            expect($popup.is(":visible")).toBeTrue();
+            $popup.find(".code-inspection-item div").click();
+            expect($(".table-container").scrollTop()).toBe(expectedScrollTop);
+            SpecRunnerUtils.dismissQuickView($popup);
+        }
+
+        it("should clicking on quick view scroll to the editor", async function () {
+            await _openProjectFile("testFix.vbs");
+
+            expect($("#problems-panel").is(":visible")).toBeTrue();
+            await  _validateScroll(64);
+
+            await _openProjectFile("testNoFix.vbs");
+
+            expect($("#problems-panel").is(":visible")).toBeTrue();
+            await  _validateScroll(57);
+        });
+
+        async function _triggerLint(fileName) {
+            await _openProjectFile("no-errors.js");
+            await _openProjectFile(fileName);
+        }
+
+        it("should fix by clicking fix button in quick view", async function () {
+            await _openProjectFile("testFix.vbs");
+
+            expect($("#problems-panel").is(":visible")).toBeTrue();
+            const $popup = await SpecRunnerUtils.showQuickViewAtPos(64, 3);
+            expect($popup.is(":visible")).toBeTrue();
+            expect($("#problems-panel .ph-fix-problem").length).toBe(5); // 5 fix buttons should be there
+            $popup.find(".code-inspection-item button").click();
+            expect($("#problems-panel .ph-fix-problem").length).toBe(4); // 4 fix buttons as one is fixed
+            SpecRunnerUtils.dismissQuickView($popup);
+
+            const editor = EditorManager.getActiveEditor();
+            expect(editor.getSelectedText()).toBe("no");
+
+            // undo should work
+            await awaitsForDone(CommandManager.execute(Commands.EDIT_UNDO), "undo");
+            expect(editor.getSelectedText()).toBe("fixable");
+            await _triggerLint("testFix.vbs");
+            expect($("#problems-panel .ph-fix-problem").length).toBe(5); // 5 fix buttons should be there
+        });
+
+        // todo fix all, fix all undo,
         // todo invalid fixes test, doc changed after fix dialog
 
     });

test/spec/SpecRunnerUtils.js

@@ -34,6 +34,7 @@ define(function (require, exports, module) {
         MainViewManager     = require("view/MainViewManager"),
         FileSystemError     = require("filesystem/FileSystemError"),
         FileSystem          = require("filesystem/FileSystem"),
+        KeyEvent            = require("utils/KeyEvent"),
         WorkspaceManager    = require("view/WorkspaceManager"),
         UrlParams           = require("utils/UrlParams").UrlParams,
         StringUtils         = require("utils/StringUtils"),
@@ -1186,6 +1187,32 @@ define(function (require, exports, module) {
         return _testWindow.executeCommand(Commands.TOGGLE_QUICK_EDIT);
     }
 
+    /**
+     * shows the quick view at given position and returns $popover if present. use dismissQuickView($popover) to dismiss
+     * @param line
+     * @param ch
+     * @returns {Promise<*>}
+     */
+    async function showQuickViewAtPos(line, ch) {
+        const editor  = _testWindow.brackets.test.EditorManager.getCurrentFullEditor();
+        editor.setCursorPos(line, ch, true);
+        const QuickViewManager= _testWindow.brackets.test.QuickViewManager;
+        let cm = editor._codeMirror,
+            pos = { line, ch },
+            token;
+
+        editor.setCursorPos(pos);
+        token = cm.getTokenAt(pos, true);
+
+        const popoverInfo = await QuickViewManager._queryPreviewProviders(editor, pos, token);
+        QuickViewManager._forceShow(popoverInfo);
+        return _testWindow.$("#quick-view-container"); // returns $popover
+    }
+
+    function dismissQuickView($popover) {
+        simulateKeyEvent(KeyEvent.DOM_VK_ESCAPE, "keydown", $popover[0]);
+    }
+
     /**
      * Simulate a key event.
      * @param {Number} key Key code
@@ -1481,5 +1508,7 @@ define(function (require, exports, module) {
     exports.setUnitTestReporter             = setUnitTestReporter;
     exports.resizeEditor                    = resizeEditor;
     exports.editorHasCursorPosition            = editorHasCursorPosition;
+    exports.showQuickViewAtPos              = showQuickViewAtPos;
+    exports.dismissQuickView              = dismissQuickView;
     exports.jsPromise                       = jsPromise;
 });