fix: prod build fails

Author: abose

gulpfile.js/index.js

@@ -610,6 +610,9 @@ function containsRegExpExcludingEmpty(str) {
 const minifyablePaths = [
     'src/extensionsIntegrated/phoenix-pro/browser-context'
 ];
+const noMinifyFiles = [
+    'src/extensionsIntegrated/phoenix-pro/browser-context/control-box.js'
+];
 
 function _minifyBrowserContextFile(fileContent) {
     const minified = terser.minify(fileContent, {
@@ -636,6 +639,9 @@ function _minifyBrowserContextFile(fileContent) {
 
 function _isMinifyablePath(filePath) {
     const normalizedFilePath = path.normalize(filePath);
+    if (noMinifyFiles.some(f => normalizedFilePath.endsWith(path.normalize(f)))) {
+        return false;
+    }
     return minifyablePaths.some(minifyPath =>
         normalizedFilePath.startsWith(path.normalize(minifyPath))
     );
@@ -690,7 +696,9 @@ function inlineTextRequire(file, content, srcDir, isDevBuild = true) {
                     throw `Error inlining ${requireStatement} in ${file}: Regex: ${detectedRegEx}`+
                     "\nRegular expression of the form /*/ is not allowed for minification please use RegEx constructor";
                 }
-                content = content.replaceAll(requireStatement, `${JSON.stringify(textContent)}`);
+                // Escape $ in replacement to prevent special replacement patterns ($&, $1, etc.)
+                const safeReplacement = JSON.stringify(textContent).replaceAll("$", "$$$$");
+                content = content.replaceAll(requireStatement, safeReplacement);
             }
         }
 

src/command/DefaultMenus.js

@@ -231,7 +231,9 @@ define(function (require, exports, module) {
         menu.addMenuItem(Commands.TOGGLE_RULERS);
         menu.addMenuDivider();
         menu.addMenuItem(Commands.VIEW_TOGGLE_PROBLEMS);
-        menu.addMenuItem(Commands.VIEW_TERMINAL);
+        if (Phoenix.isNativeApp) {
+            menu.addMenuItem(Commands.VIEW_TERMINAL);
+        }
         menu.addMenuItem(Commands.VIEW_TOGGLE_INSPECTION);
 
         /*

tracking-repos.json

@@ -1,5 +1,5 @@
 {
   "phoenixPro": {
-    "commitID": "dc54c66e3a6de664210c743bdda4f0f796cf3c0b"
+    "commitID": "e576b046d4ab2941be70582b5acc641996f1e42d"
   }
 }