feat: verified extensions in extension store

Author: abose

src/extensibility/ExtensionManager.js

@@ -112,7 +112,7 @@ define(function (require, exports, module) {
         _idsToDisable = {};
 
     PreferencesManager.stateManager.definePreference(FOLDER_AUTOINSTALL, "object", undefined);
-    PreferencesManager.definePreference("extensions.sort", "string", "downloadCount", {
+    PreferencesManager.definePreference("extensions.sort", "string", "totalDownloads", {
         description: Strings.SORT_EXTENSION_METHOD
     });
 

src/extensibility/ExtensionManagerView.js

@@ -290,11 +290,20 @@ define(function (require, exports, module) {
         context.disabled = (entry.installInfo && entry.installInfo.status === ExtensionManager.DISABLED);
         context.hasVersionInfo = !!info.versions;
 
+        let isVerified = false;
+        if(context.ownershipVerifiedByGitHub){
+            context.verified = StringUtils.format(Strings.EXTENSION_VERIFIED_PUBLISHER,
+                context.ownershipVerifiedByGitHub[0].replace("https://", ""));
+            context.verifiedURL = context.ownershipVerifiedByGitHub[0];
+            isVerified = true;
+        }
+
         if (entry.registryInfo) {
             var latestVerCompatInfo = ExtensionManager.getCompatibilityInfo(entry.registryInfo, brackets.metadata.apiVersion);
             context.isCompatible = latestVerCompatInfo.isCompatible;
             context.requiresNewer = latestVerCompatInfo.requiresNewer;
             context.isCompatibleLatest = latestVerCompatInfo.isLatestVersion;
+            entry.registryInfo.isVerified = isVerified ? 1 : 0;
             if (!context.isCompatibleLatest) {
                 var installWarningBase = context.requiresNewer ? Strings.EXTENSION_LATEST_INCOMPATIBLE_NEWER : Strings.EXTENSION_LATEST_INCOMPATIBLE_OLDER;
                 context.installWarning = StringUtils.format(installWarningBase, entry.registryInfo.versions[entry.registryInfo.versions.length - 1].version, latestVerCompatInfo.compatibleVersion);

src/extensibility/registry_utils.js

@@ -136,7 +136,7 @@ define(function (require, exports, module) {
         sortedEntries.sort(function (entry1, entry2) {
             if (sortBy !== "publishedDate") {
                 if (entry1.registryInfo && entry2.registryInfo) {
-                    return entry2.registryInfo.totalDownloads - entry1.registryInfo.totalDownloads;
+                    return entry2.registryInfo[sortBy] - entry1.registryInfo[sortBy];
                 }
                 return Number.NEGATIVE_INFINITY;
 

src/extensions/default/DefaultExtensions.json

@@ -42,7 +42,8 @@
    "description": "list extension ids here that you want to show this warning in extension store: 'You may not need this extension. Phoenix comes built in with this feature.'",
    "note": "This is only to for legacy extensions that havent been updated for a long time, remove flag unconditionally if instructed by the extension author, but inform of the issues in extension.",
    "extensionIDs": [
-     "brackets-beautify", "beautify.io", "hirse.beautify", "jsbeautifier", "sizuhiko.brackets.prettier", "pretty_json"
+     "brackets-beautify", "beautify.io", "hirse.beautify", "jsbeautifier", "sizuhiko.brackets.prettier", "pretty_json",
+     "bib-locked-live-preview"
    ]
  }
 }

src/htmlContent/extension-manager-dialog.html

@@ -27,7 +27,8 @@
                <div id="sort-attributes-icon"></div>
                <select class="sort-extensions">
                    <option value="publishedDate">{{Strings.EXTENSIONS_LAST_UPDATED}}</option>
-                   <option value="downloadCount">{{Strings.EXTENSIONS_DOWNLOADS}}</option>
+                   <option value="totalDownloads">{{Strings.EXTENSIONS_DOWNLOADS}}</option>
+                   <option value="isVerified">{{Strings.EXTENSION_VERIFIED_SORT}}</option>
                </select>
             </div>
             <div class="search-container">

src/htmlContent/extension-manager-view-item.html

@@ -5,7 +5,9 @@
             <span class="muted ext-author">
                 {{{authorInfo}}}
                 {{#verified}}
-                <img class="extn-verified" title="This publisher has verified ownership of {{verified}}" src="styles/images/verified.svg" style="width:1.5em;">
+                <a href="{{verifiedURL}}">
+                    <img class="extn-verified" title="{{verified}}" src="styles/images/verified.svg" style="width:1.5em;">
+                </a>
                 {{/verified}}
             </span>
         {{/authorInfo}}

src/nls/root/strings.js

@@ -589,6 +589,8 @@ define({
     "MALFORMED_URL": "The URL is invalid. Please check that you entered it correctly.",
     "UNSUPPORTED_PROTOCOL": "The URL must be an http or https URL.",
     "UNKNOWN_ERROR": "Unknown internal error.",
+    "EXTENSION_VERIFIED_PUBLISHER": "This publisher has verified ownership of {0}",
+    "EXTENSION_VERIFIED_SORT": "Verified",
     // For NOT_FOUND_ERR, see generic strings above
     "EXTENSION_MANAGER_TITLE": "Extension Manager",
     "EXTENSION_MANAGER_ERROR_LOAD": "Unable to access the extension registry. Please try again later.",