feat: to toggle problems panel- menu > problems

Author: abose

src/base-config/keyboard.json

@@ -290,6 +290,9 @@
     "navigate.gotoDefinition":  [
         "Ctrl-T"
     ],
+    "view.toggleProblems":  [
+        "Ctrl-Shift-M"
+    ],
     "navigate.jumptoDefinition":  [
         "Ctrl-J"
     ],

src/command/Commands.js

@@ -124,6 +124,7 @@ define(function (require, exports, module) {
     exports.VIEW_SCROLL_LINE_UP         = "view.scrollLineUp";          // ViewCommandHandlers.js       _handleScrollLineUp()
     exports.VIEW_SCROLL_LINE_DOWN       = "view.scrollLineDown";        // ViewCommandHandlers.js       _handleScrollLineDown()
     exports.VIEW_TOGGLE_INSPECTION      = "view.toggleCodeInspection";  // CodeInspection.js            toggleEnabled()
+    exports.VIEW_TOGGLE_PROBLEMS        = "view.toggleProblems";        // CodeInspection.js            toggleProblems()
     exports.TOGGLE_LINE_NUMBERS         = "view.toggleLineNumbers";     // EditorOptionHandlers.js      _getToggler()
     exports.TOGGLE_ACTIVE_LINE          = "view.toggleActiveLine";      // EditorOptionHandlers.js      _getToggler()
     exports.TOGGLE_WORD_WRAP            = "view.toggleWordWrap";        // EditorOptionHandlers.js      _getToggler()

src/command/DefaultMenus.js

@@ -221,6 +221,7 @@ define(function (require, exports, module) {
         menu.addMenuDivider();
         menu.addMenuItem(Commands.FILE_LIVE_HIGHLIGHT);
         menu.addMenuDivider();
+        menu.addMenuItem(Commands.VIEW_TOGGLE_PROBLEMS);
         menu.addMenuItem(Commands.VIEW_TOGGLE_INSPECTION);
 
         /*

src/extensionsIntegrated/DisplayShortcuts/vscode.json

@@ -1,2 +1,17 @@
 {
+  "Ctrl-3": null,
+  "Ctrl-Alt-Shift-W": null,
+  "Ctrl-Shift-W": null,
+  "Ctrl-Alt-S": null,
+  "Ctrl-Shift-Up": "edit.addCursorToPrevLine",
+  "Ctrl-Shift-Down": "edit.addCursorToNextLine",
+  "Ctrl-Shift-L": "cmd.findAllAndSelect",
+  "Ctrl-Shift-A": "edit.blockComment",
+  "Alt-Up": "edit.lineUp",
+  "Alt-Down": "edit.lineDown",
+  "Ctrl-D": "cmd.addNextMatch",
+  "Ctrl-B": "view.toggleSidebar",
+  "Ctrl-J": "view.togglePanels",
+  "Ctrl-Shift-X": "file.extensionManager",
+  "Alt-Z": "view.toggleWordWrap"
 }

src/language/CodeInspection.js

@@ -583,6 +583,7 @@ define(function (require, exports, module) {
                     }
                     toggleCollapsed(false);
                     scrollToProblem(pos.line);
+                    // todo strobe effect
                 });
                 $problemView.find(".copy-qv-error-text-btn").click(function (evt) {
                     evt.preventDefault();
@@ -1013,6 +1014,10 @@ define(function (require, exports, module) {
         run();
     }
 
+    function toggleProblems() {
+        toggleCollapsed();
+    }
+
     let lastRunTime;
     $(window.document).on("mousemove", ()=>{
         if(Phoenix.isTestWindow){
@@ -1073,6 +1078,7 @@ define(function (require, exports, module) {
 
     // Register command handlers
     CommandManager.register(Strings.CMD_VIEW_TOGGLE_INSPECTION, Commands.VIEW_TOGGLE_INSPECTION,        toggleEnabled);
+    CommandManager.register(Strings.CMD_VIEW_TOGGLE_PROBLEMS, Commands.VIEW_TOGGLE_PROBLEMS,        toggleProblems);
     CommandManager.register(Strings.CMD_GOTO_FIRST_PROBLEM,     Commands.NAVIGATE_GOTO_FIRST_PROBLEM,   handleGotoFirstProblem);
 
     // Register preferences

src/nls/root/strings.js

@@ -550,6 +550,7 @@ define({
     "CMD_TOGGLE_WORD_WRAP": "Word Wrap",
     "CMD_LIVE_HIGHLIGHT": "Live Preview Highlight",
     "CMD_VIEW_TOGGLE_INSPECTION": "Lint Files on Save",
+    "CMD_VIEW_TOGGLE_PROBLEMS": "Problems",
     "CMD_WORKINGSET_SORT_BY_ADDED": "Sort by Added",
     "CMD_WORKINGSET_SORT_BY_NAME": "Sort by Name",
     "CMD_WORKINGSET_SORT_BY_TYPE": "Sort by Type",