fix: checkmark/active indicators not getting removed when tab is closed

Author: devvaannsh

src/extensions/default/Git/src/Panel.js

@@ -1501,6 +1501,17 @@ define(function (require, exports) {
         handleGitCommit(lastCommitMessage[ProjectManager.getProjectRoot().fullPath], false, COMMIT_MODE.DEFAULT);
     });
 
+    // When the panel tab is closed externally (e.g. via the × button),
+    // update the toolbar icon and menu checked state to stay in sync.
+    WorkspaceManager.on(WorkspaceManager.EVENT_WORKSPACE_PANEL_HIDDEN, function (event, panelID) {
+        if (panelID === "main-git.panel" && gitPanel) {
+            Main.$icon.toggleClass("on", false);
+            Main.$icon.toggleClass("selected-button", false);
+            CommandManager.get(Constants.CMD_GIT_TOGGLE_PANEL).setChecked(false);
+            Preferences.set("panelEnabled", false);
+        }
+    });
+
     exports.init = init;
     exports.refresh = refresh;
     exports.toggle = toggle;

src/extensionsIntegrated/CustomSnippets/main.js

@@ -255,6 +255,14 @@ define(function (require, exports, module) {
         });
     }
 
+    // When the panel tab is closed externally (e.g. via the × button),
+    // update the menu checked state to stay in sync.
+    WorkspaceManager.on(WorkspaceManager.EVENT_WORKSPACE_PANEL_HIDDEN, function (event, panelID) {
+        if (panelID === PANEL_ID && customSnippetsPanel) {
+            CommandManager.get(MY_COMMAND_ID).setChecked(false);
+        }
+    });
+
     AppInit.appReady(function () {
         CommandManager.register(MENU_ITEM_NAME, MY_COMMAND_ID, showCustomSnippetsPanel);
         // Render template with localized strings

src/extensionsIntegrated/DisplayShortcuts/main.js

@@ -538,5 +538,15 @@ define(function (require, exports, module) {
         KeyBindingManager.on(KeyBindingManager.EVENT_KEY_BINDING_REMOVED, _updateKeyBindings);
         KeyBindingManager.on(KeyBindingManager.EVENT_NEW_PRESET, _updatePresets);
         KeyBindingManager.on(KeyBindingManager.EVENT_PRESET_CHANGED, _updatePresets);
+
+        // When the panel tab is closed externally (e.g. via the × button),
+        // update the menu checked state and clean up resources.
+        WorkspaceManager.on(WorkspaceManager.EVENT_WORKSPACE_PANEL_HIDDEN, function (event, panelID) {
+            if (panelID === TOGGLE_SHORTCUTS_ID && panel) {
+                destroyKeyList();
+                _clearSortingEventHandlers();
+                CommandManager.get(TOGGLE_SHORTCUTS_ID).setChecked(false);
+            }
+        });
     });
 });

src/language/CodeInspection.js

@@ -1365,6 +1365,14 @@ define(function (require, exports, module) {
             }
         });
 
+        // When the panel tab is closed externally (e.g. via the × button),
+        // update the collapsed state so the panel doesn't auto-reopen.
+        WorkspaceManager.on(WorkspaceManager.EVENT_WORKSPACE_PANEL_HIDDEN, function (event, panelID) {
+            if (panelID === "errors") {
+                _collapsed = true;
+            }
+        });
+
         // Set initial UI state
         toggleEnabled(prefs.get(PREF_ENABLED), true);
         toggleCollapsed(prefs.get(PREF_COLLAPSED), true);