feat: move to trash instead of delete when deleting files from project tree

Author: abose

src/document/DocumentCommandHandlers.js

@@ -1846,14 +1846,35 @@ define(function (require, exports, module) {
         }
     }
 
+    function _getDeleteMessageTemplate(isFile, canMoveToTrash) {
+        if(!Phoenix.isNativeApp || !canMoveToTrash){
+            return isFile ? Strings.CONFIRM_FILE_DELETE : Strings.CONFIRM_FOLDER_DELETE;
+        }
+        if(Phoenix.platform === "win") {
+            return isFile ? Strings.CONFIRM_FILE_DELETE_RECYCLE_BIN : Strings.CONFIRM_FOLDER_DELETE_RECYCLE_BIN;
+        }
+        return isFile ? Strings.CONFIRM_FILE_DELETE_TRASH : Strings.CONFIRM_FOLDER_DELETE_TRASH;
+    }
+
+    function _getDeleteButtonString(canMoveToTrash) {
+        if(!Phoenix.isNativeApp || !canMoveToTrash){
+            return Strings.DELETE;
+        }
+        if(Phoenix.platform === "win") {
+            return Strings.MOVE_TO_RECYCLE_BIN;
+        }
+        return Strings.MOVE_TO_TRASH;
+    }
+
     /** Delete file command handler  **/
     function handleFileDelete() {
-        var entry = ProjectManager.getSelectedItem();
+        const entry = ProjectManager.getSelectedItem();
+        const canMoveToTrash = Phoenix.app.canMoveToTrash(entry.fullPath);
         Dialogs.showModalDialog(
             DefaultDialogs.DIALOG_ID_EXT_DELETED,
             Strings.CONFIRM_DELETE_TITLE,
             StringUtils.format(
-                entry.isFile ? Strings.CONFIRM_FILE_DELETE : Strings.CONFIRM_FOLDER_DELETE,
+                _getDeleteMessageTemplate(entry.isFile, canMoveToTrash),
                 StringUtils.breakableUrl(ProjectManager.getProjectRelativePath(entry.fullPath))
             ),
             [
@@ -1865,12 +1886,15 @@ define(function (require, exports, module) {
                 {
                     className: Dialogs.DIALOG_BTN_CLASS_PRIMARY,
                     id: Dialogs.DIALOG_BTN_OK,
-                    text: Strings.DELETE
+                    text: _getDeleteButtonString(canMoveToTrash)
                 }
             ]
         )
             .done(function (id) {
                 if (id === Dialogs.DIALOG_BTN_OK) {
+                    if(Phoenix.isNativeApp && canMoveToTrash) {
+                        Phoenix.app.moveToTrash(entry.fullPath);
+                    }
                     ProjectManager.deleteItem(entry);
                 }
             });

src/nls/root/strings.js

@@ -185,6 +185,12 @@ define({
     "CONFIRM_DELETE_TITLE": "Confirm Delete",
     "CONFIRM_FILE_DELETE": "Are you sure you want to delete the file <span class='dialog-filename'>{0}</span>?",
     "CONFIRM_FOLDER_DELETE": "Are you sure you want to delete the folder <span class='dialog-filename'>{0}</span>?",
+    "CONFIRM_FILE_DELETE_TRASH": "Are you sure you want to delete the file <span class='dialog-filename'>{0}</span>?<br>You can restore this file from the trash.",
+    "CONFIRM_FOLDER_DELETE_TRASH": "Are you sure you want to delete the folder <span class='dialog-filename'>{0}</span>?<br>You can restore this folder from the trash.",
+    "CONFIRM_FILE_DELETE_RECYCLE_BIN": "Are you sure you want to delete the file <span class='dialog-filename'>{0}</span>?<br>You can restore this file from the Recycle Bin.",
+    "CONFIRM_FOLDER_DELETE_RECYCLE_BIN": "Are you sure you want to delete the folder <span class='dialog-filename'>{0}</span>?<br>You can restore this folder from the Recycle Bin.",
+    "MOVE_TO_TRASH": "Move to Trash",
+    "MOVE_TO_RECYCLE_BIN": "Move to Recycle Bin",
     "FILE_DELETED_TITLE": "File Deleted",
     "EXT_MODIFIED_WARNING": "<span class='dialog-filename'>{0}</span> has been modified on disk outside of {APP_NAME}.<br /><br />Do you want to save the file and overwrite those changes?",
     "EXT_MODIFIED_MESSAGE": "<span class='dialog-filename'>{0}</span> has been modified on disk outside of {APP_NAME}, but also has unsaved changes in {APP_NAME}.<br /><br />Which version do you want to keep?",

src/phoenix/shell.js

@@ -347,6 +347,26 @@ Phoenix.app = {
         }
         return fullOrRelativeVFSPath;
     },
+    canMoveToTrash: function(fullVFSPath) {
+        if(!Phoenix.isNativeApp || !fullVFSPath || !fullVFSPath.startsWith(Phoenix.VFS.getTauriDir())){
+            // only tauri paths can be moved to trash
+            return false;
+        }
+        return true;
+    },
+    moveToTrash: async function(fullVFSPath) {
+        if(!Phoenix.isNativeApp){
+            throw new Error("moveToTrash is not supported in browsers");
+        }
+        if(!fullVFSPath){
+            throw new Error("Please specify a path to move to trash");
+        }
+        if(!fullVFSPath.startsWith(Phoenix.VFS.getTauriDir())) {
+            throw new Error("moveToTrash only works with tauri paths, but got: "+ fullVFSPath);
+        }
+        const platformPath = Phoenix.fs.getTauriPlatformPath(fullVFSPath);
+        return window.__TAURI__.invoke('_move_to_trash', { deletePath: platformPath });
+    },
     setWindowTitle: async function (title) {
         window.document.title = title;
         if(Phoenix.isNativeApp) {