fix: css reverse highlight shouldnt happen when forward highlight is going on

Author: abose

src/LiveDevelopment/MultiBrowserImpl/documents/LiveDocument.js

@@ -171,6 +171,17 @@ define(function (require, exports, module) {
         }
     };
 
+    let _disableHighlightOnCursor = false;
+
+    /**
+     * If tur, it will disable highlights in live preview on cursor movement in editor
+     * @param {boolean} shouldDisable
+     */
+    LiveDocument.prototype.disableHighlightOnCursorActivity = function (shouldDisable) {
+        // intentionally global. see usage for details
+        _disableHighlightOnCursor = shouldDisable;
+    };
+
     /**
      * @private
      * Handles a cursor change in our attached editor. Updates the highlight in the browser.
@@ -181,7 +192,10 @@ define(function (require, exports, module) {
         if (!this.editor) {
             return;
         }
-        this.updateHighlight();
+        if(!_disableHighlightOnCursor){
+            console.log("cursor activity highlight");
+            this.updateHighlight();
+        }
     };
 
     /**

src/LiveDevelopment/MultiBrowserImpl/protocol/LiveDevProtocol.js

@@ -342,8 +342,21 @@ define(function (require, exports, module) {
                 }
             }
         } else if (msg.clicked && msg.tagId) {
-            _tagSelectedInLivePreview(msg.tagId, msg.nodeName, msg.contentEditable, msg.allSelectors);
-            exports.trigger(EVENT_LIVE_PREVIEW_CLICKED, msg);
+            // While previewing an html file, and if css related file is active in the editor, then clicking on the
+            // live preview, here we set the cursor position in the css file. but this will also trigger a css
+            // highlight as the cursor changes which jumps the live preview selection.
+            // We should not do reverse highlight when lp highlight is going on here.
+            const livePreviewMode = PreferencesManager.get(CONSTANTS.PREFERENCE_LIVE_PREVIEW_MODE);
+            const editMode = (livePreviewMode === CONSTANTS.LIVE_PREVIEW_MODE);
+            const liveDoc = LiveDevMultiBrowser.getCurrentLiveDoc();
+            editMode && liveDoc && liveDoc.disableHighlightOnCursorActivity(true);
+            try {
+                _tagSelectedInLivePreview(msg.tagId, msg.nodeName, msg.contentEditable, msg.allSelectors);
+                exports.trigger(EVENT_LIVE_PREVIEW_CLICKED, msg);
+            } catch (e) {
+                console.error("error in tag selection", e);
+            }
+            editMode && liveDoc && liveDoc.disableHighlightOnCursorActivity(false);
         } else {
             // enrich received message with clientId
             msg.clientId = clientId;