feat: show tooltip when close button is hovered along with keyboard shortcut

Author: devvaannsh

src/extensionsIntegrated/TabBar/main.js

@@ -28,6 +28,7 @@ define(function (require, exports, module) {
     const FileUtils = require("file/FileUtils");
     const CommandManager = require("command/CommandManager");
     const Commands = require("command/Commands");
+    const KeyBindingManager = require("command/KeyBindingManager");
     const DocumentManager = require("document/DocumentManager");
     const WorkspaceManager = require("view/WorkspaceManager");
     const Menus = require("command/Menus");
@@ -515,6 +516,23 @@ define(function (require, exports, module) {
             }
         });
 
+        // add listener for tab close button to show the tooltip along with the keybinding
+        $(document).on("mouseenter", ".phoenix-tab-bar .tab-close", function () {
+
+            // there can be more than 1 keybinding for 'Close' as one is default and other one is user-set
+            // we need to get the user created keybinding...
+            const closeBindings = KeyBindingManager.getKeyBindings(Commands.FILE_CLOSE);
+            const closeShortcut = closeBindings.length > 0
+                ? KeyBindingManager.formatKeyDescriptor(closeBindings[closeBindings.length - 1].displayKey)
+                : "";
+
+            const closeTabTooltip = closeShortcut
+                ? `${Strings.CLOSE_TAB_TOOLTIP} (${closeShortcut})`
+                : Strings.CLOSE_TAB_TOOLTIP;
+
+            $(this).attr("title", closeTabTooltip);
+        });
+
         // open tab on mousedown event
         $(document).on("mousedown", ".phoenix-tab-bar .tab", function (event) {
             if ($(event.target).hasClass("fa-times") || $(event.target).closest(".tab-close").length) {

src/nls/root/strings.js

@@ -501,6 +501,7 @@ define({
     "CLOSE_TABS_TO_THE_LEFT": "Close Tabs to the Left",
     "CLOSE_ALL_TABS": "Close All Tabs",
     "CLOSE_SAVED_TABS": "Close Saved Tabs",
+    "CLOSE_TAB_TOOLTIP": "Close Tab",
 
     // CodeInspection: errors/warnings
     "ERRORS_NO_FILE": "No File Open",