test(mdviewer): add tests for link click opening in default browser

Verify that clicking a markdown link in reader mode and clicking the
URL in the link popover in edit mode both call
NativeApp.openURLInDefaultBrowser with the expected URL. Restore
original function in afterAll to guard against individual test failures.

Author: abose

src-mdviewer/to-create-tests.md

@@ -35,7 +35,7 @@
 - [ ] Format bar appears on text selection (visual — needs real mouse interaction)
 - [x] Link popover edit URL via popover syncs to CM
 - [x] Link popover remove link via popover syncs to CM
-- [ ] Link popover URL opens in default browser (not Electron window)
+- [x] Link popover URL opens in default browser (not Electron window)
 - [ ] Escape in lang picker only dismisses picker, refocuses editor
 
 ## Empty Line Placeholder

test/spec/md-editor-integ-test.js

@@ -28,7 +28,7 @@ define(function (require, exports, module) {
     const mdTestFolder = SpecRunnerUtils.getTestPath("/spec/LiveDevelopment-Markdown-test-files");
 
     let testWindow, brackets, CommandManager, Commands, EditorManager, WorkspaceManager,
-        LiveDevMultiBrowser;
+        LiveDevMultiBrowser, NativeApp;
 
     function _getMdPreviewIFrame() {
         return testWindow.document.getElementById("panel-md-preview-frame");
@@ -244,6 +244,7 @@ define(function (require, exports, module) {
                 EditorManager = brackets.test.EditorManager;
                 WorkspaceManager = brackets.test.WorkspaceManager;
                 LiveDevMultiBrowser = brackets.test.LiveDevMultiBrowser;
+                NativeApp = brackets.test.NativeApp;
 
                 await SpecRunnerUtils.loadProjectInTestWindow(testFolder);
                 await SpecRunnerUtils.deletePathAsync(testFolder + "/.phcode.json", true);
@@ -1238,6 +1239,16 @@ define(function (require, exports, module) {
 
         describe("Links & Format Bar", function () {
 
+            let _originalOpenURL;
+
+            beforeAll(function () {
+                _originalOpenURL = NativeApp.openURLInDefaultBrowser;
+            });
+
+            afterAll(function () {
+                NativeApp.openURLInDefaultBrowser = _originalOpenURL;
+            });
+
             async function _openMdFile(fileName) {
                 await awaitsForDone(SpecRunnerUtils.openProjectFiles([fileName]),
                     "open " + fileName);
@@ -1440,6 +1451,72 @@ define(function (require, exports, module) {
                 await awaitsForDone(CommandManager.execute(Commands.FILE_CLOSE, { _forceClose: true }),
                     "force close doc3.md");
             }, 15000);
+
+            it("should clicking link in reader mode call openURLInDefaultBrowser", async function () {
+                await _openMdFile("doc2.md");
+                await _enterReaderMode();
+
+                let capturedURL = null;
+                NativeApp.openURLInDefaultBrowser = function (url) {
+                    capturedURL = url;
+                };
+
+                const mdDoc = _getMdIFrameDoc();
+                const link = mdDoc.querySelector('#viewer-content a[href*="test-link-doc2"]');
+                expect(link).not.toBeNull();
+                link.click();
+
+                await awaitsFor(() => capturedURL !== null,
+                    "openURLInDefaultBrowser to be called");
+                expect(capturedURL).toContain("test-link-doc2.example.com");
+
+                await awaitsForDone(CommandManager.execute(Commands.FILE_CLOSE, { _forceClose: true }),
+                    "force close doc2.md");
+            }, 10000);
+
+            it("should clicking link in edit mode popover call openURLInDefaultBrowser", async function () {
+                await _openMdFile("doc2.md");
+                await _enterEditMode();
+                await _focusMdContent();
+
+                let capturedURL = null;
+                NativeApp.openURLInDefaultBrowser = function (url) {
+                    capturedURL = url;
+                };
+
+                const mdDoc = _getMdIFrameDoc();
+                const content = mdDoc.getElementById("viewer-content");
+                const link = content.querySelector("a[href*='test-link-doc2']");
+                expect(link).not.toBeNull();
+
+                // Place cursor in link to trigger popover
+                const range = mdDoc.createRange();
+                range.selectNodeContents(link);
+                range.collapse(true);
+                _getMdIFrameWin().getSelection().removeAllRanges();
+                _getMdIFrameWin().getSelection().addRange(range);
+                content.dispatchEvent(new KeyboardEvent("keyup", {
+                    key: "ArrowRight", code: "ArrowRight", bubbles: true
+                }));
+
+                await awaitsFor(() => {
+                    const popover = mdDoc.getElementById("link-popover");
+                    return popover && popover.classList.contains("visible");
+                }, "link popover to appear");
+
+                // Click the URL link in the popover
+                const popover = mdDoc.getElementById("link-popover");
+                const popoverLink = popover.querySelector(".link-popover-url");
+                expect(popoverLink).not.toBeNull();
+                popoverLink.click();
+
+                await awaitsFor(() => capturedURL !== null,
+                    "openURLInDefaultBrowser to be called from popover");
+                expect(capturedURL).toContain("test-link-doc2.example.com");
+
+                await awaitsForDone(CommandManager.execute(Commands.FILE_CLOSE, { _forceClose: true }),
+                    "force close doc2.md");
+            }, 15000);
         });
 
         describe("Empty Line Placeholder", function () {