feat: remove show spacing handles preference setting

Author: devvaannsh

src/LiveDevelopment/BrowserScripts/RemoteFunctions.js

@@ -1353,7 +1353,7 @@ function RemoteFunctions(config = {}) {
         }
 
         // Preserve the currently selected element across re-registration
-        // so that toggling options (e.g. show measurements, show spacing handles)
+        // so that toggling options (e.g. show measurements)
         // doesn't clear the element highlighting.
         const selectedBeforeReregister = previouslySelectedElement;
         registerHandlers();

src/LiveDevelopment/LivePreviewConstants.js

@@ -41,7 +41,6 @@ define(function main(require, exports, module) {
     exports.HIGHLIGHT_CLICK = "click";
 
     exports.PREFERENCE_SHOW_RULER_LINES = "livePreviewShowMeasurements";
-    exports.PREFERENCE_SHOW_SPACING_HANDLES = "livePreviewShowSpacingHandles";
 
     exports.PREFERENCE_LIVE_PREVIEW_SYNC = "livePreviewSyncSourceAndPreview";
 });

src/LiveDevelopment/main.js

@@ -70,7 +70,6 @@ define(function main(require, exports, module) {
         mode: LIVE_HIGHLIGHT_MODE, // will be updated when we fetch entitlements
         elemHighlights: CONSTANTS.HIGHLIGHT_HOVER, // default value, this will get updated when the extension loads
         showRulerLines: false, // default value, this will get updated when the extension loads
-        showSpacingHandles: true, // default value, this will get updated when the extension loads
         syncSourceAndPreview: true, // default value, this will get updated when the extension loads
         isPaidUser: false, // will be updated when we fetch entitlements
         isLoggedIn: false, // will be updated when we fetch entitlements
@@ -326,13 +325,6 @@ define(function main(require, exports, module) {
         MultiBrowserLiveDev.updateConfig(config);
     }
 
-    function updateSpacingHandlesConfig() {
-        const prefValue = PreferencesManager.get(CONSTANTS.PREFERENCE_SHOW_SPACING_HANDLES);
-        const config = MultiBrowserLiveDev.getConfig();
-        config.showSpacingHandles = prefValue !== false;
-        MultiBrowserLiveDev.updateConfig(config);
-    }
-
     function updateSyncConfig() {
         const prefValue = PreferencesManager.get(CONSTANTS.PREFERENCE_LIVE_PREVIEW_SYNC);
         const config = MultiBrowserLiveDev.getConfig();
@@ -363,7 +355,6 @@ define(function main(require, exports, module) {
     exports.setLivePreviewTransportBridge = setLivePreviewTransportBridge;
     exports.updateElementHighlightConfig = updateElementHighlightConfig;
     exports.updateRulerLinesConfig = updateRulerLinesConfig;
-    exports.updateSpacingHandlesConfig = updateSpacingHandlesConfig;
     exports.updateSyncConfig = updateSyncConfig;
     exports.getConnectionIds = MultiBrowserLiveDev.getConnectionIds;
     exports.getLivePreviewDetails = MultiBrowserLiveDev.getLivePreviewDetails;

src/extensionsIntegrated/Phoenix-live-preview/main.js

@@ -115,11 +115,6 @@ define(function (require, exports, module) {
         description: Strings.LIVE_DEV_SETTINGS_SHOW_RULER_LINES_PREFERENCE
     });
 
-    const PREFERENCE_SHOW_SPACING_HANDLES = CONSTANTS.PREFERENCE_SHOW_SPACING_HANDLES;
-    PreferencesManager.definePreference(PREFERENCE_SHOW_SPACING_HANDLES, "boolean", true, {
-        description: Strings.LIVE_DEV_SETTINGS_SHOW_SPACING_HANDLES_PREFERENCE
-    });
-
     // live preview link editor and preview preference
     const PREFERENCE_LIVE_PREVIEW_SYNC = CONSTANTS.PREFERENCE_LIVE_PREVIEW_SYNC;
     PreferencesManager.definePreference(PREFERENCE_LIVE_PREVIEW_SYNC, "boolean", true, {
@@ -1457,17 +1452,13 @@ define(function (require, exports, module) {
         PreferencesManager.on("change", PREFERENCE_SHOW_RULER_LINES, function() {
             LiveDevelopment.updateRulerLinesConfig();
         });
-        PreferencesManager.on("change", PREFERENCE_SHOW_SPACING_HANDLES, function() {
-            LiveDevelopment.updateSpacingHandlesConfig();
-        });
         PreferencesManager.on("change", PREFERENCE_LIVE_PREVIEW_SYNC, function() {
             LiveDevelopment.updateSyncConfig();
         });
 
-        // Initialize element highlight, ruler lines, spacing handles, and sync config on startup
+        // Initialize element highlight, ruler lines, and sync config on startup
         LiveDevelopment.updateElementHighlightConfig();
         LiveDevelopment.updateRulerLinesConfig();
-        LiveDevelopment.updateSpacingHandlesConfig();
         LiveDevelopment.updateSyncConfig();
 
         LiveDevelopment.openLivePreview();

src/nls/root/strings.js

@@ -537,8 +537,6 @@ define({
     "LIVE_PREVIEW_MODE_EDIT": "Edit Mode",
     "LIVE_PREVIEW_EDIT_HIGHLIGHT_ON": "Inspect Element on Hover",
     "LIVE_PREVIEW_SHOW_RULER_LINES": "Show Measurements",
-    "LIVE_PREVIEW_SHOW_SPACING_HANDLES": "Show Spacing Handles",
-    "LIVE_DEV_SETTINGS_SHOW_SPACING_HANDLES_PREFERENCE": "Show spacing handles when elements are selected in live preview edit mode. Defaults to 'true'",
     "LIVE_PREVIEW_LINK_EDITOR_AND_PREVIEW": "Link Editor and Preview",
     "LIVE_DEV_SETTINGS_LINK_EDITOR_AND_PREVIEW_PREFERENCE": "Link editor cursor with live preview element highlighting. When enabled, moving the cursor in the editor highlights the corresponding element in the live preview, and clicking an element in the live preview jumps the cursor to its source code. Defaults to 'true'",
     "LIVE_PREVIEW_MODE_PREFERENCE": "'{0}' shows only the webpage, '{1}' connects the webpage to your code - click on elements to jump to their code and vice versa, '{2}' provides highlighting along with advanced element manipulation",