feat: enable save as file dialog in desktop builds

Author: abose

src/command/DefaultMenus.js

@@ -122,11 +122,15 @@ define(function (require, exports, module) {
         menu.addMenuDivider();
         menu.addMenuItem(Commands.FILE_SAVE);
         menu.addMenuItem(Commands.FILE_SAVE_ALL);
+        if(Phoenix.isNativeApp){
+            menu.addMenuItem(Commands.FILE_SAVE_AS);
+            // save as is not yet supported in browser as in our vfs implements only open folder, so vfs needs to
+            // be changed. Also, we dont know how the ux for save as will be in virtual paths.
+        }
         menu.addMenuItem(Commands.FILE_DUPLICATE_FILE);
         menu.addMenuItem(Commands.FILE_DOWNLOAD_PROJECT, undefined, undefined, undefined, {
             hideWhenCommandDisabled: true
         });
-        // menu.addMenuItem(Commands.FILE_SAVE_AS); not yet available in phoenix
         // menu.addMenuItem(Commands.FILE_PROJECT_SETTINGS); not yet available in phoenix
         menu.addMenuDivider();
         menu.addMenuItem(Commands.FILE_EXTENSION_MANAGER);

src/document/DocumentCommandHandlers.js

@@ -1070,8 +1070,12 @@ define(function (require, exports, module) {
 
                 if (FileViewController.getFileSelectionFocus() === FileViewController.PROJECT_MANAGER) {
                     // If selection is in the tree, leave workingset unchanged - even if orig file is in the list
-                    fileOpenPromise = FileViewController
-                        .openAndSelectDocument(path, FileViewController.PROJECT_MANAGER);
+                    setTimeout(()=>{
+                        fileOpenPromise = FileViewController
+                            .openAndSelectDocument(path, FileViewController.PROJECT_MANAGER);
+                    }, 100); // this is in a timeout as the file tree may not have updated yet after save as
+                    // file created, and we wait for the file watcher events to get triggered so that the file
+                    // selection is updated.
                 } else {
                     // If selection is in workingset, replace orig item in place with the new file
                     var info = MainViewManager.findInAllWorkingSets(doc.file.fullPath).shift();

src/filesystem/impls/appshell/AppshellFileSystem.js

@@ -19,7 +19,7 @@
  *
  */
 
-/*global appshell, Phoenix*/
+/*global appshell, path*/
 /*eslint-env es6*/
 // jshint ignore: start
 
@@ -330,7 +330,23 @@ define(function (require, exports, module) {
      * @param {function(?string, string=)} callback
      */
     function showSaveDialog(title, initialPath, proposedNewFilename, callback) {
-        appshell.fs.showSaveDialog(title, initialPath, proposedNewFilename, _wrap(callback));
+        if(Phoenix.isNativeApp){
+            const wrappedCallback = _wrap(callback);
+            appshell.fs.showSaveDialog({
+                title,
+                defaultPath: Phoenix.fs.getTauriPlatformPath(path.join(initialPath, proposedNewFilename || ""))
+                // no filter option for now filters: undefined
+            }).then(fileSavePath => {
+                if(!fileSavePath) {
+                    wrappedCallback(FileSystemError.NOT_READABLE);
+                    return;
+                }
+                wrappedCallback(null, fileSavePath);
+            }).catch(wrappedCallback);
+            return;
+        }
+        console.error("showSaveDialog is not yet supported in web browsers...");
+        callback(FileSystemError.NOT_SUPPORTED);
     }
 
     function _createStatObject(stats, realPath) {