Skip to content

Commit 926bd3d

Browse files
committed
fix: firefox ut failures in worker comm
1 parent baf425b commit 926bd3d

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

src/worker/WorkerComm.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,9 @@
293293
}
294294
}
295295
} catch (err) {
296-
response.err = err.stack || err.toString();
296+
response.err = err.message || err.stack ?
297+
{message: err.message, stack: err.stack}
298+
: err.toString();
297299
}
298300
postTarget.postMessage(JSON.stringify(response));
299301
}

test/spec/WorkerComm-test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ define(function (require, exports, module) {
4848
});
4949

5050
afterAll(function () {
51-
//_myWorker.terminate();
51+
_myWorker.terminate();
5252
});
5353

5454
describe("execPeer API tests", function () {
@@ -69,7 +69,7 @@ define(function (require, exports, module) {
6969
} catch (e) {
7070
thrown = e;
7171
}
72-
expect(thrown.startsWith("Error: oops")).toBeTrue();
72+
expect(thrown.message).toBe("oops");
7373
});
7474

7575
it("Should throw if promise rejected in worker", async function () {
@@ -95,7 +95,7 @@ define(function (require, exports, module) {
9595
throw new Error("throw_me");
9696
});
9797
let result = await exports.execPeer("execAndRejectInMainThread");
98-
expect(result.startsWith("Error: throw_me")).toBeTrue();
98+
expect(result.message).toBe("throw_me");
9999
});
100100
});
101101

0 commit comments

Comments
 (0)