chore: add error metrics for unhandles exeptions and rejections

Author: abose

src/main.js

@@ -129,22 +129,39 @@ window.scriptObserver = new MutationObserver(callback);
 // Start observing the target node for configured mutations
 window.scriptObserver.observe(mainScripts, config);
 
+let Metrics = null;
+
 window.onerror = function (msg, url, line, ...err) {
     console.error("Caught Critical error from: " + url + ":" + line + " message: " + msg, ...err);
+    if(Metrics) {
+        Metrics.countEvent(Metrics.EVENT_TYPE.ERROR, "uncaught", "main.js");
+    }
     return true; // same as preventDefault
 };
 
+window.addEventListener("unhandledrejection", function (event){
+    console.error("Caught unhandledrejection from: ", event);
+    if(Metrics) {
+        Metrics.countEvent(Metrics.EVENT_TYPE.ERROR, "unhandled", "rejection");
+    }
+    return true; // same as preventDefault
+});
+
 define(function (require) {
 
 
     // Load compatibility shims--these need to load early, be careful moving this
     // Event dispatcher must be loaded before worker comm https://github.com/phcode-dev/phoenix/pull/678
-    require(["utils/Compatibility", "utils/EventDispatcher"], function () {
+    require(["utils/Metrics", "utils/Compatibility", "utils/EventDispatcher"], function () {
+        Metrics = require("utils/Metrics");
         // Load the brackets module. This is a self-running module that loads and runs the entire application.
         try{
             require(["brackets"]);
         } catch (e) {
             console.error('Critical error when loading brackets. Trying to reload again.');
+            if(Metrics) {
+                Metrics.countEvent(Metrics.EVENT_TYPE.ERROR, "loadErr", "reload");
+            }
             window.location.reload();
         }
     });

src/utils/AppInit.js

@@ -32,7 +32,7 @@
  * loading.
  */
 define(function (require, exports, module) {
-
+    const Metrics = require("utils/Metrics");
 
     /*
      * Fires when the base htmlContent/main-view.html is loaded
@@ -88,6 +88,7 @@ define(function (require, exports, module) {
         } catch (e) {
             console.error("Exception when calling a 'brackets done loading' handler: " + e);
             console.log(e.stack);
+            Metrics.countEvent(Metrics.EVENT_TYPE.ERROR, "appInit", "doneLoading");
         }
     }
 

src/utils/Metrics.js

@@ -78,7 +78,8 @@ define(function (require, exports, module) {
         SHARING: "sharing",
         PERFORMANCE: "performance",
         STORAGE: "storage",
-        NEW_PROJECT: "new-project"
+        NEW_PROJECT: "new-project",
+        ERROR: "error"
     };
 
     /**

test/spec/Metrics-test.js

@@ -38,7 +38,6 @@ define(function (require, exports, module) {
             let data = Metrics.getLoggedDataForAudit();
             expect(data.get("typec.cat.sub")).toEqual({ eventType: 'count', sum: 2, count: 2 });
             expect(data.get("typev.cat.sub")).toEqual({ eventType: 'val', sum: -10, count: 2 });
-            expect(data.size).toEqual(2);
         });
 
         it("should log health metrics For audit even if disabled", function () {
@@ -53,7 +52,6 @@ define(function (require, exports, module) {
             data = Metrics.getLoggedDataForAudit();
             expect(data.get("typec.cat.sub")).toEqual({ eventType: 'count', sum: 2, count: 2 });
             expect(data.get("typev.cat.sub")).toEqual({ eventType: 'val', sum: -10, count: 2 });
-            expect(data.size).toEqual(2);
         });
 
         it("should delete 1000 entries if 3000 max entries have been logged", function () {