chore: silent auto updates for better update UX

Author: abose

src/extensionsIntegrated/appUpdater/main.js

@@ -162,7 +162,7 @@ define(function (require, exports, module) {
                 // was actually done. We have a version number mismatch of 0.0.1 between phoenix-desktop and phoenix
                 // repo, and that means that this can get triggered on statup on development builds. Wont happen in
                 // actual pipeline generated build tho.
-                console.log("Updates applied, waiting for app restart: ", phoenixBinaryVersion, phoenixLoadedAppVersion);
+                console.log("Updates applied, waiting for app restart:", phoenixBinaryVersion, phoenixLoadedAppVersion);
                 updateDetails.updatePendingRestart = true;
                 PreferencesManager.setViewState(KEY_UPDATE_AVAILABLE, true);
             } else {
@@ -172,6 +172,7 @@ define(function (require, exports, module) {
             showOrHideUpdateIcon();
         } catch (e) {
             console.error("Error getting update metadata", e);
+            logger.reportError(e, `Error getting app update metadata`);
             updateFailed = true;
             Metrics.countEvent(Metrics.EVENT_TYPE.UPDATES, 'fail', "Unknown"+Phoenix.platform);
         }
@@ -217,15 +218,45 @@ define(function (require, exports, module) {
         return [updateLater, updateOnExit];
     }
 
+    async function _updateWithConfirmDialog(isUpgradableLoc, updateDetails) {
+        const buttons = _getButtons(isUpgradableLoc);
+        let markdownHtml = marked.parse(updateDetails.releaseNotesMarkdown || "");
+        Metrics.countEvent(Metrics.EVENT_TYPE.UPDATES, 'dialog', "shown"+Phoenix.platform);
+        Dialogs.showModalDialog(DefaultDialogs.DIALOG_ID_INFO, Strings.UPDATE_AVAILABLE_TITLE, markdownHtml, buttons)
+            .done(option=>{
+                if(option === Dialogs.DIALOG_BTN_CANCEL){
+                    Metrics.countEvent(Metrics.EVENT_TYPE.UPDATES, 'dialog', "cancel"+Phoenix.platform);
+                    return;
+                }
+                if(!isUpgradableLoc) {
+                    // user installed linux as binary without installer, we just open phcode.io
+                    const downloadPage = brackets.config.homepage_url || "https://phcode.io";
+                    NativeApp.openURLInDefaultBrowser(downloadPage);
+                    Metrics.countEvent(Metrics.EVENT_TYPE.UPDATES, 'dialog', "nonUpgradable"+Phoenix.platform);
+                    return;
+                }
+                if(option === Dialogs.DIALOG_BTN_OK && !updaterWindow){
+                    Metrics.countEvent(Metrics.EVENT_TYPE.UPDATES, 'dialog', "okUpdate"+Phoenix.platform);
+                    doUpdate(updateDetails.downloadURL);
+                }
+            });
+    }
+
     async function checkForUpdates(isAutoUpdate) {
         showOrHideUpdateIcon();
+        if(!navigator.onLine) {
+            return;
+        }
         if(updateTask){
             $("#status-tasks .btn-dropdown").click();
             return;
         }
         const updateDetails = await getUpdateDetails(); // this will also show update icon if update present
         if(updateFailed) {
-            Dialogs.showInfoDialog(Strings.UPDATE_FAILED_TITLE, Strings.UPDATE_FAILED_MESSAGE);
+            if(!isAutoUpdate) {
+                // we dont show auto update errors to user
+                Dialogs.showInfoDialog(Strings.UPDATE_FAILED_TITLE, Strings.UPDATE_FAILED_MESSAGE);
+            }
             return;
         }
         if(updatePendingRestart || updateDetails.updatePendingRestart){
@@ -246,29 +277,13 @@ define(function (require, exports, module) {
             // but, we don't show the dialog if auto update is off.
             return;
         }
-
         const isUpgradableLoc = await isUpgradableLocation();
-        const buttons = _getButtons(isUpgradableLoc);
-        let markdownHtml = marked.parse(updateDetails.releaseNotesMarkdown || "");
-        Metrics.countEvent(Metrics.EVENT_TYPE.UPDATES, 'dialog', "shown"+Phoenix.platform);
-        Dialogs.showModalDialog(DefaultDialogs.DIALOG_ID_INFO, Strings.UPDATE_AVAILABLE_TITLE, markdownHtml, buttons)
-            .done(option=>{
-                if(option === Dialogs.DIALOG_BTN_CANCEL){
-                    Metrics.countEvent(Metrics.EVENT_TYPE.UPDATES, 'dialog', "cancel"+Phoenix.platform);
-                    return;
-                }
-                if(!isUpgradableLoc) {
-                    // user installed linux as binary without installer, we just open phcode.io
-                    const downloadPage = brackets.config.homepage_url || "https://phcode.io";
-                    NativeApp.openURLInDefaultBrowser(downloadPage);
-                    Metrics.countEvent(Metrics.EVENT_TYPE.UPDATES, 'dialog', "nonUpgradable"+Phoenix.platform);
-                    return;
-                }
-                if(option === Dialogs.DIALOG_BTN_OK && !updaterWindow){
-                    Metrics.countEvent(Metrics.EVENT_TYPE.UPDATES, 'dialog', "okUpdate"+Phoenix.platform);
-                    doUpdate(updateDetails.downloadURL);
-                }
-            });
+        if(!isUpgradableLoc || !isAutoUpdate) {
+            _updateWithConfirmDialog(isUpgradableLoc, updateDetails);
+        } else if(!updaterWindow) {
+            Metrics.countEvent(Metrics.EVENT_TYPE.UPDATES, 'auto', "silent"+Phoenix.platform);
+            doUpdate(updateDetails.downloadURL);
+        }
     }
 
     const UPDATE_COMMANDS = {

src/nls/root/strings.js

@@ -618,7 +618,7 @@ define({
     "UPDATE_FAILED_TITLE": "Update Failed",
     "UPDATE_INSTALLING": "Installing Update\u2026",
     "UPDATE_INSTALLING_MESSAGE": "Update Installation in Progress: {APP_NAME} is currently installing the latest updates. The application will automatically close once the installation is complete.",
-    "UPDATE_FAILED_MESSAGE": "Please close all {APP_NAME} app windows and reopen the application to attempt the update again.",
+    "UPDATE_FAILED_MESSAGE": "Please close all {APP_NAME} app windows and reopen the application to attempt the update again. <br/> You can also install the update by downloading the installer from <a href='https://phcode.io'>phcode.io</a>",
     "UPDATE_FAILED_VISIT_SITE_MESSAGE": "To retry, please exit all instances of {APP_NAME} and restart the application. <br>You will be directed to our download page shortly, where you can manually download the latest version.",
     "UPDATE_MESSAGE": "Hey, there's a new build of {APP_NAME} available. Here are some of the new features:",
     "GET_IT_NOW": "Get it now!",