chore: spanner status icon if there are fixes available

Author: abose

src/language/CodeInspection.js

@@ -381,7 +381,14 @@ define(function (require, exports, module) {
 
         $problemsPanel.find(".title").text(message);
         tooltip = StringUtils.format(Strings.STATUSBAR_CODE_INSPECTION_TOOLTIP, message);
-        StatusBar.updateIndicator(INDICATOR_ID, true, "inspection-errors", tooltip);
+        let iconType = "inspection-errors";
+        if(documentFixes.size){
+            tooltip = StringUtils.format(Strings.STATUSBAR_CODE_INSPECTION_TOOLTIP_WITH_FIX,
+                documentFixes.size, message);
+            iconType =  "inspection-repair";
+        }
+
+        StatusBar.updateIndicator(INDICATOR_ID, true, iconType, tooltip);
     }
 
     function _getMarkOptions(error){
@@ -503,6 +510,8 @@ define(function (require, exports, module) {
             let codeInspectionMarks = editor.findMarksAt(pos, CODE_MARK_TYPE_INSPECTOR) || [];
             let $hoverMessage = $(`<div class="code-inspection-item"></div>`);
             let $problemView, quickViewPresent;
+            let startPos = {line: pos.line, ch: token.start},
+                endPos = {line: pos.line, ch: token.end};
             for(let mark of codeInspectionMarks){
                 quickViewPresent = true;
                 const fixID = `${mark.metadata}`;
@@ -525,11 +534,24 @@ define(function (require, exports, module) {
                     toggleCollapsed(false);
                     _scrollToTableLine(pos.line);
                 });
+                const markPos = mark.find();
+                if(markPos.from && markPos.from.line < startPos.line){
+                    startPos.line = markPos.from.line;
+                }
+                if(markPos.from && markPos.from.ch < startPos.ch){
+                    startPos.ch = markPos.from.ch;
+                }
+                if(markPos.to && markPos.to.line > endPos.line){
+                    endPos.line = markPos.to.line;
+                }
+                if(markPos.to && markPos.to.ch > endPos.ch){
+                    endPos.ch = markPos.to.ch;
+                }
             }
             if(quickViewPresent){
                 resolve({
-                    start: {line: pos.line, ch: token.start}, // tod this should not be of the token
-                    end: {line: pos.line, ch: token.end},
+                    start: startPos,
+                    end: endPos,
                     content: $hoverMessage
                 });
                 return;

src/nls/root/strings.js

@@ -396,6 +396,7 @@ define({
     "STATUSBAR_INSOVR_TOOLTIP": "Click to toggle cursor between Insert (INS) and Overwrite (OVR) modes",
     "STATUSBAR_LANG_TOOLTIP": "Click to change file type",
     "STATUSBAR_CODE_INSPECTION_TOOLTIP": "{0}. Click to toggle report panel.",
+    "STATUSBAR_CODE_INSPECTION_TOOLTIP_WITH_FIX": "{0} Problem fixable. {1}. Click to toggle report panel.",
     "STATUSBAR_DEFAULT_LANG": "(default)",
     "STATUSBAR_SET_DEFAULT_LANG": "Set as Default for .{0} Files",
     "STATUSBAR_ENCODING_TOOLTIP": "Select the encoding",

src/styles/brackets.less

@@ -2885,7 +2885,7 @@ textarea.exclusions-editor {
     cursor: default;
     width: 13px;
 
-    &.inspection-errors {
+    &.inspection-errors, &.inspection-repair {
         cursor: pointer;
     }
 }
@@ -2898,11 +2898,15 @@ textarea.exclusions-editor {
     background: url(images/topcoat-warning-15.svg) 9px 5px no-repeat;
 }
 
-.inspection-errors:hover {
+.inspection-repair {
+    background: url(images/topcoat-repair-15.svg) 9px 5px no-repeat;
+}
+
+.inspection-errors:hover, .inspection-repair:hover {
     background-color: rgba(0, 0, 0, 0.03);
 }
 
-.inspection-errors:active {
+.inspection-errors:active, .inspection-repair:active {
     background-color: rgba(0, 0, 0, 0.05);
 }
 

src/styles/images/topcoat-repair-15.svg

@@ -102,7 +102,8 @@ define(function (require, exports, module) {
             // there will be an error in problems panel if both present
             await awaitsForDone(SpecRunnerUtils.openProjectFiles(".phcode.json"));
             await awaitsFor(()=>{
-                return testWindow.$("#problems-panel").text().includes(Strings.ERROR_PREFS_PROJECT_LINT_MESSAGE);
+                return testWindow.$("#problems-panel").is(":visible") &&
+                    testWindow.$("#problems-panel").text().includes(Strings.ERROR_PREFS_PROJECT_LINT_MESSAGE);
             }, "problem panel on .phcode.json");
 
             await awaitsForDone(SpecRunnerUtils.openProjectFiles("test.json"));
@@ -112,7 +113,8 @@ define(function (require, exports, module) {
 
             await awaitsForDone(SpecRunnerUtils.openProjectFiles(".brackets.json"));
             await awaitsFor(()=>{
-                return testWindow.$("#problems-panel").text().includes(Strings.ERROR_PREFS_PROJECT_LINT_MESSAGE);
+                return testWindow.$("#problems-panel").is(":visible") &&
+                    testWindow.$("#problems-panel").text().includes(Strings.ERROR_PREFS_PROJECT_LINT_MESSAGE);
             }, "problem panel on .brackets.json");
         });