chore: refine tests scripts after playwright integration

Author: abose

.github/workflows/build_verify.yml

@@ -18,9 +18,6 @@ jobs:
       - name: eslint using npm run eslint
         run: |
           npm run lint
-      - name: building Phoenix with npm run buildonly
+      - name: building Phoenix with npm run build
         run: |
-          npm run buildonly
-      - name: Testing Phoenix with npm run test
-        run: |
-          npm run test
+          npm run build

.github/workflows/playwright-chromium.yml

@@ -1,4 +1,4 @@
-name: chromium Run unit tests suite with Playwright Tests
+name: Chromium run unit tests suite with Playwright
 on:
   push:
     branches: [ main ]

.github/workflows/playwright-firefox.yml

@@ -1,4 +1,4 @@
-name: FireFox Run unit tests suite with Playwright Tests
+name: Firefox run unit tests suite with Playwright
 on:
   push:
     branches: [ main ]

README.md

@@ -76,7 +76,7 @@ IDEs from this link before raising a pull request: https://www.sonarlint.org/
 * The release artifacts to host will be in `dist` folder.
 
 ## Running tests
-* run `npm run test` in the terminal.
+* run `npm run zipTestFiles` in the terminal.
   * NB: this will setup all the required files for test 
 * Use chrome/edge browser to navigate to Phoenix[http://localhost:8000/src/index.html](http://localhost:8000/src/index.html)
 * In Phoenix Menu, select `Debug > run Tests` To open the test runner.

gulpfile.js/index.js

@@ -374,7 +374,7 @@ exports.releaseStaging = series(cleanDist, exports.build, makeDistNonJS, makeJSD
 exports.releaseProd = series(cleanDist, exports.build, makeDistNonJS, makeJSDist, releaseProd,
     createDistCacheManifest);
 exports.serve = series(exports.build, serve);
-exports.test = series(zipTestFiles);
+exports.zipTestFiles = series(zipTestFiles);
 exports.serveExternal = series(exports.build, serveExternal);
 exports.createJSDocs = series(cleanDocs, createJSDocs, generateDocIndex);
 exports.translateStrings = series(translateStrings);

package.json

@@ -47,12 +47,13 @@
     "lint:fix": "eslint --quiet --fix src test",
     "prepare": "husky install",
     "serveTest": "http-server . -p 5000 -c-1",
-    "test": "gulp test",
+    "zipTestFiles": "gulp test",
+    "test": "npx playwright test",
     "testChromium": "npx playwright test --project=chromium",
     "testFirefox": "npx playwright test --project=firefox",
     "buildonly": "gulp build",
     "vulnerabilityCheck": "echo Scanning for vulnarabilities && npm audit --prod",
-    "build": "npm run buildonly && npm run createJSDocs && npm run test && npm run lint && npm run vulnerabilityCheck",
+    "build": "npm run buildonly && npm run createJSDocs && npm run zipTestFiles && npm run lint && npm run vulnerabilityCheck",
     "clean": "gulp clean",
     "reset": "gulp reset",
     "release:dev": "gulp releaseDev",

test/SpecRunner.html

@@ -29,7 +29,7 @@
 
   <script type="text/javascript">
     //brackets.app.showDeveloperTools();
-    console.warn('Make sure to run this following command before starting tests : npm run test ');
+    console.warn('Make sure to run this following command before starting tests : npm run zipTestFiles ');
   </script>
 
   <script>
@@ -208,7 +208,7 @@
       <button id="copyFullReportButton"> Copy Full Report</button>
     </div>
     <div id="loading" style="display: none; margin-top: 100px;">
-      Please run <code>npm run test</code> before starting tests at least once or if you are facing issues.
+      Please run <code>npm run zipTestFiles</code> before starting tests at least once or if you are facing issues.
       </p>Extracting test files <span id="loadProgressMessage"></span>.... <img src="../src/styles/images/throbber.gif" alt=".......">
     </div>
     <div id="mock-main-view" style="position:absolute; height:1000px; width:1000px; left:-10000px; top:-10000px;"></div>

test/SpecRunner.js

@@ -520,7 +520,7 @@ define(function (require, exports, module) {
             let JSZip = require("thirdparty/jszip");
             window.JSZipUtils.getBinaryContent('test_folders.zip', function(err, data) {
                 if(err) {
-                    alert("Please run 'npm run test' before starting this test. " +
+                    alert("Please run 'npm run zipTestFiles' before starting this test. " +
                         "Could not create test files in phoenix virtual fs. Some tests may fail");
                     _showLoading(false);
                     init();