chore: get device id moved to node

Author: abose

src-node/utils.js

@@ -316,6 +316,7 @@ async function addDeviceLicense() {
         const dir = path.dirname(targetPath);
         // POSIX: mkdir + printf (use absolute paths)
         const safe = content.replace(/'/g, `'\\''`);
+        // todo we need to chmod to make this world readable
         command = `/bin/mkdir -p "${dir}" && /bin/printf '%s' '${safe}' > "${targetPath}"`;
     }
 
@@ -349,6 +350,51 @@ async function isLicensedDevice() {
     }
 }
 
+async function _getLinuxDeviceID() {
+    const data = await fsPromise.readFile("/etc/machine-id", "utf8");
+    const id = data.trim();
+    return id || null;
+    // throw on error to main.
+    // no fallback, /var/lib/dbus/machine-id may need sudo in some machines
+}
+
+/**
+ * Get the macOS device ID (IOPlatformUUID).
+ * @returns {Promise<string|null>}
+ */
+function _getMacDeviceID() {
+    return new Promise((resolve, reject) => {
+        exec(
+            'ioreg -rd1 -c IOPlatformExpertDevice | grep IOPlatformUUID',
+            { encoding: 'utf8' },
+            (err, stdout) => {
+                if (err) {
+                    console.error('Failed to get Mac device ID:', err.message);
+                    return reject(err);
+                }
+
+                const match = stdout.match(/"IOPlatformUUID" = "([^"]+)"/);
+                if (match && match[1]) {
+                    resolve(match[1]);
+                } else {
+                    resolve(null);
+                }
+            }
+        );
+    });
+}
+
+async function getDeviceID() {
+    if (process.platform === "linux") {
+        return _getLinuxDeviceID();
+    } else if (process.platform === "darwin") {
+        return _getMacDeviceID();
+    } else if (process.platform === "win32") {
+        return "not implemented"; //await _getWindowsDeviceID();
+    }
+    throw new Error(`Unsupported platform: ${process.platform}`);
+}
+
 exports.getURLContent = getURLContent;
 exports.setLocaleStrings = setLocaleStrings;
 exports.getPhoenixBinaryVersion = getPhoenixBinaryVersion;
@@ -361,5 +407,6 @@ exports.openInDefaultApp = openInDefaultApp;
 exports.addDeviceLicense = addDeviceLicense;
 exports.removeDeviceLicense = removeDeviceLicense;
 exports.isLicensedDevice = isLicensedDevice;
+exports.getDeviceID = getDeviceID;
 exports._loadNodeExtensionModule = _loadNodeExtensionModule;
 exports._npmInstallInFolder = _npmInstallInFolder;

src/services/login-service.js

@@ -216,27 +216,27 @@ define(function (require, exports, module) {
         }
     }
 
-    async function _getLinuxDeviceID() {
-        const LINUX_DEVICE_ID_FILE = Phoenix.VFS.getTauriVirtualPath('/etc/machine-id');
-        const result = await Phoenix.VFS.readFileResolves(LINUX_DEVICE_ID_FILE, 'utf8');
-        if(result.error || !result.data) {
-            logger.reportError(result.error, `Failed to read machine-id file for licensing`);
-            return null;
-        }
-        return KernalModeTrust.generateDataSignature(result.data.trim()); // \n and spaces are trimmed, just id please
-    }
-
-    let deviceIDCached = null;
+    let deviceIDCached = undefined;
     async function getDeviceID() {
         if(!Phoenix.isNativeApp) {
             // We only grant device licenses to desktop apps. Browsers cannot be uniquely device identified obviously.
             return null;
         }
-        if(deviceIDCached) {
+        if(deviceIDCached !== undefined) {
             return deviceIDCached;
         }
-        switch (Phoenix.platform) {
-        case 'linux': deviceIDCached = await _getLinuxDeviceID();
+        try {
+            const deviceID = await NodeUtils.getDeviceID();
+            if(!deviceID) {
+                deviceIDCached = null;
+                Metrics.countEvent(Metrics.EVENT_TYPE.AUTH, "deviceID", "nullErr");
+                return null;
+            }
+            deviceIDCached = KernalModeTrust.generateDataSignature(deviceID);
+        } catch (e) {
+            logger.reportError(e, "failed to sign deviceID");
+            Metrics.countEvent(Metrics.EVENT_TYPE.AUTH, "deviceID", "SignErr");
+            deviceIDCached = null;
         }
         return deviceIDCached;
     }

src/utils/NodeUtils.js

@@ -191,6 +191,31 @@ define(function (require, exports, module) {
         return utilsConnector.execPeer("openInDefaultApp", window.fs.getTauriPlatformPath(fullPath));
     }
 
+
+    let cachedDeviceID = undefined;
+    /**
+     * gets the os device id. this usually won't change till os reinstall.
+     *
+     * @returns {Promise<string|null>} - Resolves with the os identifier or null
+     * @throws {Error} - If called from the browser
+     */
+    async function getDeviceID() {
+        if (!Phoenix.isNativeApp) {
+            throw new Error("getDeviceID not available in browser");
+        }
+        if(cachedDeviceID !== undefined) {
+            return cachedDeviceID;
+        }
+        try {
+            cachedDeviceID = await utilsConnector.execPeer("getDeviceID");
+            return cachedDeviceID;
+        } catch (err) {
+            cachedDeviceID = null;
+            logger.reportError(err, "getDeviceID failed in NodeUtils");
+        }
+        return cachedDeviceID;
+    }
+
     /**
      * Enables device license by creating a system-wide license file.
      * On Windows, macOS, and Linux this will request elevation if needed.
@@ -291,6 +316,7 @@ define(function (require, exports, module) {
     exports.addDeviceLicenseSystemWide = addDeviceLicenseSystemWide;
     exports.removeDeviceLicenseSystemWide = removeDeviceLicenseSystemWide;
     exports.isLicensedDeviceSystemWide = isLicensedDeviceSystemWide;
+    exports.getDeviceID = getDeviceID;
 
     /**
      * checks if Node connector is ready