fix: opening text files with open with opens live preview on startup

Author: abose

src/extensionsIntegrated/Phoenix-live-preview/NodeStaticServer.js

@@ -588,13 +588,22 @@ define(function (require, exports, module) {
 
     function _getExternalPreviewURL(fullPath) {
         if(utils.isHTMLFile(fullPath)) {
-            return getNoPreviewURL(Strings.DESCRIPTION_LIVEDEV_PREVIEW_RESTRICTED,
-                Strings.DESCRIPTION_LIVEDEV_PREVIEW_RESTRICTED_DETAILS);
+            return {
+                url: getNoPreviewURL(Strings.DESCRIPTION_LIVEDEV_PREVIEW_RESTRICTED,
+                    Strings.DESCRIPTION_LIVEDEV_PREVIEW_RESTRICTED_DETAILS),
+                isNoPreview: true
+            };
         }
         if(!utils.isPreviewableFile(fullPath)){
-            return getNoPreviewURL();
+            return {
+                url: getNoPreviewURL(),
+                isNoPreview: true
+            };
         }
-        return `${staticServerURL}externalProject/${path.basename(fullPath)}`;
+        return {
+            url: `${staticServerURL}externalProject/${path.basename(fullPath)}`,
+            isNoPreview: false
+        };
     }
 
     function getTabPopoutURL(url) {
@@ -635,8 +644,10 @@ define(function (require, exports, module) {
                 let fullPath = currentFile.fullPath;
                 if(!ProjectManager.isWithinProject(fullPath)){
                     // external project file. Use secure external preview link.
+                    const preview = _getExternalPreviewURL(fullPath);
                     resolve({
-                        URL: _getExternalPreviewURL(fullPath),
+                        URL: preview.url,
+                        isNoPreview: preview.isNoPreview,
                         filePath: fullPath,
                         fullPath: fullPath,
                         isMarkdownFile: utils.isMarkdownFile(fullPath),

src/extensionsIntegrated/Phoenix-live-preview/main.js

@@ -589,16 +589,6 @@ define(function (require, exports, module) {
             _togglePinUrl();
         }
         $iframe.attr('src', StaticServer.getNoPreviewURL());
-        if(!panelShownAtStartup && !isBrowser){
-            // we dont do this in browser as the virtual server may not yet be started on app start
-            // project open and a 404 page will briefly flash in the browser!
-            const currentDocument = DocumentManager.getCurrentDocument();
-            const currentFile = currentDocument? currentDocument.file : ProjectManager.getSelectedItem();
-            const isPreviewable = currentFile ? utils.isPreviewableFile(currentFile.fullPath) : false;
-            if(isPreviewable){
-                _setPanelVisibility(true);
-            }
-        }
         if(!panel.isVisible()){
             return;
         }
@@ -661,10 +651,14 @@ define(function (require, exports, module) {
         }
         if(changedFile && (utils.isPreviewableFile(fullPath) ||
             utils.isServerRenderedFile(fullPath))){
+            _loadPreview();
             if(!panelShownAtStartup){
-                _setPanelVisibility(true);
+                let previewDetails = await StaticServer.getPreviewDetails();
+                if(previewDetails && !previewDetails.isNoPreview) {
+                    _setPanelVisibility(true);
+                    _loadPreview();
+                }
             }
-            _loadPreview();
         }
     }
 
@@ -748,6 +742,8 @@ define(function (require, exports, module) {
             return;
         }
         panelShownAtStartup = !LivePreviewSettings.shouldShowLivePreviewAtStartup();
+        Metrics.countEvent(Metrics.EVENT_TYPE.LIVE_PREVIEW, "atStart",
+            LivePreviewSettings.shouldShowLivePreviewAtStartup() ? "show" : "hide");
         _createExtensionPanel();
         StaticServer.init();
         LiveDevServerManager.registerServer({ create: _createStaticServer }, 5);