Skip to content

Commit e85a427

Browse files
committed
fix: intermittant failures of file filters tests in pipeline
1 parent bfb5d08 commit e85a427

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

test/spec/Extn-ESLint-integ-test.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,5 @@ define(function (require, exports, module) {
310310
}, "eslint new eq rule added to be honored in lint");
311311
}, 5000);
312312
});
313-
314-
// todo eslint module test for es9
315313
});
316314
});

test/spec/FileFilters-integ-test.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,12 @@ define(function (require, exports, module) {
302302
it("should search in files", async function () {
303303
await openSearchBar();
304304
_setSearchInFiles("*.css");
305-
await executeCleanSearch("{1}");
305+
await awaitsFor(async ()=>{
306+
await executeCleanSearch("{1}");
307+
return FindInFiles.searchModel.results[testPath + "/test1.css"];
308+
// we have to do this in a loop as we were seeing intermittent failures in GitHub actions
309+
}, "Search to get correct results", 7000, 300);
310+
306311
expect(FindInFiles.searchModel.results[testPath + "/test1.css"]).toBeTruthy();
307312
expect(FindInFiles.searchModel.results[testPath + "/test1.html"]).toBeFalsy();
308313
await closeSearchBar();

0 commit comments

Comments
 (0)