feat: go to next and previous problem

Author: abose

src/base-config/keyboard.json

@@ -304,6 +304,12 @@
             "key": "Alt-PageDown"
         }
     ],
+    "navigate.gotoNextProblem": [
+        "F8"
+    ],
+    "navigate.gotoPrevProblem": [
+        "Shift-F8"
+    ],
     "navigate.prevDocListOrder":  [
         {
             "key": "Alt-PageUp"

src/command/Commands.js

@@ -149,6 +149,8 @@ define(function (require, exports, module) {
     exports.NAVIGATE_GOTO_DEFINITION_PROJECT = "navigate.gotoDefinitionInProject";    // QuickOpen.js                 doDefinitionSearchInProject()
     exports.NAVIGATE_GOTO_LINE          = "navigate.gotoLine";          // QuickOpen.js                 doGotoLine()
     exports.NAVIGATE_GOTO_FIRST_PROBLEM = "navigate.gotoFirstProblem";  // CodeInspection.js            handleGotoFirstProblem()
+    exports.NAVIGATE_GOTO_NEXT_PROBLEM = "navigate.gotoNextProblem";  // CodeInspection.js            handleGotoNextProblem()
+    exports.NAVIGATE_GOTO_PREV_PROBLEM = "navigate.gotoPrevProblem";  // CodeInspection.js            handleGotoPrevProblem()
     exports.TOGGLE_QUICK_EDIT           = "navigate.toggleQuickEdit";   // EditorManager.js             _toggleInlineWidget()
     exports.TOGGLE_QUICK_DOCS           = "navigate.toggleQuickDocs";   // EditorManager.js             _toggleInlineWidget()
     exports.QUICK_EDIT_NEXT_MATCH       = "navigate.nextMatch";         // MultiRangeInlineEditor.js    _nextRange()

src/command/DefaultMenus.js

@@ -235,7 +235,8 @@ define(function (require, exports, module) {
         menu.addMenuItem(Commands.NAVIGATE_GOTO_DEFINITION);
         menu.addMenuItem(Commands.NAVIGATE_GOTO_DEFINITION_PROJECT);
         menu.addMenuItem(Commands.NAVIGATE_JUMPTO_DEFINITION);
-        menu.addMenuItem(Commands.NAVIGATE_GOTO_FIRST_PROBLEM);
+        menu.addMenuItem(Commands.NAVIGATE_GOTO_NEXT_PROBLEM);
+        menu.addMenuItem(Commands.NAVIGATE_GOTO_PREV_PROBLEM);
         menu.addMenuDivider();
         menu.addMenuItem(Commands.NAVIGATE_NEXT_DOC);
         menu.addMenuItem(Commands.NAVIGATE_PREV_DOC);

src/editor/Editor.js

@@ -1333,6 +1333,26 @@ define(function (require, exports, module) {
         });
     };
 
+    /**
+     * Returns the first mark of a specific type found after the given position.
+     * @param {{line: number, ch: number}} position - The starting position to search from.
+     * @param {string} markType - The type of mark to look for.
+     * @returns {Array[TextMarker]} The array of text markers found, or an empty array if none are found.
+     */
+    Editor.prototype.getMarksAfter = function (position, markType) {
+        return this.findMarks(position, { line: this.lineCount(), ch: 0 }, markType) || [];
+    };
+
+    /**
+     * Returns the first mark of a specific type found before the given position.
+     * @param {{line: number, ch: number}} position - The ending position to search up to.
+     * @param {string} markType - The type of mark to look for.
+     * @returns {Array[TextMarker]} The array of text markers found, or an empty array if none are found.
+     */
+    Editor.prototype.getMarksBefore = function (position, markType) {
+        return this.findMarks({ line: 0, ch: 0 }, position, markType) || [];
+    };
+
     /**
      * Returns an array containing all marked ranges in the document.
      * @param {string} [markType] - Optional, if given will only return marks of that type. Else returns everything.

src/language/CodeInspection.js

@@ -181,6 +181,8 @@ define(function (require, exports, module) {
      */
     function setGotoEnabled(gotoEnabled) {
         CommandManager.get(Commands.NAVIGATE_GOTO_FIRST_PROBLEM).setEnabled(gotoEnabled);
+        CommandManager.get(Commands.NAVIGATE_GOTO_NEXT_PROBLEM).setEnabled(gotoEnabled);
+        CommandManager.get(Commands.NAVIGATE_GOTO_PREV_PROBLEM).setEnabled(gotoEnabled);
         _gotoEnabled = gotoEnabled;
     }
 
@@ -1076,10 +1078,78 @@ define(function (require, exports, module) {
         }
     }
 
+    function handleGotoNextProblem() {
+        if (_gotoEnabled) {
+            const editor = EditorManager.getCurrentFullEditor();
+            if(!editor){
+                return;
+            }
+            const currentCursor = editor.getCursorPos();
+            const nextMarks = editor.getMarksAfter(currentCursor, CODE_MARK_TYPE_INSPECTOR);
+            if(!nextMarks.length || !nextMarks[0].find()){
+                return;
+            }
+
+            let nextMark = null;
+            for (let i = 0; i < nextMarks.length; i++) {
+                const markRange = nextMarks[i].find();
+                if (markRange && (markRange.from.line > currentCursor.line ||
+                    (markRange.from.line === currentCursor.line && markRange.from.ch > currentCursor.ch))) {
+                    nextMark = nextMarks[i];
+                    break;
+                }
+            }
+
+            if (!nextMark) {
+                return;
+            }
+            const nextMarkRange = nextMark.find();
+            if (nextMarkRange) {
+                editor.setCursorPos(nextMarkRange.from.line, nextMarkRange.from.ch);
+            }
+        }
+    }
+
+    function handleGotoPrevProblem() {
+        if (_gotoEnabled) {
+            const editor = EditorManager.getCurrentFullEditor();
+            if (!editor) {
+                return;
+            }
+            const currentCursor = editor.getCursorPos();
+            const prevMarks = editor.getMarksBefore(currentCursor, CODE_MARK_TYPE_INSPECTOR);
+
+            if (!prevMarks.length) {
+                return;
+            }
+
+            let prevMark = null;
+            for (let i = prevMarks.length - 1; i >= 0; i--) {
+                const markRange = prevMarks[i].find();
+                if (markRange && (markRange.to.line < currentCursor.line ||
+                    (markRange.to.line === currentCursor.line && markRange.to.ch < currentCursor.ch))) {
+                    prevMark = prevMarks[i];
+                    break;
+                }
+            }
+
+            if (!prevMark) {
+                return;
+            }
+
+            const prevMarkRange = prevMark.find();
+            if (prevMarkRange) {
+                editor.setCursorPos(prevMarkRange.from.line, prevMarkRange.from.ch);
+            }
+        }
+    }
+
     // Register command handlers
     CommandManager.register(Strings.CMD_VIEW_TOGGLE_INSPECTION, Commands.VIEW_TOGGLE_INSPECTION,        toggleEnabled);
     CommandManager.register(Strings.CMD_VIEW_TOGGLE_PROBLEMS, Commands.VIEW_TOGGLE_PROBLEMS,        toggleProblems);
     CommandManager.register(Strings.CMD_GOTO_FIRST_PROBLEM,     Commands.NAVIGATE_GOTO_FIRST_PROBLEM,   handleGotoFirstProblem);
+    CommandManager.register(Strings.CMD_GOTO_NEXT_PROBLEM,     Commands.NAVIGATE_GOTO_NEXT_PROBLEM,   handleGotoNextProblem);
+    CommandManager.register(Strings.CMD_GOTO_PREV_PROBLEM,     Commands.NAVIGATE_GOTO_PREV_PROBLEM,   handleGotoPrevProblem);
 
     // Register preferences
     prefs.definePreference(PREF_ENABLED, "boolean", brackets.config["linting.enabled_by_default"], {

src/nls/root/strings.js

@@ -567,6 +567,8 @@ define({
     "CMD_GOTO_DEFINITION": "Quick Find Definition",
     "CMD_GOTO_DEFINITION_PROJECT": "Quick Find Definition in Project",
     "CMD_GOTO_FIRST_PROBLEM": "Go to First Problem",
+    "CMD_GOTO_NEXT_PROBLEM": "Go to Next Problem",
+    "CMD_GOTO_PREV_PROBLEM": "Go to Previous Problem",
     "CMD_TOGGLE_QUICK_EDIT": "Quick Edit",
     "CMD_TOGGLE_QUICK_DOCS": "Quick Docs",
     "CMD_QUICK_EDIT_PREV_MATCH": "Previous Quick Edit Item",