Filter campaigns by subject

Fix: flush entity manager after updates

Author: tatevikg1

src/Messaging/Controller/CampaignController.php

@@ -66,7 +66,14 @@ public function __construct(
                 in: 'query',
                 required: false,
                 schema: new OA\Schema(type: 'integer', default: 25, maximum: 100, minimum: 1)
-            )
+            ),
+            new OA\Parameter(
+                name: 'subject',
+                description: 'Filter campaigns by subject (partial match)',
+                in: 'query',
+                required: false,
+                schema: new OA\Schema(type: 'string', maxLength: 50)
+            ),
         ],
         responses: [
             new OA\Response(
@@ -96,7 +103,7 @@ public function getMessages(Request $request): JsonResponse
         $authUser = $this->requireAuthentication($request);
 
         return $this->json(
-            $this->campaignService->getMessages($request, $authUser),
+            $this->campaignService->getMessages(request: $request, administrator: $authUser),
             Response::HTTP_OK
         );
     }
@@ -148,10 +155,10 @@ public function getMessage(
         Request $request,
         #[MapEntity(mapping: ['messageId' => 'id'])] ?Message $message = null
     ): JsonResponse {
+        $this->requireAuthentication($request);
         if ($message === null) {
             throw $this->createNotFoundException('Campaign not found.');
         }
-        $this->requireAuthentication($request);
 
         return $this->json($this->campaignService->getMessage($message), Response::HTTP_OK);
     }

src/Messaging/Controller/ListMessageController.php

@@ -27,25 +27,16 @@
 #[Route('/list-messages', name: 'list_message_')]
 class ListMessageController extends BaseController
 {
-    private ListMessageManager $listMessageManager;
-    private ListMessageNormalizer $listMessageNormalizer;
-    private SubscriberListNormalizer $subscriberListNormalizer;
-    private MessageNormalizer $messageNormalizer;
-
     public function __construct(
-        Authentication $authentication,
-        RequestValidator $validator,
-        ListMessageManager $listMessageManager,
-        ListMessageNormalizer $listMessageNormalizer,
-        SubscriberListNormalizer $subscriberListNormalizer,
-        MessageNormalizer $messageNormalizer,
+        protected Authentication $authentication,
+        protected RequestValidator $validator,
+        private readonly ListMessageManager $listMessageManager,
+        private readonly ListMessageNormalizer $listMessageNormalizer,
+        private readonly SubscriberListNormalizer $subscriberListNormalizer,
+        private readonly MessageNormalizer $messageNormalizer,
         private readonly EntityManagerInterface $entityManager,
     ) {
         parent::__construct($authentication, $validator);
-        $this->listMessageManager = $listMessageManager;
-        $this->listMessageNormalizer = $listMessageNormalizer;
-        $this->subscriberListNormalizer = $subscriberListNormalizer;
-        $this->messageNormalizer = $messageNormalizer;
     }
 
     #[Route(
@@ -339,6 +330,7 @@ public function disassociateMessageFromList(
         }
 
         $this->listMessageManager->removeAssociation($message, $subscriberList);
+        $this->entityManager->flush();
 
         return $this->json(null, Response::HTTP_NO_CONTENT);
     }
@@ -398,6 +390,7 @@ public function removeAllListAssociationsForMessage(
         }
 
         $this->listMessageManager->removeAllListAssociationsForMessage($message);
+        $this->entityManager->flush();
 
         return $this->json(null, Response::HTTP_NO_CONTENT);
     }

src/Messaging/Service/CampaignService.php

@@ -30,7 +30,9 @@ public function __construct(
 
     public function getMessages(Request $request, Administrator $administrator): array
     {
-        $filter = (new MessageFilter())->setOwner($administrator);
+        $filter = (new MessageFilter())
+            ->setOwner($administrator)
+            ->setSubject($request->query->get('subject'));
 
         return $this->paginatedProvider->getPaginatedList(
             request: $request,