Fix deprecations for tests and sync bootstrap with the example app

williamdes · williamdes · commit 9ac5fcc54899 · 2026-02-16T11:49:01.000+01:00
Ref: https://github.com/cakephp/app/tree/5.x/tests
diff --git a/tests/Fixture/DevelopersFixture.php b/tests/Fixture/DevelopersFixture.php
@@ -18,10 +18,8 @@ class DevelopersFixture extends TestFixture
 
     /**
      * Records.
-     *
-     * @var array
      */
-    public $records = [
+    public array $records = [
         [
             'id' => 1,
             'github_id' => 1,
diff --git a/tests/Fixture/IncidentsFixture.php b/tests/Fixture/IncidentsFixture.php
@@ -18,10 +18,8 @@ class IncidentsFixture extends TestFixture
 
     /**
      * Records.
-     *
-     * @var array
      */
-    public $records = [
+    public array $records = [
         [
             'id' => 1,
             'error_name' => 'Lorem ipsum dolor sit amet',
diff --git a/tests/Fixture/NotificationsFixture.php b/tests/Fixture/NotificationsFixture.php
@@ -18,10 +18,8 @@ class NotificationsFixture extends TestFixture
 
     /**
      * Records.
-     *
-     * @var array
      */
-    public $records = [
+    public array $records = [
         [
             'id' => 1,
             'developer_id' => 1,
diff --git a/tests/Fixture/ReportsFixture.php b/tests/Fixture/ReportsFixture.php
@@ -6,8 +6,7 @@
 
 class ReportsFixture extends TestFixture
 {
-    /** @var string */
-    public $connection = 'test';
+    public string $connection = 'test';
 
     /**
      * Imports.
@@ -16,8 +15,7 @@ class ReportsFixture extends TestFixture
      */
     public $import = ['table' => 'reports'];
 
-    /** @var array */
-    public $records = [
+    public array $records = [
         [
             'id' => 1,
             'error_message' => 'Lorem ipsum dolor sit amet',
diff --git a/tests/TestCase/AllTestsTest.php b/tests/TestCase/AllTestsTest.php
diff --git a/tests/TestCase/Controller/DevelopersControllerTest.php b/tests/TestCase/Controller/DevelopersControllerTest.php
@@ -18,6 +18,7 @@
 
 namespace App\Test\TestCase\Controller;
 
+use App\Model\Table\DevelopersTable;
 use Cake\ORM\TableRegistry;
 use Cake\TestSuite\IntegrationTestTrait;
 use Cake\TestSuite\TestCase;
@@ -36,12 +37,12 @@ class DevelopersControllerTest extends TestCase
     use PHPMock;
     use IntegrationTestTrait;
 
+    protected DevelopersTable $Developers;
+
     /**
      * Fixtures.
-     *
-     * @var array
      */
-    public $fixtures = [
+    public array $fixtures = [
         'app.Developers',
         'app.Notifications',
     ];
diff --git a/tests/TestCase/Controller/EventsControllerTest.php b/tests/TestCase/Controller/EventsControllerTest.php
@@ -2,6 +2,7 @@
 
 namespace App\Test\TestCase\Controller;
 
+use App\Model\Table\ReportsTable;
 use Cake\ORM\TableRegistry;
 use Cake\TestSuite\IntegrationTestTrait;
 use Cake\TestSuite\TestCase;
@@ -12,12 +13,12 @@ class EventsControllerTest extends TestCase
 {
     use IntegrationTestTrait;
 
+    protected ReportsTable $Reports;
+
     /**
      * Fixtures.
-     *
-     * @var array
      */
-    public $fixtures = ['app.Reports'];
+    public array $fixtures = ['app.Reports'];
 
     public function setUp(): void
     {
diff --git a/tests/TestCase/Controller/GithubControllerTest.php b/tests/TestCase/Controller/GithubControllerTest.php
@@ -18,6 +18,7 @@
 
 namespace App\Test\TestCase\Controller;
 
+use App\Model\Table\ReportsTable;
 use Cake\Core\Configure;
 use Cake\ORM\TableRegistry;
 use Cake\TestSuite\IntegrationTestTrait;
@@ -38,12 +39,12 @@ class GithubControllerTest extends TestCase
     use PHPMock;
     use IntegrationTestTrait;
 
+    protected ReportsTable $Reports;
+
     /**
      * Fixtures.
-     *
-     * @var array
      */
-    public $fixtures = [
+    public array $fixtures = [
         'app.Reports',
         'app.Developers',
         'app.Incidents',
diff --git a/tests/TestCase/Controller/IncidentsControllerTest.php b/tests/TestCase/Controller/IncidentsControllerTest.php
@@ -3,6 +3,7 @@
 namespace App\Test\TestCase\Controller;
 
 use App\Model\Table\IncidentsTable;
+use App\Model\Table\ReportsTable;
 use Cake\Core\Configure;
 use Cake\ORM\TableRegistry;
 use Cake\TestSuite\IntegrationTestTrait;
@@ -18,12 +19,13 @@ class IncidentsControllerTest extends TestCase
 {
     use IntegrationTestTrait;
 
+    protected IncidentsTable $Incidents;
+    protected ReportsTable $Reports;
+
     /**
      * Fixtures.
-     *
-     * @var array
      */
-    public $fixtures = [
+    public array $fixtures = [
         'app.Notifications',
         'app.Developers',
         'app.Reports',
diff --git a/tests/TestCase/Controller/NotificationsControllerTest.php b/tests/TestCase/Controller/NotificationsControllerTest.php
@@ -2,6 +2,7 @@
 
 namespace App\Test\TestCase\Controller;
 
+use App\Model\Table\NotificationsTable;
 use Cake\ORM\TableRegistry;
 use Cake\TestSuite\IntegrationTestTrait;
 use Cake\TestSuite\TestCase;
@@ -15,12 +16,12 @@ class NotificationsControllerTest extends TestCase
 {
     use IntegrationTestTrait;
 
+    protected NotificationsTable $Notifications;
+
     /**
      * Fixtures.
-     *
-     * @var array
      */
-    public $fixtures = [
+    public array $fixtures = [
         'app.Notifications',
         'app.Developers',
         'app.Reports',
diff --git a/tests/TestCase/Controller/ReportsControllerTest.php b/tests/TestCase/Controller/ReportsControllerTest.php
@@ -2,6 +2,7 @@
 
 namespace App\Test\TestCase\Controller;
 
+use App\Model\Table\ReportsTable;
 use Cake\ORM\TableRegistry;
 use Cake\TestSuite\IntegrationTestTrait;
 use Cake\TestSuite\TestCase;
@@ -13,12 +14,12 @@ class ReportsControllerTest extends TestCase
 {
     use IntegrationTestTrait;
 
+    protected ReportsTable $Reports;
+
     /**
      * Fixtures.
-     *
-     * @var array
      */
-    public $fixtures = [
+    public array $fixtures = [
         'app.Notifications',
         'app.Developers',
         'app.Reports',
diff --git a/tests/TestCase/Model/Table/DevelopersTableTest.php b/tests/TestCase/Model/Table/DevelopersTableTest.php
@@ -28,19 +28,12 @@
  */
 class DevelopersTableTest extends TestCase
 {
-    /**
-     * Test subject
-     *
-     * @var DevelopersTable
-     */
-    public $Developers;
+    protected DevelopersTable $Developers;
 
     /**
      * Fixtures.
-     *
-     * @var array
      */
-    public $fixtures = ['app.Developers'];
+    public array $fixtures = ['app.Developers'];
 
     /**
      * setUp method
diff --git a/tests/TestCase/Model/Table/IncidentsTableTest.php b/tests/TestCase/Model/Table/IncidentsTableTest.php
@@ -16,12 +16,12 @@
 
 class IncidentsTableTest extends TestCase
 {
+    protected IncidentsTable $Incidents;
+
     /**
      * Fixtures.
-     *
-     * @var array
      */
-    public $fixtures = [
+    public array $fixtures = [
         'app.Notifications',
         'app.Developers',
         'app.Reports',
diff --git a/tests/TestCase/Model/Table/NotificationsTableTest.php b/tests/TestCase/Model/Table/NotificationsTableTest.php
@@ -2,6 +2,7 @@
 
 namespace App\Test\TestCase\Model\Table;
 
+use App\Model\Table\NotificationTable;
 use Cake\ORM\TableRegistry;
 use Cake\TestSuite\TestCase;
 
@@ -12,12 +13,12 @@
  */
 class NotificationsTableTest extends TestCase
 {
+    protected NotificationTable $Notification;
+
     /**
      * Fixtures.
-     *
-     * @var array
      */
-    public $fixtures = [
+    public array $fixtures = [
         'app.Notifications',
         'app.Developers',
         'app.Reports',
diff --git a/tests/TestCase/Model/Table/ReportsTableTest.php b/tests/TestCase/Model/Table/ReportsTableTest.php
@@ -2,6 +2,7 @@
 
 namespace App\Test\TestCase\Model\Table;
 
+use App\Model\Table\ReportsTable;
 use Cake\ORM\Query;
 use Cake\ORM\ResultSet;
 use Cake\ORM\TableRegistry;
@@ -11,12 +12,12 @@
 
 class ReportsTableTest extends TestCase
 {
+    protected ReportsTable $Reports;
+
     /**
      * Fixtures.
-     *
-     * @var array
      */
-    public $fixtures = [
+    public array $fixtures = [
         'app.Notifications',
         'app.Developers',
         'app.Reports',
diff --git a/tests/TestCase/Shell/CleanOldNotifsShellTest.php b/tests/TestCase/Shell/CleanOldNotifsShellTest.php
@@ -19,7 +19,7 @@
 namespace App\Test\TestCase\Shell;
 
 use Cake\Command\Command;
-use Cake\TestSuite\ConsoleIntegrationTestTrait;
+use Cake\Console\TestSuite\ConsoleIntegrationTestTrait;
 use Cake\TestSuite\TestCase;
 
 /**
@@ -31,10 +31,8 @@ class CleanOldNotifsShellTest extends TestCase
 
     /**
      * Fixtures.
-     *
-     * @var array
      */
-    public $fixtures = [
+    public array $fixtures = [
         'app.Notifications',
         'app.Developers',
     ];
diff --git a/tests/TestCase/Shell/StatsShellTest.php b/tests/TestCase/Shell/StatsShellTest.php
@@ -20,7 +20,7 @@
 
 use Cake\Cache\Cache;
 use Cake\Command\Command;
-use Cake\TestSuite\ConsoleIntegrationTestTrait;
+use Cake\Console\TestSuite\ConsoleIntegrationTestTrait;
 use Cake\TestSuite\TestCase;
 
 /**
diff --git a/tests/TestCase/Shell/SyncGithubIssueStatesShellTest.php b/tests/TestCase/Shell/SyncGithubIssueStatesShellTest.php
@@ -3,7 +3,7 @@
 namespace App\Test\TestCase\Shell;
 
 use Cake\Command\Command;
-use Cake\TestSuite\ConsoleIntegrationTestTrait;
+use Cake\Console\TestSuite\ConsoleIntegrationTestTrait;
 use Cake\TestSuite\TestCase;
 use phpmock\phpunit\PHPMock;
 
@@ -23,10 +23,8 @@ class SyncGithubIssueStatesShellTest extends TestCase
 
     /**
      * Fixtures.
-     *
-     * @var array
      */
-    public $fixtures = ['app.Reports', 'app.Developers', 'app.Notifications'];
+    public array $fixtures = ['app.Reports', 'app.Developers', 'app.Notifications'];
 
     public function setUp(): void
     {
diff --git a/tests/TestCase/View/Helper/ReportsHelperTest.php b/tests/TestCase/View/Helper/ReportsHelperTest.php
@@ -2,12 +2,15 @@
 
 namespace App\Test\TestCase\View\Helper;
 
+use App\Model\Table\ReportsTable;
 use App\View\Helper\ReportsHelper;
 use Cake\TestSuite\TestCase;
 use Cake\View\View;
 
 class ReportsHelperTest extends TestCase
 {
+    protected ReportsTable $Reports;
+
     public function setUp(): void
     {
         parent::setUp();
diff --git a/tests/bootstrap.php b/tests/bootstrap.php
