Improve uses of cURL

Author: williamdes

src/Controller/Component/GithubApiComponent.php

@@ -25,6 +25,8 @@
 
 use function array_merge;
 use function curl_error;
+use function curl_exec;
+use function curl_getinfo;
 use function curl_init;
 use function curl_setopt;
 use function http_build_query;
@@ -155,15 +157,14 @@ public function sendRequest(
         curl_setopt($curlHandle, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_1_1);
         curl_setopt($curlHandle, CURLOPT_FOLLOWLOCATION, 1);// Issues moved to another repo have redirects
         curl_setopt($curlHandle, CURLOPT_RETURNTRANSFER, 1);
-        $response = curl_exec($curlHandle);// phpcs:ignore SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly.ReferenceViaFallbackGlobalName
+        $response = curl_exec($curlHandle);
         if ($response === false) {
             Log::error('Curl error: "' . curl_error($curlHandle) . '" for: ' . $url);
 
             return ['', 0];
         }
 
-        $status = curl_getinfo($curlHandle, CURLINFO_HTTP_CODE);// phpcs:ignore SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly.ReferenceViaFallbackGlobalName
-        // phpcs ignored patterns for mock testing reasons
+        $status = curl_getinfo($curlHandle, CURLINFO_HTTP_CODE);
         Log::debug('Response-code: ' . $status . ' for: ' . $url);
 
         $decodedResponse = json_decode($response, true);

src/Forwarding/Sentry.php

@@ -10,6 +10,7 @@
 
 use function curl_errno;
 use function curl_exec;
+use function curl_getinfo;
 use function curl_init;
 use function curl_setopt;
 use function curl_strerror;
@@ -22,6 +23,7 @@
 use function json_encode;
 use function time;
 
+use const CURLINFO_HTTP_CODE;
 use const CURLOPT_CAINFO;
 use const CURLOPT_CAPATH;
 use const CURLOPT_HTTPHEADER;
@@ -154,6 +156,9 @@ public static function sendFeedback(string $eventId, string $comments, string $u
         curl_setopt($ch, CURLOPT_POSTFIELDS, http_build_query($data));
 
         $output = curl_exec($ch);
+        $status = curl_getinfo($ch, CURLINFO_HTTP_CODE);
+        Log::debug('Response-code: ' . $status);
+
         if (! is_string($output)) {
             $error = 'Creating the report feedback failed: ' . json_encode($output);
             Log::error($error);