Use iterator when using the tagged service shortcut

Author: veewee

src/Transformer/Chain.php

@@ -12,11 +12,13 @@ class Chain implements ExceptionTransformerInterface
     /**
      * @var ExceptionTransformerInterface[]
      */
-    private $transformers;
+    private $transformers = [];
 
-    public function __construct(ExceptionTransformerInterface ...$transformers)
+    public function __construct(iterable $transformers)
     {
-        $this->transformers = $transformers;
+        foreach ($transformers as $transformer) {
+            $this->addTransformer($transformer);
+        }
     }
 
     public function transform(\Throwable $exception): ApiProblemInterface
@@ -34,4 +36,9 @@ public function accepts(\Throwable $exception): bool
     {
         return true;
     }
+
+    private function addTransformer(ExceptionTransformerInterface $transformer): void
+    {
+        $this->transformers[] = $transformer;
+    }
 }

test/Transformer/ChainTest.php

@@ -20,33 +20,33 @@ class ChainTest extends TestCase
     /** @test */
     public function it_is_an_exception_transformer(): void
     {
-        $transformer = new Chain();
+        $transformer = new Chain([]);
         $this->assertInstanceOf(ExceptionTransformerInterface::class, $transformer);
     }
 
     /** @test */
     public function it_accepts_any_exception(): void
     {
-        $transformer = new Chain();
+        $transformer = new Chain([]);
         $this->assertTrue($transformer->accepts(new \Exception()));
     }
 
     /** @test */
     public function it_transforms_with_first_acceptable_transformer(): void
     {
-        $transformer = new Chain(
+        $transformer = new Chain([
             $this->mockTransformer(false),
             $this->mockTransformer(true, $apiProblem1 = $this->prophesize(ApiProblemInterface::class)->reveal()),
-            $this->mockTransformer(true, $apiProblem2 = $this->prophesize(ApiProblemInterface::class)->reveal())
-        );
+            $this->mockTransformer(true, $apiProblem2 = $this->prophesize(ApiProblemInterface::class)->reveal()),
+        ]);
 
         $this->assertEquals($apiProblem1, $transformer->transform(new \Exception()));
     }
 
     /** @test */
     public function it_transforms_to_basic_exception_problem_when_no_transformer_matches(): void
     {
-        $transformer = new Chain($this->mockTransformer(false));
+        $transformer = new Chain([$this->mockTransformer(false)]);
 
         $this->assertInstanceOf(ExceptionApiProblem::class, $transformer->transform(new \Exception()));
     }