Modified implementation since monolog excluded_http_codes depends on the HttpException class, not interface

Author: tjveldhuizen

src/Exception/ApiProblemHttpException.php

@@ -4,15 +4,32 @@
 
 namespace Phpro\ApiProblemBundle\Exception;
 
-use Phpro\ApiProblem\Exception\ApiProblemException;
+use Phpro\ApiProblem\ApiProblemInterface;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\HttpKernel\Exception\HttpExceptionInterface;
+use Symfony\Component\HttpKernel\Exception\HttpException;
 
-class ApiProblemHttpException extends ApiProblemException implements HttpExceptionInterface
+class ApiProblemHttpException extends HttpException
 {
+    private $apiProblem;
+
+    public function __construct(ApiProblemInterface $apiProblem)
+    {
+        $data = $apiProblem->toArray();
+        $message = $data['detail'] ?? ($data['title'] ?? '');
+        $code = (int) ($data['status'] ?? 0);
+
+        parent::__construct($code, $message);
+        $this->apiProblem = $apiProblem;
+    }
+
+    public function getApiProblem(): ApiProblemInterface
+    {
+        return $this->apiProblem;
+    }
+
     public function getStatusCode()
     {
-        return $this->code > 0 ? $this->code : Response::HTTP_BAD_REQUEST;
+        return parent::getStatusCode() > 0 ? parent::getStatusCode() : Response::HTTP_BAD_REQUEST;
     }
 
     public function getHeaders()

src/Transformer/ApiProblemExceptionTransformer.php

@@ -6,11 +6,12 @@
 
 use Phpro\ApiProblem\ApiProblemInterface;
 use Phpro\ApiProblem\Exception\ApiProblemException;
+use Phpro\ApiProblemBundle\Exception\ApiProblemHttpException;
 
 class ApiProblemExceptionTransformer implements ExceptionTransformerInterface
 {
     /**
-     * @param ApiProblemException $exception
+     * @param ApiProblemException|ApiProblemHttpException $exception
      */
     public function transform(\Throwable $exception): ApiProblemInterface
     {
@@ -19,6 +20,6 @@ public function transform(\Throwable $exception): ApiProblemInterface
 
     public function accepts(\Throwable $exception): bool
     {
-        return $exception instanceof ApiProblemException;
+        return $exception instanceof ApiProblemException || $exception instanceof ApiProblemHttpException;
     }
 }

test/Exception/ApiProblemHttpExceptionTest.php

@@ -4,12 +4,12 @@
 
 namespace PhproTest\ApiProblemBundle\Exception;
 
-use Phpro\ApiProblem\Exception\ApiProblemException;
 use Phpro\ApiProblem\Http\HttpApiProblem;
 use Phpro\ApiProblemBundle\Exception\ApiProblemHttpException;
+use Phpro\ApiProblemBundle\Transformer\ApiProblemExceptionTransformer;
 use PHPUnit\Framework\TestCase;
 use Prophecy\Prophecy\ObjectProphecy;
-use Symfony\Component\HttpKernel\Exception\HttpExceptionInterface;
+use Symfony\Component\HttpKernel\Exception\HttpException;
 
 class ApiProblemHttpExceptionTest extends TestCase
 {
@@ -25,19 +25,28 @@ protected function setUp(): void/* The :void return type declaration that should
     }
 
     /** @test */
-    public function it_is_an_instance_of_ApiProblemException(): void
+    public function it_is_accepted_by_the_ApiProblemExceptionTransformer(): void
     {
-        $exception = new ApiProblemHttpException($this->apiProblem->reveal());
+        $transformer = new ApiProblemExceptionTransformer();
 
-        $this->assertInstanceOf(ApiProblemException::class, $exception);
+        $this->assertTrue($transformer->accepts(new ApiProblemHttpException($this->apiProblem->reveal())));
     }
 
     /** @test */
     public function it_is_an_instance_of_HttpException(): void
     {
         $exception = new ApiProblemHttpException($this->apiProblem->reveal());
 
-        $this->assertInstanceOf(HttpExceptionInterface::class, $exception);
+        $this->assertInstanceOf(HttpException::class, $exception);
+    }
+
+    /** @test */
+    public function it_contains_an_api_problem(): void
+    {
+        $apiProblem = $this->apiProblem->reveal();
+
+        $exception = new ApiProblemHttpException($apiProblem);
+        $this->assertEquals($apiProblem, $exception->getApiProblem());
     }
 
     /** @test */