Merge pull request #184 from chrisgo/master

Closes #140, add ability to set region for S3 uploads

Author: spruce

README.md

@@ -42,7 +42,7 @@ The user must be a member of the project you want to copy. This user must be the
 
 ### Docker
 
-If you don't have Node.js installed in your local environment and don't want to install it you can use the Dockerized approach. 
+If you don't have Node.js installed in your local environment and don't want to install it you can use the Dockerized approach.
 
 1. Make sure that you have [Docker](https://docs.docker.com/engine/install/) installed in your computer. You can test running `docker version` in the terminal.
 1. `cp sample_settings.ts settings.ts`
@@ -144,6 +144,10 @@ IAM User who owns these credential must have [write permissions](https://docs.aw
 
 Existing bucket, with an appropriate security policy. One possible policy is to allow [public access](https://docs.aws.amazon.com/AmazonS3/latest/dev/WebsiteAccessPermissionsReqd.html).
 
+#### s3.region
+
+Specify Region (example: us-west-1) of bucket [list of regions](https://docs.aws.amazon.com/general/latest/gr/s3.html)
+
 ### usermap
 
 Maps the usernames from gitlab to github. If the assinee of the gitlab issue is equal to the one currently logged in github it will also get assigned without a usermap. The Mentions in issues will also be translated to the new github name.

sample_settings.ts

@@ -22,6 +22,7 @@ export default {
     accessKeyId: '{{accessKeyId}}',
     secretAccessKey: '{{secretAccessKey}}',
     bucket: 'my-gitlab-bucket',
+    region: null,
   },
   usermap: {
     'username.gitlab.1': 'username.github.1',

src/settings.ts

@@ -60,4 +60,5 @@ export interface S3Settings {
   accessKeyId: string;
   secretAccessKey: string;
   bucket: string;
+  region: string;
 }

src/utils.ts

@@ -49,7 +49,13 @@ export const migrateAttachments = async (
       // Doesn't seem like it is easy to upload an issue to github, so upload to S3
       //https://stackoverflow.com/questions/41581151/how-to-upload-an-image-to-use-in-issue-comments-via-github-api
 
-      const s3url = `https://${s3.bucket}.s3.amazonaws.com/${relativePath}`;
+      // Attempt to fix issue #140
+      //const s3url = `https://${s3.bucket}.s3.amazonaws.com/${relativePath}`;
+      let hostname = `${s3.bucket}.s3.amazonaws.com`;
+      if (s3.region) {
+        hostname = `s3.${s3.region}.amazonaws.com/${s3.bucket}`;
+      }
+      const s3url = `https://${hostname}/${relativePath}`;
 
       const s3bucket = new S3();
       s3bucket.createBucket(() => {