Skip to content

Commit 33b8f36

Browse files
committed
Fix handling of missing milestones in map
1 parent a91a4a3 commit 33b8f36

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

src/githubHelper.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1192,10 +1192,7 @@ export class GithubHelper {
11921192
let milestone: SimpleMilestone;
11931193
if (this.milestoneMap) {
11941194
if (number) {
1195-
milestone = this.milestoneMap.get(parseInt(number)) ?? {
1196-
number: parseInt(number),
1197-
title: `GitHub milestone ${number} not in map`,
1198-
};
1195+
milestone = this.milestoneMap.get(parseInt(number));
11991196
} else if (title) {
12001197
for (let m of this.milestoneMap.values()) {
12011198
if (m.title === title) {
@@ -1214,7 +1211,7 @@ export class GithubHelper {
12141211
console.log(
12151212
`\tERROR: Milestone ${number}, "${title}" not found among migrated milestones.`
12161213
);
1217-
return number || title || 'No milestone'; // milestone numbers are always > 0
1214+
return `'Reference to deleted milestone ${number || title}'`;
12181215
};
12191216

12201217
if (hasProjectmap) {

0 commit comments

Comments
 (0)