Skip to content

Commit 09a4419

Browse files
committed
make total_visitors an official metric
1 parent 957e92a commit 09a4419

2 files changed

Lines changed: 14 additions & 0 deletions

File tree

lib/plausible/stats/metrics.ex

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ defmodule Plausible.Stats.Metrics do
1717
:visit_duration,
1818
:events,
1919
:conversion_rate,
20+
:total_visitors,
2021
:group_conversion_rate,
2122
:time_on_page,
2223
:percentage,

test/plausible/stats/query/query_parse_and_build_test.exs

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,19 @@ defmodule Plausible.Stats.Query.QueryParseAndBuildTest do
8888
assert error =~ "Invalid metric"
8989
end
9090

91+
test "public API does not recognize total_visitors metric", %{site: site} do
92+
params = %{
93+
"site_id" => site.domain,
94+
"metrics" => ["total_visitors"],
95+
"date_range" => "all"
96+
}
97+
98+
assert {:error, %QueryError{message: error}} =
99+
Query.parse_and_build(site, params, now: @now)
100+
101+
assert error =~ "Invalid metric"
102+
end
103+
91104
test "valid metrics passed", %{site: site} do
92105
params = %{
93106
"site_id" => site.domain,

0 commit comments

Comments
 (0)