split watch_plotly into module and run-script

Author: etpinard

devtools/test_dashboard/server.js

@@ -6,7 +6,7 @@ var browserify = require('browserify');
 var ecstatic = require('ecstatic');
 var _open = require('open');
 
-var makeWatchifiedBundle = require('../../tasks/watch_plotly');
+var makeWatchifiedBundle = require('../../tasks/util/make_watchified_bundle');
 var shortcutPaths = require('../../tasks/util/shortcut_paths');
 var constants = require('../../tasks/util/constants');
 

tasks/util/make_watchified_bundle.js

@@ -0,0 +1,54 @@
+var fs = require('fs');
+
+var browserify = require('browserify');
+var watchify = require('watchify');
+
+var compressAttributes = require('./compress_attributes');
+var formatBundleMsg = require('./format_bundle_msg');
+var constants = require('./constants');
+
+/**
+ * Make a plotly.js browserify bundle function watched by watchify.
+ *
+ * @param {function} onFirstBundleCallback executed when first bundle is completed
+ *
+ */
+module.exports = function makeWatchifiedBundle(onFirstBundleCallback) {
+    var b = browserify(constants.pathToPlotlySrc, {
+        debug: true,
+        standalone: 'Plotly',
+        transform: [compressAttributes],
+        cache: {},
+        packageCache: {},
+        plugin: [watchify]
+    });
+
+    var firstBundle = true;
+
+    if(firstBundle) {
+        console.log([
+            '***',
+            'Building the first bundle, this should take ~10 seconds',
+            '***\n'
+        ].join(' '));
+    }
+
+    b.on('update', bundle);
+    formatBundleMsg(b, 'plotly.js');
+
+    function bundle() {
+        b.bundle(function(err) {
+            if(err) console.error(JSON.stringify(String(err)));
+
+            if(firstBundle) {
+                onFirstBundleCallback();
+                firstBundle = false;
+            }
+        })
+        .pipe(
+            fs.createWriteStream(constants.pathToPlotlyDist)
+        );
+    }
+
+    return bundle;
+};

tasks/watch_plotly.js

@@ -1,63 +1,5 @@
-var fs = require('fs');
+var makeWatchifiedBundle = require('./util/make_watchified_bundle');
 
-var browserify = require('browserify');
-var watchify = require('watchify');
-
-var compressAttributes = require('./util/compress_attributes');
-var formatBundleMsg = require('./util/format_bundle_msg');
-var constants = require('./util/constants');
-
-/**
- * Make a browserify bundle function watched by watchify.
- *
- * @param {function} onFirstBundleCallback executed when first bundle is completed
- *
- */
-function makeWatchifiedBundle(onFirstBundleCallback) {
-    var b = browserify(constants.pathToPlotlySrc, {
-        debug: true,
-        standalone: 'Plotly',
-        transform: [compressAttributes],
-        cache: {},
-        packageCache: {},
-        plugin: [watchify]
-    });
-
-    var firstBundle = true;
-
-    if(firstBundle) {
-        console.log([
-            '***',
-            'Building the first bundle, this should take ~10 seconds',
-            '***\n'
-        ].join(' '));
-    }
-
-    b.on('update', bundle);
-    formatBundleMsg(b, 'plotly.js');
-
-    function bundle() {
-        b.bundle(function(err) {
-            if(err) console.error(JSON.stringify(String(err)));
-
-            if(firstBundle) {
-                onFirstBundleCallback();
-                firstBundle = false;
-            }
-        })
-        .pipe(
-            fs.createWriteStream(constants.pathToPlotlyDist)
-        );
-    }
-
-    return bundle;
-}
-
-// call watchifiedBundle if ran in CLI
-if(process.argv[1] === __filename) {
-    var watchifiedBundle = makeWatchifiedBundle(function() {});
-    watchifiedBundle();
-}
-
-// export if required in
-module.exports = makeWatchifiedBundle;
+// make watchified bundle and run it!
+var watchifiedBundle = makeWatchifiedBundle(function() {});
+watchifiedBundle();