fix(group): add missing group column to model mapping (#585)

* fix(group): add missing group column to model mapping

* Update CHANGELOG.md

* review

* review

---------

Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>

Author: MyvTsv

CHANGELOG.md

@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 - Fix model subform not displayed after page reload
 - Rename visibility field label to "Is Private"
+- Restored group selection in mappings
 - Fix special caracters malformed in translations
 
 ## [2.15.3] - 2025-12-22

inc/commoninjectionlib.class.php

@@ -1673,14 +1673,14 @@ private function effectiveAddOrUpdate($injectionClass, $item, $values, $add = tr
 
             // handle new format for group type specification
             // restricting to group_item relations only
-            if (($key === "groups_id_tech" || $key === "groups_id") && $option['table'] == getTableForItemType(Group::class) && !empty($option) && isset($option['joinparams']['beforejoin']['table']) && $option['joinparams']['beforejoin']['table'] === getTableForItemType(Group_Item::class) && isset($option['joinparams']['beforejoin']['joinparams']['condition']['NEWTABLE.type'])) {
-                $value = $option['joinparams']['beforejoin']['joinparams']['condition']['NEWTABLE.type'];
+            if (($key === "groups_id_tech" || $key === "groups_id" || $key === "groups_id_normal") && $option['table'] == getTableForItemType(Group::class) && !empty($option) && isset($option['joinparams']['beforejoin']['table']) && $option['joinparams']['beforejoin']['table'] === getTableForItemType(Group_Item::class) && isset($option['joinparams']['beforejoin']['joinparams']['condition']['NEWTABLE.type'])) {
+                $group_type = $option['joinparams']['beforejoin']['joinparams']['condition']['NEWTABLE.type'];
                 // depending on the type, set the correct field (_groups_id_tech => array or _groups_id => array)
-                // and unset the old one (groups_id_tech => int or groups_id => int)
-                if ($value == Group_Item::GROUP_TYPE_TECH) {
+                // and unset the old one (groups_id_tech => int or groups_id => int or groups_id_normal => int)
+                if ($group_type == Group_Item::GROUP_TYPE_TECH) {
                     $toinject["_groups_id_tech"] = [$value];
                 } else {
-                    $toinject["_groups"] = [$value];
+                    $toinject["_groups_id"] = [$value];
                 }
                 unset($toinject[$key]);
             }

inc/computerinjection.class.php

@@ -71,6 +71,9 @@ public function getOptions($primary_type = '')
         //Specific to location
         $tab[3]['linkfield'] = 'locations_id';
 
+        //Specific to groups (simple group, not technical)
+        $tab[71]['linkfield'] = 'groups_id_normal';
+
         //specific for antiviruses
         $tab[167]['name'] = __('Antivirus name', 'datainjection');