Changed display conditions

I was trying to solve issue with display conditions when using simple
view in ticket menu

The issue was that when you add a container, field to it, and then
create display condition, the condition will not work as expected in
simple view of ticket creation. The condition will never be satisfied
and your field will always stay visible, no matter what condition you
created

Turned out, GLPI_POST_ITEM HOOK send item parameter without 'type' and
'itilcategory_id', those fields were contained in options parameter.

This is small work around, works fine for my use case

Author: akstis-typer

inc/containerdisplaycondition.class.php

@@ -406,16 +406,19 @@ public function computeDisplayContainer($item, $container_id)
 
         if (count($found_dc)) {
             $display = true;
+
             foreach ($found_dc as $data) {
                 $displayCondition->getFromDB($data['id']);
                 $result = $displayCondition->checkCondition($item);
+
                 if (!$result) {
                     return $result;
                 }
             }
 
             return $display;
         } else {
+	    Toolbox::logInFile("FIELDS_LOG","no condition found -> display container");
             //no condition found -> display container
             return true;
         }
@@ -425,10 +428,13 @@ public function checkCondition($item)
     {
         $value        = $this->fields['value'];
         $condition    = $this->fields['condition'];
-        $searchOption = Search::getOptions(get_class($item))[$this->fields['search_option']];
+
+  	$searchOption = Search::getOptions(get_class($item))[$this->fields['search_option']];
 
         $fields = array_merge($item->fields, $item->input);
 
+	Toolbox::logInFile("FIELDS_LOG", " [ WE NEED TO CHECK {$value} ({$condition}) {$fields[$searchOption['linkfield']]} ] ");
+
         switch ($condition) {
             case self::SHOW_CONDITION_EQ:
                 // '='

inc/field.class.php

@@ -886,6 +886,18 @@ public static function showDomContainer($id, $item, $type = 'dom', $subtype = ''
     public static function showForTab($params)
     {
         $item = $params['item'];
+//	var_dump($item);
+	if($item->fields['type'] == "")
+	{
+	    $item->fields['type'] = $params['options']['type'];
+	}
+	if($item->fields['itilcategories_id'] == "")
+        {
+            $item->fields['itilcategories_id'] = $params['options']['itilcategories_id'];
+        }
+//	var_dump($item->fields);
+//	var_dump($params);
+	Toolbox::logInFile("FIELDS_LOG", "[ Recieved parameters got item type ({$item->fields['type']}) ] ");
 
         $functions = array_column(debug_backtrace(), 'function');
         $subtype   = isset($_SESSION['glpi_tabs'][strtolower($item::getType())]) ? $_SESSION['glpi_tabs'][strtolower($item::getType())] : '';
@@ -956,7 +968,7 @@ public static function showForTab($params)
         }
 
         $html_id = 'plugin_fields_container_' . mt_rand();
-        if (strpos($current_url, 'helpdesk.public.php') !== false) {
+        if (strpos($current_url, 'helpdesk.public.php') !== false || strpos($current_url, 'tracking.injector.php') !== false) {
             echo "<div id='{$html_id}' class='card-body row mx-0' style='border-top:0'>";
             echo "<div class='offset-md-1 col-md-8 col-xxl-6'>";
             $field_options = [
@@ -967,7 +979,12 @@ public static function showForTab($params)
             echo "<div id='{$html_id}'>";
         }
         $display_condition = new PluginFieldsContainerDisplayCondition();
-        if ($display_condition->computeDisplayContainer($item, $c_id)) {
+
+	Toolbox::logInFile("FIELDS_LOG", "[ Item with Container ID {$c_id} and type ({$item->fields['type']}) ] ");
+
+        if ($display_condition->computeDisplayContainer($item, $c_id))
+	{
+	    Toolbox::logInFile("FIELDS_LOG", " [ WE COMPUTED THAT WE NEED TO SHOW CONTAINER OAOAOOA ] ");
             self::showDomContainer(
                 $c_id,
                 $item,
@@ -976,14 +993,20 @@ public static function showForTab($params)
                 $field_options ?? [],
             );
         }
-        if (strpos($current_url, 'helpdesk.public.php') !== false) {
+	else
+	{
+            Toolbox::logInFile("FIELDS_LOG", " [ NO NEED TO SHOW CONTAINER AAAAAARGHHHHHH ] ");
+	}
+        if (strpos($current_url, 'helpdesk.public.php') !== false || strpos($current_url, 'tracking.injector.php') !== false) {
             echo '</div>';
         }
         echo '</div>';
 
         //JS to trigger any change and check if container need to be display or not
         $ajax_url = Plugin::getWebDir('fields') . '/ajax/container.php';
         $items_id = !$item->isNewItem() ? $item->getID() : 0;
+
+
         echo Html::scriptBlock(
             <<<JAVASCRIPT
             function refreshContainer() {