Skip to content

Commit f01f6ec

Browse files
pcn-router: test updated with the new notation
(from netmask to prefix len) Signed-off-by: Francesco Messina <francescomessina92@hotmail.com>
1 parent 6f2f01f commit f01f6ec

8 files changed

Lines changed: 54 additions & 56 deletions

File tree

src/services/pcn-router/test/bridge/test2_2_4.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ polycubectl router add r2 type=$TYPE
4444
polycubectl simplebridge add br1 type=$TYPE
4545
polycubectl simplebridge add br2 type=$TYPE
4646

47-
router_add_port r1 to_br1 10.10.2.1 255.255.255.0
47+
router_add_port r1 to_br1 10.10.2.1/24
4848

4949
bridge_add_port br1 veth1
5050
bridge_add_port br1 veth2
@@ -57,9 +57,9 @@ bridge_add_port br2 veth4
5757

5858
router_add_port_as_gateway r2 br2 2 br2
5959

60-
router_add_route r1 10.0.2.0 255.255.255.0 10.1.0.2
61-
router_add_route r2 10.0.1.0 255.255.255.0 10.1.0.1
62-
router_add_route r2 10.10.2.1 255.255.255.255 10.1.0.1
60+
router_add_route r1 10.0.2.0/24 10.1.0.2
61+
router_add_route r2 10.0.1.0/24 10.1.0.1
62+
router_add_route r2 10.10.2.1/32 10.1.0.1
6363

6464
#sleep 40s #for fill filtering database
6565

src/services/pcn-router/test/bridge/test2_2_4_special.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,16 +46,16 @@ bridge_add_port br1 veth2
4646

4747
polycubectl simplebridge br1 ports add to_r2
4848
router_add_port_as_gateway r2 br2 2 br2
49-
router_add_port r2 to_br1 10.0.1.253 255.255.255.0
49+
router_add_port r2 to_br1 10.0.1.253/24
5050

5151
bridge_add_port br2 veth3
5252
bridge_add_port br2 veth4
5353

5454
polycubectl connect br1:to_r2 r2:to_br1
5555

56-
router_add_route r1 10.0.2.0 255.255.255.0 10.0.1.253
56+
router_add_route r1 10.0.2.0/24 10.0.1.253
5757

58-
router_add_route r2 10.0.1.0 255.255.255.0 10.0.1.254 #ignored, local entry is preferred
58+
router_add_route r2 10.0.1.0/24 10.0.1.254 #ignored, local entry is preferred
5959

6060
sudo ip netns exec ns1 ping 10.0.1.2 -c 2 -i 0.5
6161
sudo ip netns exec ns1 ping 10.0.2.1 -c 2 -i 0.5

src/services/pcn-router/test/bridge/test2_2_5.sh

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -38,37 +38,37 @@ add_routers 2
3838
add_bridges 2
3939

4040
router_add_port_as_gateway r1 br1 1 br1
41-
router_add_secondary r1 br1 10.0.2.254 255.255.255.0 #DG for veth2
41+
router_add_secondary r1 br1 10.0.2.254/24 #DG for veth2
4242

4343
connect_router_p_to_p r1 r2 1
44-
router_add_secondary r1 r2 10.10.0.1 255.255.255.252
45-
router_add_secondary r2 r1 10.10.0.2 255.255.255.252 #secondary nexthop
44+
router_add_secondary r1 r2 10.10.0.1/30
45+
router_add_secondary r2 r1 10.10.0.2/30 #secondary nexthop
4646

4747
bridge_add_port br1 veth1
4848
bridge_add_port br1 veth2
4949

5050
router_add_port_as_gateway r2 br2 3 br2
51-
router_add_secondary r2 br2 10.0.4.254 255.255.255.0 #DG for veth4
52-
router_add_secondary r2 br2 10.0.5.254 255.255.255.0 #DG for veth5
51+
router_add_secondary r2 br2 10.0.4.254/24 #DG for veth4
52+
router_add_secondary r2 br2 10.0.5.254/24 #DG for veth5
5353

5454
bridge_add_port br2 veth3
5555
bridge_add_port br2 veth4
5656
bridge_add_port br2 veth5
5757

58-
router_add_route r1 10.0.3.0 255.255.255.0 10.1.0.2 5
59-
router_add_route r1 10.0.4.0 255.255.255.0 10.1.0.2 5
60-
router_add_route r1 10.0.5.0 255.255.255.0 10.1.0.2 5
58+
router_add_route r1 10.0.3.0/24 10.1.0.2 5
59+
router_add_route r1 10.0.4.0/24 10.1.0.2 5
60+
router_add_route r1 10.0.5.0/24 10.1.0.2 5
6161

62-
router_add_route r2 10.0.1.0 255.255.255.0 10.1.0.1 5
63-
router_add_route r2 10.0.2.0 255.255.255.0 10.1.0.1 5
62+
router_add_route r2 10.0.1.0/24 10.1.0.1 5
63+
router_add_route r2 10.0.2.0/24 10.1.0.1 5
6464

6565
#minor patchost
66-
router_add_route r1 10.0.3.0 255.255.255.0 10.10.0.2 2
66+
router_add_route r1 10.0.3.0/24 10.10.0.2 2
6767

6868
ping_cycle 5
6969
ping_special 5 10.10.0.1 10.10.0.2
7070

71-
polycubectl router r1 ports to_r2 secondaryip del 10.10.0.1 255.255.255.252
71+
polycubectl router r1 ports to_r2 secondaryip del 10.10.0.1/30
7272

7373
ping_cycle 5
7474

src/services/pcn-router/test/helpers.bash

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ function del_routers {
2727
}
2828

2929
function router_add_port_as_gateway { #$3 network number #$4 bridge name
30-
polycubectl router $1 ports add to_$2 ip=10.0.$3.254 netmask=255.255.255.0
30+
polycubectl router $1 ports add to_$2 ip=10.0.$3.254/24
3131
if [[ $# -eq 4 ]] ; then
3232
polycubectl simplebridge $4 ports add to_$1
3333
polycubectl connect $4:to_$1 $1:to_$4
@@ -38,30 +38,30 @@ function router_add_port_as_gateway { #$3 network number #$4 bridge name
3838

3939
}
4040

41-
function router_add_port { #$3 ip $4 netmask
42-
polycubectl router $1 ports add $2 ip=$3 netmask=$4
41+
function router_add_port { #$3 ip
42+
polycubectl router $1 ports add $2 ip=$3
4343
}
4444

4545
function connect_router_p_to_p { #$1 router name 1, $2 router name 2, $3 network point to point connection
46-
polycubectl router $1 ports add to_$2 ip=10.$3.0.1 netmask=255.255.255.252
47-
polycubectl router $2 ports add to_$1 ip=10.$3.0.2 netmask=255.255.255.252
46+
polycubectl router $1 ports add to_$2 ip=10.$3.0.1/30
47+
polycubectl router $2 ports add to_$1 ip=10.$3.0.2/30
4848
polycubectl connect $1:to_$2 $2:to_$1
4949
}
5050

5151
function connect_router_secondary_p_to_p { #$1 router name 1, $2 router name 2, $3 network point to point connection
52-
polycubectl router $1 ports to_$2 secondaryip add 10.$3.0.1 255.255.255.252
53-
polycubectl router $2 ports to_$1 secondaryip add 10.$3.0.2 255.255.255.252
52+
polycubectl router $1 ports to_$2 secondaryip add 10.$3.0.1/30
53+
polycubectl router $2 ports to_$1 secondaryip add 10.$3.0.2/30
5454
polycubectl connect $1:to_$2 $2:to_$1
5555
}
5656

5757

5858

5959
function router_add_secondary {
60-
polycubectl router $1 ports to_$2 secondaryip add $3 $4
60+
polycubectl router $1 ports to_$2 secondaryip add $3
6161
}
6262

6363
function router_add_secondary_as_gateway {
64-
polycubectl router $1 ports to_$2 secondaryip add 10.0.$3.254 255.255.255.0
64+
polycubectl router $1 ports to_$2 secondaryip add 10.0.$3.254/24
6565
if [[ $# -eq 4 ]] ; then
6666
polycubectl simplebridge $4 ports add to_$1
6767
polycubectl connect $4:to_$1 $1:to_$4
@@ -72,10 +72,10 @@ polycubectl router $1 ports to_$2 secondaryip add 10.0.$3.254 255.255.255.0
7272

7373
function router_add_route {
7474

75-
if [[ $# -eq 5 ]] ; then
76-
polycubectl router $1 route add $2 $3 $4 pathcost=$5
75+
if [[ $# -eq 4 ]] ; then
76+
polycubectl router $1 route add $2 $3 pathcost=$4
7777
else
78-
polycubectl router $1 route add $2 $3 $4
78+
polycubectl router $1 route add $2 $3
7979
fi
8080

8181
}

src/services/pcn-router/test/test1_3s.sh

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -41,23 +41,23 @@ set -e
4141
add_routers 1
4242

4343
# Creates three ports on the router, each one attached to a different namespace
44-
router_add_port r1 to_veth1 10.0.0.120 255.255.255.0
45-
router_add_port r1 to_veth2 10.10.20.10 255.255.255.0
46-
router_add_port r1 to_veth3 10.30.10.10 255.255.255.0
44+
router_add_port r1 to_veth1 10.0.0.120/24
45+
router_add_port r1 to_veth2 10.10.20.10/24
46+
router_add_port r1 to_veth3 10.30.10.10/24
4747

4848
# Configure secondary addresses on port veth1
49-
router_add_secondary r1 veth1 10.10.10.1 255.255.255.0
50-
router_add_secondary r1 veth1 10.10.21.2 255.255.255.0
49+
router_add_secondary r1 veth1 10.10.10.1/24
50+
router_add_secondary r1 veth1 10.10.21.2/24
5151
router_add_secondary_as_gateway r1 veth1 1
5252

5353
# Configure secondary addresses on port veth2
54-
router_add_secondary r1 veth2 10.14.1.1 255.255.255.0
55-
router_add_secondary r1 veth2 10.1.15.2 255.255.255.0
54+
router_add_secondary r1 veth2 10.14.1.1/24
55+
router_add_secondary r1 veth2 10.1.15.2/24
5656
router_add_secondary_as_gateway r1 veth2 2
5757

5858
# Configure secondary addresses on port veth3
59-
router_add_secondary r1 veth3 11.1.1.1 255.255.255.0
60-
router_add_secondary r1 veth3 12.1.1.1 255.255.255.0
59+
router_add_secondary r1 veth3 11.1.1.1/24
60+
router_add_secondary r1 veth3 12.1.1.1/24
6161
router_add_secondary_as_gateway r1 veth3 3
6262

6363
#ns1 on port veth1

src/services/pcn-router/test/test3_3s.sh

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -43,29 +43,29 @@ polycubectl router add r3 type=$TYPE
4343

4444
router_add_port_as_gateway r1 veth1 1
4545

46-
router_add_port r1 to_r2 10.10.10.10 255.255.255.0
47-
router_add_port r2 to_r1 10.10.20.10 255.255.255.0
46+
router_add_port r1 to_r2 10.10.10.10/24
47+
router_add_port r2 to_r1 10.10.20.10/24
4848
connect_router_secondary_p_to_p r1 r2 1
4949

50-
router_add_port r2 to_veth2 12.10.1.1 255.255.255.0
50+
router_add_port r2 to_veth2 12.10.1.1/24
5151
router_add_secondary_as_gateway r2 veth2 2
5252

5353
connect_router_p_to_p r1 r3 2
5454
connect_router_p_to_p r2 r3 3
5555

5656
router_add_port_as_gateway r3 veth3 3
5757

58-
#router_add_route r1 10.0.2.0 255.255.255.0 10.1.0.2
59-
#router_add_route r1 10.0.3.0 255.255.255.0 10.2.0.2
60-
router_add_route r1 0.0.0.0 0.0.0.0 10.1.0.2
58+
#router_add_route r1 10.0.2.0/24 10.1.0.2
59+
#router_add_route r1 10.0.3.0/24 10.2.0.2
60+
router_add_route r1 0.0.0.0/0 10.1.0.2
6161

62-
router_add_route r2 10.0.1.0 255.255.255.0 10.1.0.1
63-
router_add_route r2 10.0.3.0 255.255.255.0 10.3.0.2
62+
router_add_route r2 10.0.1.0/24 10.1.0.1
63+
router_add_route r2 10.0.3.0/24 10.3.0.2
6464

65-
router_add_route r3 10.0.1.0 255.255.255.0 10.2.0.1
66-
router_add_route r3 10.0.2.0 255.255.255.0 10.3.0.1
67-
router_add_route r3 10.10.10.10 255.255.255.255 10.2.0.1
68-
router_add_route r3 10.10.20.10 255.255.255.255 10.3.0.1
65+
router_add_route r3 10.0.1.0/24 10.2.0.1
66+
router_add_route r3 10.0.2.0/24 10.3.0.1
67+
router_add_route r3 10.10.10.10/32 10.2.0.1
68+
router_add_route r3 10.10.20.10/32 10.3.0.1
6969

7070
router_routingtable_show r1
7171
router_routingtable_show r2
@@ -78,5 +78,3 @@ ping_cycle 3
7878

7979
#test ICMP ttl exceeded packet
8080
test_fail sudo ip netns exec ns1 ping 10.0.2.2 -b -t1 -c 2 -i 0.5
81-
82-

src/services/pcn-router/test/test_shadow/test1.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ polycubectl router add r1 shadow=true
1717
sudo ip netns ls
1818

1919
# Add port p1
20-
router_add_port r1 p1 10.0.0.1 255.255.255.0
20+
router_add_port r1 p1 10.0.0.1/24
2121
sudo ip netns exec pcn-r1 ip -c a
2222

2323
# Change the Ip address of the p1 port from Linux

src/services/pcn-router/test/test_shadow/test4.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ set -e
2727

2828
# Create the router r1 (shadow) and the port p1
2929
polycubectl router add r1 shadow=true
30-
router_add_port r1 p1 10.0.0.1 255.255.255.0
30+
router_add_port r1 p1 10.0.0.1/24
3131

3232
# Show router r1
3333
polycubectl router r1 show

0 commit comments

Comments
 (0)