Commit e6b19c1
authored
Remove to_html stub (#1132)
The recent change that added inline data explorers for R caused a
regression in printing data frames at the R console.
Ark contains a stub for printing data frames that just says `Hello,
world!` Before the PR, it was dead code because the old code looked for
`.Last.value` in `R_GlobalEnv` (where it doesn't exist), while R stores
it in the base environment. The new code correctly uses`
harp::environment::last_value()` which finds it in the base env, so now
the stub actually gets called for data frames.
The fix here is to remove the stub entirely since it doesn't do anything
useful. We can add it back if we decided to implement HTML/tabular
output for data frames properly.
Will address posit-dev/positron#12799.1 parent e7ecac6 commit e6b19c1
2 files changed
Lines changed: 1 addition & 29 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1158 | 1158 | | |
1159 | 1159 | | |
1160 | 1160 | | |
1161 | | - | |
| 1161 | + | |
1162 | 1162 | | |
1163 | 1163 | | |
1164 | 1164 | | |
1165 | | - | |
1166 | | - | |
1167 | | - | |
1168 | | - | |
1169 | | - | |
1170 | | - | |
1171 | | - | |
1172 | | - | |
1173 | 1165 | | |
1174 | 1166 | | |
1175 | 1167 | | |
| |||
2426 | 2418 | | |
2427 | 2419 | | |
2428 | 2420 | | |
2429 | | - | |
2430 | | - | |
2431 | | - | |
2432 | | - | |
2433 | | - | |
2434 | | - | |
2435 | | - | |
2436 | | - | |
2437 | | - | |
2438 | 2421 | | |
2439 | 2422 | | |
2440 | 2423 | | |
| |||
This file was deleted.
0 commit comments