Removing redundant call to TryUpdateAutoUpdatedDependencies during post-publish step.

Author: gfraiteur

src/PostSharp.Engineering.BuildTools/Build/Model/Product.cs

@@ -1793,6 +1793,13 @@ public bool PrePublish( BuildContext context, PublishSettings settings )
                 return false;
             }
 
+            if ( !TryUpdateAutoUpdatedDependencies( context, settings ) )
+            {
+                context.Console.WriteError( "Failed to update auto-updated dependencies." );
+                
+                return false;
+            }
+            
             if ( !GitHelper.TryPullAndMergeAndPush( context, settings, targetBranch ) )
             {
                 return false;
@@ -1883,13 +1890,6 @@ public bool Publish( BuildContext context, PublishSettings settings )
                     }
                 }
 
-                if ( !TryUpdateAutoUpdatedDependencies( context, settings ) )
-                {
-                    context.Console.WriteError( "Failed to update auto-updated dependencies." );
-
-                    return false;
-                }
-
                 if ( !this.TryAddTagToLastCommit( context, settings ) )
                 {
                     context.Console.WriteError( "Failed to tag the latest commit." );
@@ -1941,7 +1941,7 @@ public bool Publish( BuildContext context, PublishSettings settings )
 
         public bool PostPublish( BuildContext context, PublishSettings settings )
         {
-            context.Console.WriteHeading( "Finishing publishig" );
+            context.Console.WriteHeading( "Finishing publishing." );
 
             if ( !this.PrepareVersionsFile( context, settings, out _ ) )
             {
@@ -1973,13 +1973,6 @@ public bool PostPublish( BuildContext context, PublishSettings settings )
 
                 return false;
             }
-            
-            if ( !TryUpdateAutoUpdatedDependencies( context, settings ) )
-            {
-                context.Console.WriteError( "Failed to update auto-updated dependencies." );
-                
-                return false;
-            }
 
             if ( !this.TryAddTagToLastCommit( context, settings ) )
             {
@@ -2312,8 +2305,7 @@ private bool TryReadDependencyVersionsFromSourceRepos(
                 }
 
                 var mainVersionFile = $"{dependency.EngineeringDirectory}/MainVersion.props";
-                context.Console.WriteMessage( $"Downloading '{mainVersionFile}' from '{dependency.VcsRepository}'." );
-
+                
                 if ( !dependency.VcsRepository.TryDownloadTextFile( context.Console, dependency.Branch, mainVersionFile, out var mainVersionContent ) )
                 {
                     return false;

src/PostSharp.Engineering.BuildTools/ContinuousIntegration/AzureDevOpsRepository.cs

@@ -81,7 +81,10 @@ public override bool TryDownloadTextFile( ConsoleHelper console, string branch,
         var authString = Convert.ToBase64String( Encoding.UTF8.GetBytes( $@"{TeamCityHelper.TeamCityUsername}:{teamCitySourceReadToken}" ) );
         httpClient.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue( "Basic", authString );
 
-        text = httpClient.GetString( $"{this.BaseUrl}/{this.Project}/_apis/git/repositories/{this.Name}/items?path={path}&versionDescriptor.version={branch}" );
+        var uri = $"{this.BaseUrl}/{this.Project}/_apis/git/repositories/{this.Name}/items?path={path}&versionDescriptor.version={branch}";
+        
+        console.WriteMessage( $"Downloading {uri}." );
+        text = httpClient.GetString( uri );
 
         return true;
     }