Search: Fixed TeamCity script generation.

Author: gfraiteur

src/PostSharp.Engineering.BuildTools/Search/Crawlers/PlainDocumentParser.cs

@@ -28,7 +28,7 @@ public override Task<IReadOnlyCollection<Snippet>> GetSnippetsFromDocument(
         {
             throw new ArgumentException( nameof(document) );
         }
-        
+
         var snippets = new List<Snippet>();
 
         var title = document.DocumentNode.SelectSingleNode( "/html/head/meta[@name=\"title\"]" )?.Attributes["content"]?.Value ??
@@ -47,9 +47,9 @@ public override Task<IReadOnlyCollection<Snippet>> GetSnippetsFromDocument(
 
         var keywordsNode = document.DocumentNode?.SelectSingleNode( "/html/head/meta[@name=\"keywords\"]" );
         var keywords = keywordsNode?.Attributes["content"]?.Value?.Trim() ?? "";
-        
+
         var breadcrumbLinks = document.DocumentNode
-            .SelectSingleNode( "//nav[@itemtype=\"https://schema.org/BreadcrumbList\"]" )
+            !.SelectSingleNode( "//nav[@itemtype=\"https://schema.org/BreadcrumbList\"]" )
             ?
             .SelectNodes( ".//span[@itemprop=\"name\"]" )
             .Select( node => node.GetText() )

src/PostSharp.Engineering.BuildTools/Search/UpdateSearchProductExtension.cs

@@ -26,8 +26,6 @@ public class UpdateSearchProductExtension : ProductExtension
 
     public DocumentParserFactory DocumentParserFactory { get; }
 
-    public bool IgnoreTls { get; }
-
     public BuildConfiguration[] BuildConfigurations { get; }
 
     public TimeSpan TimeOutThreshold { get; }
@@ -44,7 +42,6 @@ public UpdateSearchProductExtension(
         string sourceUrl,
         Func<DocumentParser> createParser,
         ImmutableArray<string> products,
-        bool ignoreTls = false,
         BuildConfiguration[]? buildConfigurations = null,
         TimeSpan? timeOutThreshold = null,
         string? customBuildConfigurationName = null,
@@ -55,7 +52,6 @@ public UpdateSearchProductExtension(
         this.SourceUrl = sourceUrl;
         this.DocumentParserFactory = new DocumentParserFactory( createParser );
         this.Products = products;
-        this.IgnoreTls = ignoreTls;
         this.BuildConfigurations = buildConfigurations ?? [BuildConfiguration.Public];
         this.TimeOutThreshold = timeOutThreshold ?? TimeSpan.FromMinutes( 5 );
         this.CustomBuildConfigurationName = customBuildConfigurationName;
@@ -66,14 +62,7 @@ internal override bool AddTeamcityBuildConfiguration( BuildContext context, List
     {
         TeamCityBuildStep CreateBuildStep()
         {
-            var arguments = new List<string> { this.TypesenseUri, this.Source, this.SourceUrl };
-
-            if ( this.IgnoreTls )
-            {
-                arguments.Add( "--ignore-tls" );
-            }
-
-            return new TeamCityEngineeringCommandBuildStep( "UpdateSearch", "Update search", "tools search update", string.Join( " ", arguments ), true );
+            return new TeamCityEngineeringCommandBuildStep( "UpdateSearch", "Update search", "search update", null, true );
         }
 
         foreach ( var configuration in this.BuildConfigurations )

src/PostSharp.Engineering.BuildTools/Search/Updaters/DocumentationUpdater.cs

@@ -26,22 +26,13 @@ public override async Task<bool> UpdateAsync( BuildContext context, UpdateSearch
     {
         var productExtension = context.Product.Extensions.OfType<UpdateSearchProductExtension>().Single();
 
-        HttpClient web;
+        var handler = new HttpClientHandler();
+        handler.ClientCertificateOptions = ClientCertificateOption.Manual;
+        
+        handler.ServerCertificateCustomValidationCallback =
+            ( _, _, _, _ ) => true;
 
-        if ( productExtension.IgnoreTls )
-        {
-            var handler = new HttpClientHandler();
-            handler.ClientCertificateOptions = ClientCertificateOption.Manual;
-
-            handler.ServerCertificateCustomValidationCallback =
-                ( _, _, _, _ ) => true;
-
-            web = new HttpClient( handler );
-        }
-        else
-        {
-            web = new HttpClient();
-        }
+        var web = new HttpClient( handler );
 
         using ( web )
         {