Warnings.

Author: gfraiteur

src/PostSharp.Engineering.McpApprovalServer/Mcp/Services/CommandHistoryService.cs

@@ -99,7 +99,7 @@ public void Record(
         }
 
         // Append to daily audit trail (outside lock - separate concern)
-        this.AppendToAuditTrail( record );
+        AppendToAuditTrail( record );
 
         // Notify listeners
         this.HistoryUpdated?.Invoke( this, EventArgs.Empty );
@@ -119,14 +119,6 @@ public bool WasPreviouslyApproved( string sessionId, string command, string work
         }
     }
 
-    /// <summary>
-    /// Clears a session. For compatibility - no-op since we use global history.
-    /// </summary>
-    public void ClearSession( string sessionId )
-    {
-        // No-op - we maintain global history now
-    }
-
     private void LoadHistory()
     {
         try
@@ -191,7 +183,7 @@ private void SaveHistory()
         return output[..maxOutputLength] + "... (truncated)";
     }
 
-    private void AppendToAuditTrail( CommandRecord record )
+    private static void AppendToAuditTrail( CommandRecord record )
     {
         try
         {
@@ -211,9 +203,9 @@ private void AppendToAuditTrail( CommandRecord record )
             var exitCode = record.ExitCode?.ToString( CultureInfo.InvariantCulture ) ?? "N/A";
 
             // Escape pipe characters in fields
-            var command = record.Command.Replace( "|", "\\|" );
-            var purpose = record.ClaimedPurpose.Replace( "|", "\\|" );
-            var workingDir = record.WorkingDirectory.Replace( "|", "\\|" );
+            var command = record.Command.Replace( "|", "\\|", StringComparison.Ordinal );
+            var purpose = record.ClaimedPurpose.Replace( "|", "\\|", StringComparison.Ordinal );
+            var workingDir = record.WorkingDirectory.Replace( "|", "\\|", StringComparison.Ordinal );
 
             var logLine = $"{timestamp} | {status} | {command} | {purpose} | {workingDir} | {gitBranch} | {exitCode}";
 

src/PostSharp.Engineering.McpApprovalServer/Mcp/Services/RegexRuleEngine.cs

@@ -17,15 +17,15 @@ public sealed class RegexRuleEngine
     /// <summary>
     /// Evaluates a command against regex-based rules, considering git context.
     /// </summary>
-    public Task<RiskAssessment> EvaluateAsync(
+    public static Task<RiskAssessment> EvaluateAsync(
         string command,
         string claimedPurpose,
         string workingDirectory,
         IReadOnlyList<CommandRecord> sessionHistory,
         CancellationToken cancellationToken = default )
     {
         // Build command context with git information
-        var context = this.BuildContext( command, workingDirectory );
+        var context = BuildContext( command, workingDirectory );
 
         // Evaluate all rules in order
         foreach ( var rule in CommandRules.DefaultRules )
@@ -55,7 +55,7 @@ public Task<RiskAssessment> EvaluateAsync(
             } );
     }
 
-    private CommandContext BuildContext( string command, string workingDirectory )
+    private static CommandContext BuildContext( string command, string workingDirectory )
     {
         var context = new CommandContext { Command = command, WorkingDirectory = workingDirectory };
 
@@ -73,27 +73,27 @@ private CommandContext BuildContext( string command, string workingDirectory )
         }
 
         // Try to get current branch
-        if ( this.TryRunGitCommand( workingDirectory, "rev-parse --abbrev-ref HEAD", out var currentBranch ) )
+        if ( TryRunGitCommand( workingDirectory, "rev-parse --abbrev-ref HEAD", out var currentBranch ) )
         {
             context = context with { CurrentBranch = currentBranch.Trim() };
         }
 
         // Try to get remote URL
-        if ( this.TryRunGitCommand( workingDirectory, "config --get remote.origin.url", out var remoteUrl ) )
+        if ( TryRunGitCommand( workingDirectory, "config --get remote.origin.url", out var remoteUrl ) )
         {
             context = context with { RemoteUrl = remoteUrl.Trim() };
         }
 
         // Try to check if merge is in progress
-        if ( this.TryRunGitCommand( workingDirectory, "rev-parse -q --verify MERGE_HEAD", out _ ) )
+        if ( TryRunGitCommand( workingDirectory, "rev-parse -q --verify MERGE_HEAD", out _ ) )
         {
             context = context with { IsMergeInProgress = true };
         }
 
         return context;
     }
 
-    private bool TryRunGitCommand( string workingDirectory, string arguments, out string output )
+    private static bool TryRunGitCommand( string workingDirectory, string arguments, out string output )
     {
         try
         {

src/PostSharp.Engineering.McpApprovalServer/Mcp/Tools/ExecuteCommandTool.cs

@@ -90,7 +90,7 @@ public async Task<CommandResult> ExecuteCommand(
                 sessionHistory,
                 cancellationToken );
 
-            var regexTask = this._regexEngine.EvaluateAsync(
+            var regexTask = RegexRuleEngine.EvaluateAsync(
                 command,
                 claimedPurpose,
                 workingDirectory,