Skip to content

Commit e53d281

Browse files
committed
fix(release): skip node-gyp-build in smoke test to use platform binaries
The pre-publish smoke test was failing because node-gyp-build ran during npm install before the platform package was installed, triggering a source build that failed without FFmpeg. Changes: - Add --ignore-scripts to smoke test npm install in release.yml - Update optionalDependencies versions to match main package (0.1.1-alpha.5) The platform package is installed separately from CI artifacts, and the verification step confirms the native binding loads correctly.
1 parent ab9590b commit e53d281

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

.github/workflows/release.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,8 @@ jobs:
147147
npm init -y
148148
149149
# Install from the local tarball (simulating what npm publish would produce)
150-
npm install "../${{ env.PACKED_TGZ }}"
150+
# Use --ignore-scripts to skip node-gyp-build (platform package provides binary)
151+
npm install --ignore-scripts "../${{ env.PACKED_TGZ }}"
151152
152153
# Also install the platform package from extracted artifact
153154
npm install "../packages/@pproenca/node-webcodecs-${{ matrix.platform }}"

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,9 @@
6666
"directory": "test/types"
6767
},
6868
"optionalDependencies": {
69-
"@pproenca/node-webcodecs-darwin-arm64": "0.1.1-alpha.4",
70-
"@pproenca/node-webcodecs-darwin-x64": "0.1.1-alpha.4",
71-
"@pproenca/node-webcodecs-linux-x64": "0.1.1-alpha.4"
69+
"@pproenca/node-webcodecs-darwin-arm64": "0.1.1-alpha.5",
70+
"@pproenca/node-webcodecs-darwin-x64": "0.1.1-alpha.5",
71+
"@pproenca/node-webcodecs-linux-x64": "0.1.1-alpha.5"
7272
},
7373
"dependencies": {
7474
"node-gyp-build": "^4.8.0"

0 commit comments

Comments
 (0)