Skip to content

Commit 0e69066

Browse files
authored
Merge pull request #53 from psteiwer/dev-nodata
Dev nodata
2 parents 4d4b9bb + f4f3d91 commit 0e69066

3 files changed

Lines changed: 21 additions & 6 deletions

File tree

PivotSubscriptions/Task.cls

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,15 +132,17 @@ ClassMethod SendEmail(pID, pPivot As %String, pEmails As %String, pFormat As %St
132132
}
133133
} Else {
134134
Do ##class(PivotSubscriptions.Utils).WriteEmailHeader(msg)
135-
Do msg.TextData.WriteLine("No data for requested pivot.")
135+
Do msg.TextData.WriteLine($G(^PivotSubscriptions.Settings("NoDataMessage"),"No data for requested pivot."))
136136
Do ##class(PivotSubscriptions.Utils).WriteEmailFooter(msg)
137137
}
138138
}
139139

140140
Do msg.To.SetAt(tEmail,1)
141141

142142
// Send email
143-
Set tSC=server.Send(msg)
143+
If $G(^PivotSubscriptions.Settings("SendNoData"),1) {
144+
Set tSC=server.Send(msg)
145+
}
144146
// TODO: Log individual send status?
145147

146148
If tHasResults {

PivotSubscriptions/UI/ConfigurationPage.cls

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ XData contentPane [ XMLNamespace = "http://www.intersystems.com/zen" ]
1919
<radioSet id="HTTPButton" label="HTTP or HTTPS?" displayList="HTTP, HTTPs" valueList="http://,https://" />
2020
<text id="ServerText" label="Server" size="25" />
2121
<text id="PortText" label="Port Number" size="25" />
22+
<label label="No Data Settings" labelClass="sectionCaption" containerStyle="padding-top:5px;padding-bottom:5px;" />
23+
<radioSet id="NoDataEmail" label="Send No Data Email" displayList="Yes,No" valueList="1,0" value="1"/>
24+
<textarea id="NoDataMessage" label="No Data Message" cols="50" rows="3" value="No data for requested pivot."/>
2225
</vgroup>
2326
</hgroup>
2427
<hgroup>
@@ -61,6 +64,12 @@ Method %OnAfterCreatePage() As %Status
6164
If $G(^PivotSubscriptions.Settings("Port"))'="" {
6265
Set ..%GetComponentById("PortText").value=^PivotSubscriptions.Settings("Port")
6366
}
67+
If $G(^PivotSubscriptions.Settings("SendNoData"))'="" {
68+
Set ..%GetComponentById("NoDataEmail").value=^PivotSubscriptions.Settings("SendNoData")
69+
}
70+
If $G(^PivotSubscriptions.Settings("NoDataMessage"))'="" {
71+
Set ..%GetComponentById("NoDataMessage").value=^PivotSubscriptions.Settings("NoDataMessage")
72+
}
6473

6574
Quit $$$OK
6675
}
@@ -72,19 +81,21 @@ ClientMethod ButtonClick() [ Language = javascript ]
7281
var http=zen('HTTPButton').getValue();
7382
var server=zen('ServerText').getValue();
7483
var port=zen('PortText').getValue();
84+
var nodataemail=zen('NoDataEmail').getValue();
85+
var nodatamessage=zen('NoDataMessage').getValue();
7586

76-
var status=zenPage.SaveConfiguration(adminemail,http,server,port);
87+
var status=zenPage.SaveConfiguration(adminemail,http,server,port,nodataemail,nodatamessage);
7788
}
7889
catch(ex) {
7990
zenExceptionHandler(ex,arguments);
8091
}
8192
}
8293

83-
Method SaveConfiguration(pAdminEmail, pHttp, pServer, pPort) As %Status [ ZenMethod ]
94+
Method SaveConfiguration(pAdminEmail, pHttp, pServer, pPort, pNoDataEmail, pNoDataMessage) As %Status [ ZenMethod ]
8495
{
8596
Set tSC=$$$OK
8697

87-
Set tSC = ##class(PivotSubscriptions.Utils).ConfigureSettings(pAdminEmail, pHttp, pServer, pPort)
98+
Set tSC = ##class(PivotSubscriptions.Utils).ConfigureSettings(pAdminEmail, pHttp, pServer, pPort, pNoDataEmail, pNoDataMessage)
8899

89100
Quit tSC
90101
}

PivotSubscriptions/Utils.cls

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,14 @@ ClassMethod GetVersion() As %String
77
}
88

99
/// Utility method for saving and updating global variables
10-
ClassMethod ConfigureSettings(pAdminEmail, pHttp, pServer, pPort)
10+
ClassMethod ConfigureSettings(pAdminEmail, pHttp, pServer, pPort, pNoDataEmail, pNoDataMessage)
1111
{
1212
Set ^PivotSubscriptions.Settings("AdminEmail")=pAdminEmail
1313
Set ^PivotSubscriptions.Settings("Http")=pHttp
1414
Set ^PivotSubscriptions.Settings("Server")=pServer
1515
Set ^PivotSubscriptions.Settings("Port")=pPort
16+
Set ^PivotSubscriptions.Settings("SendNoData")=pNoDataEmail
17+
Set ^PivotSubscriptions.Settings("NoDataMessage")=pNoDataMessage
1618

1719
Quit $$$OK
1820
}

0 commit comments

Comments
 (0)